<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44478] trunk/tests/phpunit/tests: Tests: Add missing test cases for `is_serialized_string()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44478">44478</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44478","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-01-08 19:04:51 +0000 (Tue, 08 Jan 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Tests: Add missing test cases for `is_serialized_string()`.
Also, reorganize these tests into their own class.
Props pbearne.
Fixes <a href="https://core.trac.wordpress.org/ticket/42870">#42870</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsfunctionsphp">trunk/tests/phpunit/tests/functions.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsfunctionsisSerializedStringphp">trunk/tests/phpunit/tests/functions/isSerializedString.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsfunctionsisSerializedStringphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/functions/isSerializedString.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/functions/isSerializedString.php (rev 0)
+++ trunk/tests/phpunit/tests/functions/isSerializedString.php 2019-01-08 19:04:51 UTC (rev 44478)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,68 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * Tests for `is_serialized_string()`.
+ *
+ * @group functions.php
+ * @ticket 42870
+ */
+class Tests_Functions_Is_Serialized_String extends WP_UnitTestCase {
+
+ /**
+ * Data provider method for testing `is_serialized_string()`.
+ *
+ * @return array
+ */
+ public function _is_serialized_string() {
+ return array(
+
+ // pass array.
+ array( array(), false ),
+
+ // pass a class.
+ array( new stdClass(), false ),
+
+ // Not a string.
+ array( 0, false ),
+
+ // Too short when trimmed.
+ array( 's:3 ', false ),
+
+ // Too short.
+ array( 's:3', false ),
+
+ // No colon in second position.
+ array( 's!3:"foo";', false ),
+
+ // No trailing semicolon.
+ array( 's:3:"foo"', false ),
+
+ // Wrong type.
+ array( 'a:3:"foo";', false ),
+
+ // No closing quote.
+ array( 'a:3:"foo;', false ),
+
+ // have to use double Quotes.
+ array( "s:12:'foo';", false ),
+
+ // Wrong number of characters is close enough for is_serialized_string().
+ array( 's:12:"foo";', true ),
+
+ // Okay.
+ array( 's:3:"foo";', true ),
+ );
+ }
+
+ /**
+ * Run tests on `is_serialized_string()`.
+ *
+ * @dataProvider _is_serialized_string
+ *
+ * @param array|object|int|string $data Data value to test.
+ * @param bool $expected Expected function result.
+ */
+ public function test_is_serialized_string( $data, $expected ) {
+ $this->assertSame( $expected, is_serialized_string( $data ) );
+ }
+}
</ins></span></pre></div>
<a id="trunktestsphpunittestsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/functions.php 2019-01-08 18:32:10 UTC (rev 44477)
+++ trunk/tests/phpunit/tests/functions.php 2019-01-08 19:04:51 UTC (rev 44478)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -236,45 +236,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( is_serialized( 'C:16:"Serialized_Class":6:{a:0:{}}' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /**
- * @dataProvider data_is_serialized_string
- */
- public function test_is_serialized_string( $value, $result ) {
- $this->assertSame( is_serialized_string( $value ), $result );
- }
</del><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function data_is_serialized_string() {
- return array(
- // Not a string.
- array( 0, false ),
-
- // Too short when trimmed.
- array( 's:3 ', false ),
-
- // Too short.
- array( 's:3', false ),
-
- // No colon in second position.
- array( 's!3:"foo";', false ),
-
- // No trailing semicolon.
- array( 's:3:"foo"', false ),
-
- // Wrong type.
- array( 'a:3:"foo";', false ),
-
- // No closing quote.
- array( 'a:3:"foo;', false ),
-
- // Wrong number of characters is close enough for is_serialized_string().
- array( 's:12:"foo";', true ),
-
- // Okay.
- array( 's:3:"foo";', true ),
-
- );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @group add_query_arg
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span></span></pre>
</div>
</div>
</body>
</html>