<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44376] trunk/src/wp-content/themes/twentynineteen: Twenty Nineteen: Improve menu semantics and keyboard navigation.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44376">44376</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44376","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>laurelfulford</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-12-31 17:48:08 +0000 (Mon, 31 Dec 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Twenty Nineteen: Improve menu semantics and keyboard navigation.
The menu's original markup included some non-semantic tags and an unnecessary `tabindex` attribute that made it difficult to navigate via keyboard.
Props allancole, anevins, kjellr.
Fixes <a href="https://core.trac.wordpress.org/ticket/45713">#45713</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpcontentthemestwentynineteeninctemplatefunctionsphp">trunk/src/wp-content/themes/twentynineteen/inc/template-functions.php</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteenjstouchkeyboardnavigationjs">trunk/src/wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteensassnavigation_menumainnavigationscss">trunk/src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteenstylertlcss">trunk/src/wp-content/themes/twentynineteen/style-rtl.css</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteenstylecss">trunk/src/wp-content/themes/twentynineteen/style.css</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteentemplatepartsheadersitebrandingphp">trunk/src/wp-content/themes/twentynineteen/template-parts/header/site-branding.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpcontentthemestwentynineteeninctemplatefunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/inc/template-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/inc/template-functions.php 2018-12-30 05:05:49 UTC (rev 44375)
+++ trunk/src/wp-content/themes/twentynineteen/inc/template-functions.php 2018-12-31 17:48:08 UTC (rev 44376)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -203,18 +203,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'menu-1' === $args->theme_location ) :
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= '<div class="main-menu-more">';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $nav_menu .= '<ul class="main-menu" tabindex="0">';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $nav_menu .= '<ul class="main-menu">';
</ins><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= '<li class="menu-item menu-item-has-children">';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $nav_menu .= '<a href="#" class="screen-reader-text" aria-label="More" aria-haspopup="true" aria-expanded="false">' . esc_html__( 'More', 'twentynineteen' ) . '</a>';
- $nav_menu .= '<span class="submenu-expand main-menu-more-toggle is-empty" tabindex="-1">';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $nav_menu .= '<button class="submenu-expand main-menu-more-toggle is-empty" tabindex="-1" aria-label="More" aria-haspopup="true" aria-expanded="false">';
+ $nav_menu .= '<span class="screen-reader-text">' . esc_html__( 'More', 'twentynineteen' ) . '</span>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= twentynineteen_get_icon_svg( 'arrow_drop_down_ellipsis' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $nav_menu .= '</span>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $nav_menu .= '</button>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= '<ul class="sub-menu hidden-links">';
</span><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= '<li id="menu-item--1" class="mobile-parent-nav-menu-item menu-item--1">';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $nav_menu .= '<span class="menu-item-link-return">';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $nav_menu .= '<button class="menu-item-link-return">';
</ins><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= twentynineteen_get_icon_svg( 'chevron_left' );
</span><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= esc_html__( 'Back', 'twentynineteen' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $nav_menu .= '</span>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $nav_menu .= '</button>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= '</li>';
</span><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= '</ul>';
</span><span class="cx" style="display: block; padding: 0 10px"> $nav_menu .= '</li>';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -269,11 +269,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Inject the keyboard_arrow_left SVG inside the parent nav menu item, and let the item link to the parent item.
</span><span class="cx" style="display: block; padding: 0 10px"> // @todo Only do this for nested submenus? If on a first-level submenu, then really the link could be "#" since the desire is to remove the target entirely.
</span><span class="cx" style="display: block; padding: 0 10px"> $link = sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<span class="menu-item-link-return" tabindex="-1">%s',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<button class="menu-item-link-return" tabindex="-1">%s',
</ins><span class="cx" style="display: block; padding: 0 10px"> twentynineteen_get_icon_svg( 'chevron_left', 24 )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // replace opening <a> with <span>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // replace opening <a> with <button>
</ins><span class="cx" style="display: block; padding: 0 10px"> $output = preg_replace(
</span><span class="cx" style="display: block; padding: 0 10px"> '/<a\s.*?>/',
</span><span class="cx" style="display: block; padding: 0 10px"> $link,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -281,10 +281,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 1 // Limit.
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // replace closing </a> with </span>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // replace closing </a> with </button>
</ins><span class="cx" style="display: block; padding: 0 10px"> $output = preg_replace(
</span><span class="cx" style="display: block; padding: 0 10px"> '#</a>#i',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '</span>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '</button>',
</ins><span class="cx" style="display: block; padding: 0 10px"> $output,
</span><span class="cx" style="display: block; padding: 0 10px"> 1 // Limit.
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -295,7 +295,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $icon = twentynineteen_get_icon_svg( 'keyboard_arrow_down', 24 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $output .= sprintf(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- '<span class="submenu-expand" tabindex="-1">%s</span>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '<button class="submenu-expand" tabindex="-1">%s</button>',
</ins><span class="cx" style="display: block; padding: 0 10px"> $icon
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteenjstouchkeyboardnavigationjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js 2018-12-30 05:05:49 UTC (rev 44375)
+++ trunk/src/wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js 2018-12-31 17:48:08 UTC (rev 44376)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -112,7 +112,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> currentSubMenu.parentElement.lastElementChild.className += ' expanded-true';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Update aria-expanded state
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- toggleAriaExpandedState( currentSubMenu.previousSibling );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ toggleAriaExpandedState( currentSubMenu );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -230,7 +230,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> openSubMenu(event.target);
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Check if child of .submenu-expand is touched
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- } else if ( null != getCurrentParent( event.target, '.submenu-expand' ) && getCurrentParent( event.target, '.submenu-expand' ).matches( '.submenu-expand' ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } else if ( null != getCurrentParent( event.target, '.submenu-expand' ) &&
+ getCurrentParent( event.target, '.submenu-expand' ).matches( '.submenu-expand' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> openSubMenu( getCurrentParent( event.target, '.submenu-expand' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Check if .menu-item-link-return is touched
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -254,6 +255,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( null != mainNav && hasClass( mainNav, '.main-navigation' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Prevent default mouse events
</span><span class="cx" style="display: block; padding: 0 10px"> event.preventDefault();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> } else if (
</span><span class="cx" style="display: block; padding: 0 10px"> event.target.matches('.submenu-expand') ||
</span><span class="cx" style="display: block; padding: 0 10px"> null != getCurrentParent( event.target, '.submenu-expand' ) &&
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteensassnavigation_menumainnavigationscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss 2018-12-30 05:05:49 UTC (rev 44375)
+++ trunk/src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss 2018-12-31 17:48:08 UTC (rev 44376)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -13,6 +13,39 @@
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /* Un-style buttons */
+ button {
+ display: inline-block;
+ border: none;
+ padding: 0;
+ margin: 0;
+ font-family: $font__heading;
+ font-weight: 700;
+ line-height: $font__line-height-heading;
+ text-decoration: none;
+ background: transparent;
+ color: inherit;
+ cursor: pointer;
+ transition: background 250ms ease-in-out,
+ transform 150ms ease;
+ -webkit-appearance: none;
+ -moz-appearance: none;
+
+ &:hover,
+ &:focus {
+ background: transparent;
+ }
+
+ &:focus {
+ outline: 1px solid transparent;
+ outline-offset: -4px;
+ }
+
+ &:active {
+ transform: scale(0.99);
+ }
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .main-menu {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline-block;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -183,6 +216,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ > .menu-item-link-return {
+ width: 100%;
+ font-size: $font__size_base;
+ font-weight: normal;
+ text-align: left;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> > a:empty {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteenstylertlcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/style-rtl.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/style-rtl.css 2018-12-30 05:05:49 UTC (rev 44375)
+++ trunk/src/wp-content/themes/twentynineteen/style-rtl.css 2018-12-31 17:48:08 UTC (rev 44376)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1027,6 +1027,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .main-navigation {
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> margin-top: 0.25rem;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /* Un-style buttons */
</ins><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * Sub-menu styles
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1049,6 +1050,36 @@
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.main-navigation button {
+ display: inline-block;
+ border: none;
+ padding: 0;
+ margin: 0;
+ font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
+ font-weight: 700;
+ line-height: 1.2;
+ text-decoration: none;
+ background: transparent;
+ color: inherit;
+ cursor: pointer;
+ transition: background 250ms ease-in-out, transform 150ms ease;
+ -webkit-appearance: none;
+ -moz-appearance: none;
+}
+
+.main-navigation button:hover, .main-navigation button:focus {
+ background: transparent;
+}
+
+.main-navigation button:focus {
+ outline: 1px solid transparent;
+ outline-offset: -4px;
+}
+
+.main-navigation button:active {
+ transform: scale(0.99);
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .main-navigation .main-menu {
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline-block;
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1207,6 +1238,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> background: #005177;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.main-navigation .sub-menu > li > .menu-item-link-return {
+ width: 100%;
+ font-size: 22px;
+ font-weight: normal;
+ text-align: right;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .main-navigation .sub-menu > li > a:empty {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteenstylecss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/style.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/style.css 2018-12-30 05:05:49 UTC (rev 44375)
+++ trunk/src/wp-content/themes/twentynineteen/style.css 2018-12-31 17:48:08 UTC (rev 44376)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1027,6 +1027,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .main-navigation {
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> margin-top: 0.25rem;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /* Un-style buttons */
</ins><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * Sub-menu styles
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1049,6 +1050,36 @@
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.main-navigation button {
+ display: inline-block;
+ border: none;
+ padding: 0;
+ margin: 0;
+ font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
+ font-weight: 700;
+ line-height: 1.2;
+ text-decoration: none;
+ background: transparent;
+ color: inherit;
+ cursor: pointer;
+ transition: background 250ms ease-in-out, transform 150ms ease;
+ -webkit-appearance: none;
+ -moz-appearance: none;
+}
+
+.main-navigation button:hover, .main-navigation button:focus {
+ background: transparent;
+}
+
+.main-navigation button:focus {
+ outline: 1px solid transparent;
+ outline-offset: -4px;
+}
+
+.main-navigation button:active {
+ transform: scale(0.99);
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .main-navigation .main-menu {
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline-block;
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1207,6 +1238,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> background: #005177;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.main-navigation .sub-menu > li > .menu-item-link-return {
+ width: 100%;
+ font-size: 22px;
+ font-weight: normal;
+ text-align: left;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .main-navigation .sub-menu > li > a:empty {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteentemplatepartsheadersitebrandingphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/template-parts/header/site-branding.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/template-parts/header/site-branding.php 2018-12-30 05:05:49 UTC (rev 44375)
+++ trunk/src/wp-content/themes/twentynineteen/template-parts/header/site-branding.php 2018-12-31 17:48:08 UTC (rev 44376)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -36,7 +36,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'theme_location' => 'menu-1',
</span><span class="cx" style="display: block; padding: 0 10px"> 'menu_class' => 'main-menu',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'items_wrap' => '<ul id="%1$s" class="%2$s" tabindex="0">%3$s</ul>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'items_wrap' => '<ul id="%1$s" class="%2$s">%3$s</ul>',
</ins><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span></span></pre>
</div>
</div>
</body>
</html>