<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44371] trunk/src/wp-content/themes/twentynineteen: Twenty Nineteen: Push right-aligned image block outside of text column.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44371">44371</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44371","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>laurelfulford</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-12-28 21:21:48 +0000 (Fri, 28 Dec 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Twenty Nineteen: Push right-aligned image block outside of text column.
Update right-aligned image block styles to push them outside of the text column on the front end, to match the original design and how the block looks in the editor.
Props kjellr, joen, allancole.
Fixes <a href="https://core.trac.wordpress.org/ticket/45716">#45716</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpcontentthemestwentynineteensassblocks_blocksscss">trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteenstylertlcss">trunk/src/wp-content/themes/twentynineteen/style-rtl.css</a></li>
<li><a href="#trunksrcwpcontentthemestwentynineteenstylecss">trunk/src/wp-content/themes/twentynineteen/style.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpcontentthemestwentynineteensassblocks_blocksscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss 2018-12-28 20:14:26 UTC (rev 44370)
+++ trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss 2018-12-28 21:21:48 UTC (rev 44371)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -505,20 +505,40 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> //! Image
</span><span class="cx" style="display: block; padding: 0 10px"> .wp-block-image {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ max-width: 100%;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> img {
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- &.alignleft,
- &.alignright {
- max-width: 100%;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .aligncenter {
+
+ @include postContentMaxWidth();
+
+ @include media(tablet) {
+ margin: 0;
+ width: $size__site-tablet-content;
+
+ img {
+ margin: 0 auto;
+ }
+ }
+
+ @include media(desktop) {
+ width: $size__site-desktop-content;
+
+ img {
+ margin: 0 auto;
+ }
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> &.alignfull img {
</span><span class="cx" style="display: block; padding: 0 10px"> width: 100vw;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ max-width: calc( 100% + (2 * #{$size__spacing-unit}));
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> @include media(tablet) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ max-width: calc( 125% + 150px );
</ins><span class="cx" style="display: block; padding: 0 10px"> margin-left: auto;
</span><span class="cx" style="display: block; padding: 0 10px"> margin-right: auto;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteenstylertlcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/style-rtl.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/style-rtl.css 2018-12-28 20:14:26 UTC (rev 44370)
+++ trunk/src/wp-content/themes/twentynineteen/style-rtl.css 2018-12-28 21:21:48 UTC (rev 44371)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3944,20 +3944,53 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.entry .entry-content .wp-block-image {
+ max-width: 100%;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-image img {
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.entry .entry-content .wp-block-image.alignleft, .entry .entry-content .wp-block-image.alignright {
- max-width: 100%;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+@media only screen and (min-width: 768px) {
+ .entry .entry-content .wp-block-image .aligncenter {
+ max-width: calc(8 * (100vw / 12) - 28px);
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+@media only screen and (min-width: 1168px) {
+ .entry .entry-content .wp-block-image .aligncenter {
+ max-width: calc(6 * (100vw / 12) - 28px);
+ }
+}
+
+@media only screen and (min-width: 768px) {
+ .entry .entry-content .wp-block-image .aligncenter {
+ margin: 0;
+ width: calc(8 * (100vw / 12) - 28px);
+ }
+ .entry .entry-content .wp-block-image .aligncenter img {
+ margin: 0 auto;
+ }
+}
+
+@media only screen and (min-width: 1168px) {
+ .entry .entry-content .wp-block-image .aligncenter {
+ width: calc(6 * (100vw / 12) - 28px);
+ }
+ .entry .entry-content .wp-block-image .aligncenter img {
+ margin: 0 auto;
+ }
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-image.alignfull img {
</span><span class="cx" style="display: block; padding: 0 10px"> width: 100vw;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ max-width: calc( 100% + (2 * 1rem));
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> @media only screen and (min-width: 768px) {
</span><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-image.alignfull img {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ max-width: calc( 125% + 150px);
</ins><span class="cx" style="display: block; padding: 0 10px"> margin-right: auto;
</span><span class="cx" style="display: block; padding: 0 10px"> margin-left: auto;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentynineteenstylecss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentynineteen/style.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentynineteen/style.css 2018-12-28 20:14:26 UTC (rev 44370)
+++ trunk/src/wp-content/themes/twentynineteen/style.css 2018-12-28 21:21:48 UTC (rev 44371)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3956,20 +3956,53 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.entry .entry-content .wp-block-image {
+ max-width: 100%;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-image img {
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.entry .entry-content .wp-block-image.alignleft, .entry .entry-content .wp-block-image.alignright {
- max-width: 100%;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+@media only screen and (min-width: 768px) {
+ .entry .entry-content .wp-block-image .aligncenter {
+ max-width: calc(8 * (100vw / 12) - 28px);
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+@media only screen and (min-width: 1168px) {
+ .entry .entry-content .wp-block-image .aligncenter {
+ max-width: calc(6 * (100vw / 12) - 28px);
+ }
+}
+
+@media only screen and (min-width: 768px) {
+ .entry .entry-content .wp-block-image .aligncenter {
+ margin: 0;
+ width: calc(8 * (100vw / 12) - 28px);
+ }
+ .entry .entry-content .wp-block-image .aligncenter img {
+ margin: 0 auto;
+ }
+}
+
+@media only screen and (min-width: 1168px) {
+ .entry .entry-content .wp-block-image .aligncenter {
+ width: calc(6 * (100vw / 12) - 28px);
+ }
+ .entry .entry-content .wp-block-image .aligncenter img {
+ margin: 0 auto;
+ }
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-image.alignfull img {
</span><span class="cx" style="display: block; padding: 0 10px"> width: 100vw;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ max-width: calc( 100% + (2 * 1rem));
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> @media only screen and (min-width: 768px) {
</span><span class="cx" style="display: block; padding: 0 10px"> .entry .entry-content .wp-block-image.alignfull img {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ max-width: calc( 125% + 150px);
</ins><span class="cx" style="display: block; padding: 0 10px"> margin-left: auto;
</span><span class="cx" style="display: block; padding: 0 10px"> margin-right: auto;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>