<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44314] Script Loader: Pass the suffix to package style handles to ensure correct file names for minified RTL stylesheets.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44314">44314</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44314","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>desrosj</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-12-18 23:24:07 +0000 (Tue, 18 Dec 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Script Loader: Pass the suffix to package style handles to ensure correct file names for minified RTL stylesheets.
Props ocean90.
Merges <a href="https://core.trac.wordpress.org/changeset/44231">[44231]</a> into trunk.
See <a href="https://core.trac.wordpress.org/ticket/45547">#45547</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesscriptloaderphp">trunk/src/wp-includes/script-loader.php</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#trunk">trunk/</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx" style="display: block; padding: 0 10px">Index: trunk
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- trunk 2018-12-18 23:14:26 UTC (rev 44313)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ trunk 2018-12-18 23:24:07 UTC (rev 44314)
</ins><a id="trunk"></a>
<div class="propset"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Property changes: trunk</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: svn:mergeinfo</h4></div>
<span class="cx" style="display: block; padding: 0 10px"> /branches/3.3:20543
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/3.4:21757
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/4.9:43557,43622
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/branches/5.0:43681-43682,43684-43688,43719-43720,43723,43726-43727,43729-43731,43734-43744,43747,43751-43754,43758,43760-43765,43767-43770,43772,43774-43781,43783,43790-43806,43808-43821,43825,43828,43830-43834,43836-43843,43846-43863,43867-43889,43891-43894,43897-43905,43908-43909,43911-43929,43931-43942,43946-43947,43949-43956,43959-43964,43967-43969,43988,43994,44014,44017,44047,44183,44185,44187-44206,44208-44213,44235
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/branches/5.0:43681-43682,43684-43688,43719-43720,43723,43726-43727,43729-43731,43734-43744,43747,43751-43754,43758,43760-43765,43767-43770,43772,43774-43781,43783,43790-43806,43808-43821,43825,43828,43830-43834,43836-43843,43846-43863,43867-43889,43891-43894,43897-43905,43908-43909,43911-43929,43931-43942,43946-43947,43949-43956,43959-43964,43967-43969,43988,43994,44014,44017,44047,44183,44185,44187-44206,44208-44213,44231,44235
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunksrcwpincludesscriptloaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/script-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/script-loader.php 2018-12-18 23:14:26 UTC (rev 44313)
+++ trunk/src/wp-includes/script-loader.php 2018-12-18 23:24:07 UTC (rev 44314)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1921,51 +1921,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'colors-fresh', false, array( 'wp-admin', 'buttons' ) ); // Old handle.
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'open-sans', $open_sans_font_url ); // No longer used in core as of 4.6
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // RTL CSS
- $rtl_styles = array(
- // wp-admin
- 'common',
- 'forms',
- 'admin-menu',
- 'dashboard',
- 'list-tables',
- 'edit',
- 'revisions',
- 'media',
- 'themes',
- 'about',
- 'nav-menus',
- 'widgets',
- 'site-icon',
- 'l10n',
- 'install',
- 'wp-color-picker',
- 'customize-controls',
- 'customize-widgets',
- 'customize-nav-menus',
- 'customize-preview',
- 'ie',
- 'login',
- // wp-includes
- 'buttons',
- 'admin-bar',
- 'wp-auth-check',
- 'editor-buttons',
- 'media-views',
- 'wp-pointer',
- 'wp-jquery-ui-dialog',
- // deprecated
- 'deprecated-media',
- 'farbtastic',
- );
-
- foreach ( $rtl_styles as $rtl_style ) {
- $styles->add_data( $rtl_style, 'rtl', 'replace' );
- if ( $suffix ) {
- $styles->add_data( $rtl_style, 'suffix', $suffix );
- }
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> // Packages styles
</span><span class="cx" style="display: block; padding: 0 10px"> $fonts_url = '';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1981,7 +1936,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'wp-editor-font', $fonts_url );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add( 'wp-block-library-theme', "/wp-includes/css/dist/block-library/theme$suffix.css" );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $styles->add_data( 'wp-block-library-theme', 'rtl', 'replace' );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add(
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-edit-blocks',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1994,7 +1948,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-block-library-theme',
</span><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $styles->add_data( 'wp-edit-blocks', 'rtl', 'replace' );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $package_styles = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'block-library' => array(),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2011,8 +1964,62 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $path = "/wp-includes/css/dist/$package/style$suffix.css";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $styles->add( $handle, $path, $dependencies );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $styles->add_data( $handle, 'rtl', 'replace' );
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ // RTL CSS
+ $rtl_styles = array(
+ // Admin CSS
+ 'common',
+ 'forms',
+ 'admin-menu',
+ 'dashboard',
+ 'list-tables',
+ 'edit',
+ 'revisions',
+ 'media',
+ 'themes',
+ 'about',
+ 'nav-menus',
+ 'widgets',
+ 'site-icon',
+ 'l10n',
+ 'install',
+ 'wp-color-picker',
+ 'customize-controls',
+ 'customize-widgets',
+ 'customize-nav-menus',
+ 'customize-preview',
+ 'ie',
+ 'login',
+ // Includes CSS
+ 'buttons',
+ 'admin-bar',
+ 'wp-auth-check',
+ 'editor-buttons',
+ 'media-views',
+ 'wp-pointer',
+ 'wp-jquery-ui-dialog',
+ // Package styles
+ 'wp-block-library-theme',
+ 'wp-edit-blocks',
+ 'wp-block-library',
+ 'wp-components',
+ 'wp-edit-post',
+ 'wp-editor',
+ 'wp-format-library',
+ 'wp-list-reusable-blocks',
+ 'wp-nux',
+ // Deprecated CSS
+ 'deprecated-media',
+ 'farbtastic',
+ );
+
+ foreach ( $rtl_styles as $rtl_style ) {
+ $styles->add_data( $rtl_style, 'rtl', 'replace' );
+ if ( $suffix ) {
+ $styles->add_data( $rtl_style, 'suffix', $suffix );
+ }
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre>
</div>
</div>
</body>
</html>