<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[44138] trunk: Themes: Introduce responsive embeds support.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/44138">44138</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/44138","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>jeremyfelt</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-12-14 01:49:46 +0000 (Fri, 14 Dec 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Themes: Introduce responsive embeds support.
Responsive embeds is a way for a theme to opt in to WordPress dynamically scaling the width/height of an embed. When a theme supports responsive embeds, a `wp-embed-responsive` class is added to the `<body>` tag. This information is also presented through the REST API for clients to respect.
Merges <a href="https://core.trac.wordpress.org/changeset/43790">[43790]</a> and <a href="https://core.trac.wordpress.org/changeset/43791">[43791]</a> from the 5.0 branch to trunk.
Props desrosj, danielbachhuber, ocean90.
Fixes <a href="https://core.trac.wordpress.org/ticket/45125">#45125</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesposttemplatephp">trunk/src/wp-includes/post-template.php</a></li>
<li><a href="#trunksrcwpincludesrestapiendpointsclasswprestthemescontrollerphp">trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-themes-controller.php</a></li>
<li><a href="#trunksrcwpincludesthemephp">trunk/src/wp-includes/theme.php</a></li>
<li><a href="#trunktestsphpunittestsrestapirestthemescontrollerphp">trunk/tests/phpunit/tests/rest-api/rest-themes-controller.php</a></li>
<li><a href="#trunktestsphpunitteststhemesupportphp">trunk/tests/phpunit/tests/theme/support.php</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#trunk">trunk/</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx" style="display: block; padding: 0 10px">Index: trunk
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- trunk 2018-12-14 01:45:57 UTC (rev 44137)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ trunk 2018-12-14 01:49:46 UTC (rev 44138)
</ins><a id="trunk"></a>
<div class="propset"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Property changes: trunk</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: svn:mergeinfo</h4></div>
<span class="cx" style="display: block; padding: 0 10px"> /branches/3.3:20543
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/3.4:21757
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/4.9:43557,43622
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/branches/5.0:43681-43682,43684-43688,43719-43720,43723,43726-43727,43729-43731,43734-43744,43751-43754,43758,43761-43765,43767-43770,43772,43774-43781,43783,43793
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/branches/5.0:43681-43682,43684-43688,43719-43720,43723,43726-43727,43729-43731,43734-43744,43751-43754,43758,43761-43765,43767-43770,43772,43774-43781,43783,43790-43791,43793
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunksrcwpincludesposttemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/post-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/post-template.php 2018-12-14 01:45:57 UTC (rev 44137)
+++ trunk/src/wp-includes/post-template.php 2018-12-14 01:49:46 UTC (rev 44138)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -760,6 +760,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $classes[] = 'wp-custom-logo';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( current_theme_supports( 'responsive-embeds' ) ) {
+ $classes[] = 'wp-embed-responsive';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $page = $wp_query->get( 'page' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $page || $page < 2 ) {
</span></span></pre></div>
<a id="trunksrcwpincludesrestapiendpointsclasswprestthemescontrollerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-themes-controller.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-themes-controller.php 2018-12-14 01:45:57 UTC (rev 44137)
+++ trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-themes-controller.php 2018-12-14 01:49:46 UTC (rev 44138)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -111,8 +111,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $formats = array_merge( array( 'standard' ), $formats );
</span><span class="cx" style="display: block; padding: 0 10px"> $data['theme_supports']['formats'] = $formats;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $data['theme_supports']['post-thumbnails'] = false;
- $post_thumbnails = get_theme_support( 'post-thumbnails' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $data['theme_supports']['post-thumbnails'] = false;
+ $data['theme_supports']['responsive-embeds'] = (bool) get_theme_support( 'responsive-embeds' );
+ $post_thumbnails = get_theme_support( 'post-thumbnails' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $post_thumbnails ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // $post_thumbnails can contain a nested array of post types.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -156,16 +157,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'type' => 'array',
</span><span class="cx" style="display: block; padding: 0 10px"> 'readonly' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'properties' => array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'formats' => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'formats' => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'description' => __( 'Post formats supported.' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'type' => 'array',
</span><span class="cx" style="display: block; padding: 0 10px"> 'readonly' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'post-thumbnails' => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'post-thumbnails' => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'description' => __( 'Whether the theme supports post thumbnails.' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'type' => array( 'array', 'bool' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'readonly' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'responsive-embeds' => array(
+ 'description' => __( 'Whether the theme supports responsive embedded content.' ),
+ 'type' => 'bool',
+ 'readonly' => true,
+ ),
</ins><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span></span></pre></div>
<a id="trunksrcwpincludesthemephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/theme.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/theme.php 2018-12-14 01:45:57 UTC (rev 44137)
+++ trunk/src/wp-includes/theme.php 2018-12-14 01:49:46 UTC (rev 44138)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2318,12 +2318,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.1.0 The `title-tag` feature was added
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.5.0 The `customize-selective-refresh-widgets` feature was added
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.7.0 The `starter-content` feature was added
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 5.0.0 The `responsive-embeds` feature was added.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @global array $_wp_theme_features
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $feature The feature being added. Likely core values include 'post-formats',
</span><span class="cx" style="display: block; padding: 0 10px"> * 'post-thumbnails', 'html5', 'custom-logo', 'custom-header-uploads',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 'custom-header', 'custom-background', 'title-tag', 'starter-content', etc.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 'custom-header', 'custom-background', 'title-tag', 'starter-content',
+ * 'responsive-embeds', etc.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @param mixed $args,... Optional extra arguments to pass along with certain features.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return void|bool False on failure, void otherwise.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span></span></pre></div>
<a id="trunktestsphpunittestsrestapirestthemescontrollerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/rest-api/rest-themes-controller.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/rest-api/rest-themes-controller.php 2018-12-14 01:45:57 UTC (rev 44137)
+++ trunk/tests/phpunit/tests/rest-api/rest-themes-controller.php 2018-12-14 01:49:46 UTC (rev 44138)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -189,9 +189,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals( 1, count( $properties ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey( 'theme_supports', $properties );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertEquals( 2, count( $properties['theme_supports']['properties'] ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertEquals( 3, count( $properties['theme_supports']['properties'] ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey( 'formats', $properties['theme_supports']['properties'] );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertArrayHasKey( 'post-thumbnails', $properties['theme_supports']['properties'] );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertArrayHasKey( 'responsive-embeds', $properties['theme_supports']['properties'] );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -223,6 +224,35 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Test when a theme does not support responsive embeds.
+ *
+ * @ticket 45016
+ */
+ public function test_theme_supports_responsive_embeds_false() {
+ remove_theme_support( 'responsive-embeds' );
+ $response = self::perform_active_theme_request();
+
+ $result = $response->get_data();
+ $this->assertTrue( isset( $result[0]['theme_supports'] ) );
+ $this->assertTrue( isset( $result[0]['theme_supports']['responsive-embeds'] ) );
+ $this->assertFalse( $result[0]['theme_supports']['responsive-embeds'] );
+ }
+
+ /**
+ * Test when a theme supports responsive embeds.
+ *
+ * @ticket 45016
+ */
+ public function test_theme_supports_responsive_embeds_true() {
+ remove_theme_support( 'responsive-embeds' );
+ add_theme_support( 'responsive-embeds' );
+ $response = self::perform_active_theme_request();
+ $result = $response->get_data();
+ $this->assertTrue( isset( $result[0]['theme_supports'] ) );
+ $this->assertTrue( $result[0]['theme_supports']['responsive-embeds'] );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Test when a theme does not support post thumbnails.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 45016
</span></span></pre></div>
<a id="trunktestsphpunitteststhemesupportphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/theme/support.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/theme/support.php 2018-12-14 01:45:57 UTC (rev 44137)
+++ trunk/tests/phpunit/tests/theme/support.php 2018-12-14 01:49:46 UTC (rev 44138)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -192,4 +192,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEmpty( get_registered_nav_menus() );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( current_theme_supports( 'menus' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * @ticket 45125
+ */
+ function test_responsive_embeds() {
+ add_theme_support( 'responsive-embeds' );
+ $this->assertTrue( current_theme_supports( 'responsive-embeds' ) );
+ remove_theme_support( 'responsive-embeds' );
+ $this->assertFalse( current_theme_supports( 'responsive-embeds' ) );
+ add_theme_support( 'responsive-embeds' );
+ $this->assertTrue( current_theme_supports( 'responsive-embeds' ) );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>