<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[43833] branches/5.0: Block Editor: Preload `wp/v2/media` with OPTIONS for caps check.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/43833">43833</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/43833","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>danielbachhuber</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-10-29 00:23:11 +0000 (Mon, 29 Oct 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Block Editor: Preload `wp/v2/media` with OPTIONS for caps check.
Also introduces a `block_editor_preload_paths` filter for plugins and themes to preload additional data.
Props imath, mattheu.
Fixes <a href="https://core.trac.wordpress.org/ticket/45194">#45194</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches50srcwpadmineditformblocksphp">branches/5.0/src/wp-admin/edit-form-blocks.php</a></li>
<li><a href="#branches50srcwpincludesrestapiphp">branches/5.0/src/wp-includes/rest-api.php</a></li>
<li><a href="#branches50testsphpunittestsrestapiphp">branches/5.0/tests/phpunit/tests/rest-api.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches50srcwpadmineditformblocksphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.0/src/wp-admin/edit-form-blocks.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.0/src/wp-admin/edit-form-blocks.php 2018-10-26 20:16:22 UTC (rev 43832)
+++ branches/5.0/src/wp-admin/edit-form-blocks.php 2018-10-29 00:23:11 UTC (rev 43833)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -49,8 +49,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> sprintf( '/wp/v2/%s/%s?context=edit', $rest_base, $post->ID ),
</span><span class="cx" style="display: block; padding: 0 10px"> sprintf( '/wp/v2/types/%s?context=edit', $post_type ),
</span><span class="cx" style="display: block; padding: 0 10px"> sprintf( '/wp/v2/users/me?post_type=%s&context=edit', $post_type ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ array( '/wp/v2/media', 'OPTIONS' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/**
+ * Preload common data by specifying an array of REST API paths that will be preloaded.
+ *
+ * Filters the array of paths that will be preloaded.
+ *
+ * @since 5.0.0
+ *
+ * @param array $preload_paths Array of paths to preload.
+ * @param object $post The post resource data.
+ */
+$preload_paths = apply_filters( 'block_editor_preload_paths', $preload_paths, $post );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * Ensure the global $post remains the same after API data is preloaded.
</span><span class="cx" style="display: block; padding: 0 10px"> * Because API preloading can call the_content and other filters, plugins
</span></span></pre></div>
<a id="branches50srcwpincludesrestapiphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.0/src/wp-includes/rest-api.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.0/src/wp-includes/rest-api.php 2018-10-26 20:16:22 UTC (rev 43832)
+++ branches/5.0/src/wp-includes/rest-api.php 2018-10-29 00:23:11 UTC (rev 43833)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1343,12 +1343,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return $memo;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $method = 'GET';
+ if ( is_array( $path ) && 2 === count( $path ) ) {
+ $method = end( $path );
+ $path = reset( $path );
+
+ if ( ! in_array( $method, array( 'GET', 'OPTIONS' ), true ) ) {
+ $method = 'GET';
+ }
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $path_parts = parse_url( $path );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( false === $path_parts ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return $memo;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $request = new WP_REST_Request( 'GET', $path_parts['path'] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $request = new WP_REST_Request( $method, $path_parts['path'] );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $path_parts['query'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> parse_str( $path_parts['query'], $query_params );
</span><span class="cx" style="display: block; padding: 0 10px"> $request->set_query_params( $query_params );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1367,10 +1377,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $data['_links'] = $links;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $memo[ $path ] = array(
- 'body' => $data,
- 'headers' => $response->headers,
- );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( 'OPTIONS' === $method ) {
+ $response = rest_send_allow_header( $response, $server, $request );
+
+ $memo[ $method ][ $path ] = array(
+ 'body' => $data,
+ 'headers' => $response->headers,
+ );
+ } else {
+ $memo[ $path ] = array(
+ 'body' => $data,
+ 'headers' => $response->headers,
+ );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return $memo;
</span></span></pre></div>
<a id="branches50testsphpunittestsrestapiphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/5.0/tests/phpunit/tests/rest-api.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/5.0/tests/phpunit/tests/rest-api.php 2018-10-26 20:16:22 UTC (rev 43832)
+++ branches/5.0/tests/phpunit/tests/rest-api.php 2018-10-29 00:23:11 UTC (rev 43833)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -629,4 +629,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function test_rest_preload_api_request_no_notices_php_52() {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( is_array( rest_preload_api_request( 0, '/' ) ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ function test_rest_preload_api_request_with_method() {
+ $rest_server = $GLOBALS['wp_rest_server'];
+ $GLOBALS['wp_rest_server'] = null;
+
+ $preload_paths = array(
+ '/wp/v2/types',
+ array( '/wp/v2/media', 'OPTIONS' ),
+ );
+
+ $preload_data = array_reduce(
+ $preload_paths,
+ 'rest_preload_api_request',
+ array()
+ );
+
+ $this->assertSame( array_keys( $preload_data ), array( '/wp/v2/types', 'OPTIONS' ) );
+ $this->assertTrue( isset( $preload_data['OPTIONS']['/wp/v2/media'] ) );
+
+ $GLOBALS['wp_rest_server'] = $rest_server;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>