<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[43216] trunk/src/wp-admin: Privacy: fix styling on personal data tables.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/43216">43216</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/43216","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>azaozz</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-05-10 16:01:50 +0000 (Thu, 10 May 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Privacy: fix styling on personal data tables.
Props melchoyce, allendav.
Fixes <a href="https://core.trac.wordpress.org/ticket/43909">#43909</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincssformscss">trunk/src/wp-admin/css/forms.css</a></li>
<li><a href="#trunksrcwpadminjsxfnjs">trunk/src/wp-admin/js/xfn.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincssformscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/forms.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/forms.css 2018-05-10 15:55:51 UTC (rev 43215)
+++ trunk/src/wp-admin/css/forms.css 2018-05-10 16:01:50 UTC (rev 43216)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1115,11 +1115,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> box-shadow: inset 0 -1px 0 rgba(0,0,0,0.1);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.privacy_requests tbody .has-request-results th {
+ box-shadow: none;
+}
+
+.privacy_requests tbody .request-results th .notice {
+ margin: 0 0 5px;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .privacy_requests tbody td {
</span><span class="cx" style="display: block; padding: 0 10px"> background: #fff;
</span><span class="cx" style="display: block; padding: 0 10px"> box-shadow: inset 0 -1px 0 rgba(0,0,0,0.1);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.privacy_requests tbody .has-request-results td {
+ box-shadow: none;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .privacy_requests .status-request-confirmed th,
</span><span class="cx" style="display: block; padding: 0 10px"> .privacy_requests .status-request-confirmed td {
</span><span class="cx" style="display: block; padding: 0 10px"> background-color: #f7fcfe;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1132,18 +1144,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border-left-color: #d64d21;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.privacy_requests .request-results .notice {
- margin: -2px 0 0;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.privacy_requests .export_personal_data_failed a {
+ vertical-align: baseline;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.privacy_requests .request-results .notice p {
- margin: 0.5em 0;
-}
-
-.request-results td {
- padding: 0 0 1px;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .status-label {
</span><span class="cx" style="display: block; padding: 0 10px"> font-weight: 600;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpadminjsxfnjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/xfn.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/xfn.js 2018-05-10 15:55:51 UTC (rev 43215)
+++ trunk/src/wp-admin/js/xfn.js 2018-05-10 16:01:50 UTC (rev 43216)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -31,6 +31,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function clearResultsAfterRow( $requestRow ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $requestRow.removeClass( 'has-request-results' );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $requestRow.next().hasClass( 'request-results' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $requestRow.next().remove();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -37,7 +39,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function appendResultsAfterRow( $requestRow, classes, summaryMessage, additionalMessages ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var itemList = '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var itemList = '',
+ resultRowClasses = 'request-results';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> clearResultsAfterRow( $requestRow );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -48,8 +51,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> itemList = '<ul>' + itemList + '</ul>';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $requestRow.addClass( 'has-request-results' );
+
+ if ( $requestRow.hasClass( 'status-request-confirmed' ) ) {
+ resultRowClasses = resultRowClasses + ' status-request-confirmed';
+ }
+
+ if ( $requestRow.hasClass( 'status-request-failed' ) ) {
+ resultRowClasses = resultRowClasses + ' status-request-failed';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $requestRow.after( function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return '<tr class="request-results"><td colspan="5">' +
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return '<tr class="' + resultRowClasses + '"><th colspan="5">' +
</ins><span class="cx" style="display: block; padding: 0 10px"> '<div class="notice inline notice-alt ' + classes + '">' +
</span><span class="cx" style="display: block; padding: 0 10px"> '<p>' + summaryMessage + '</p>' +
</span><span class="cx" style="display: block; padding: 0 10px"> itemList +
</span></span></pre>
</div>
</div>
</body>
</html>