<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[41932] trunk/src/wp-admin/js/customize-controls.js: Customize: Draw attention to save button after collapsing the publish settings section when the changeset status or date had been changed.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/41932">41932</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/41932","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>westonruter</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-10-18 23:05:02 +0000 (Wed, 18 Oct 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Customize: Draw attention to save button after collapsing the publish settings section when the changeset status or date had been changed.
Props bpayton, westonruter.
See <a href="https://core.trac.wordpress.org/ticket/42114">#42114</a>, <a href="https://core.trac.wordpress.org/ticket/39896">#39896</a>.
Fixes <a href="https://core.trac.wordpress.org/ticket/42211">#42211</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminjscustomizecontrolsjs">trunk/src/wp-admin/js/customize-controls.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminjscustomizecontrolsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/customize-controls.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/customize-controls.js 2017-10-18 22:40:42 UTC (rev 41931)
+++ trunk/src/wp-admin/js/customize-controls.js 2017-10-18 23:05:02 UTC (rev 41932)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6889,7 +6889,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Set up publish settings section and its controls.
</span><span class="cx" style="display: block; padding: 0 10px"> api.section( 'publish_settings', function( section ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var updateButtonsState, trashControl, updateSectionActive, isSectionActive, statusControl, dateControl, toggleDateControl, publishWhenTime, pollInterval, updateTimeArrivedPoller, timeArrivedPollingInterval = 1000;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var updateButtonsState, trashControl, updateSectionActive, isSectionActive, statusControl, dateControl, toggleDateControl, publishWhenTime, pollInterval, updateTimeArrivedPoller, cancelScheduleButtonReminder, timeArrivedPollingInterval = 1000;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> trashControl = new api.Control( 'trash_changeset', {
</span><span class="cx" style="display: block; padding: 0 10px"> type: 'button',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6951,6 +6951,26 @@
</span><span class="cx" style="display: block; padding: 0 10px"> updateButtonsState();
</span><span class="cx" style="display: block; padding: 0 10px"> section.active.bind( updateButtonsState );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function highlightScheduleButton() {
+ if ( ! cancelScheduleButtonReminder ) {
+ cancelScheduleButtonReminder = api.utils.highlightButton( btnWrapper, {
+ delay: 1000,
+
+ // Only abort the reminder when the save button is focused.
+ // If the user clicks the settings button to toggle the
+ // settings closed, we'll still remind them.
+ focusTarget: saveBtn
+ } );
+ }
+ }
+ function cancelHighlightScheduleButton() {
+ if ( cancelScheduleButtonReminder ) {
+ cancelScheduleButtonReminder();
+ cancelScheduleButtonReminder = null;
+ }
+ }
+ api.state( 'selectedChangesetStatus' ).bind( cancelHighlightScheduleButton );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> section.contentContainer.find( '.customize-action' ).text( api.l10n.updating );
</span><span class="cx" style="display: block; padding: 0 10px"> section.contentContainer.find( '.customize-section-back' ).removeAttr( 'tabindex' );
</span><span class="cx" style="display: block; padding: 0 10px"> publishSettingsBtn.prop( 'disabled', false );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6963,6 +6983,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> section.expanded.bind( function( isExpanded ) {
</span><span class="cx" style="display: block; padding: 0 10px"> publishSettingsBtn.attr( 'aria-expanded', String( isExpanded ) );
</span><span class="cx" style="display: block; padding: 0 10px"> publishSettingsBtn.toggleClass( 'active', isExpanded );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ if ( isExpanded ) {
+ cancelHighlightScheduleButton();
+ } else if ( api.state( 'selectedChangesetStatus' ).get() !== api.state( 'changesetStatus' ).get() ) {
+ highlightScheduleButton();
+ } else if ( 'future' === api.state( 'selectedChangesetStatus' ).get() && api.state( 'selectedChangesetDate' ).get() !== api.state( 'changesetDate' ).get() ) {
+ highlightScheduleButton();
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> statusControl = new api.Control( 'changeset_status', {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -7620,8 +7648,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> state.bind( 'change', function() {
</span><span class="cx" style="display: block; padding: 0 10px"> var canSave;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- btnWrapper.removeClass( 'button-see-me' );
-
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! activated() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> saveBtn.val( api.l10n.activate );
</span><span class="cx" style="display: block; padding: 0 10px"> closeBtn.find( '.screen-reader-text' ).text( api.l10n.cancel );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -7645,12 +7671,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( saved() && selectedChangesetStatus() === changesetStatus() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( changesetDate.get() !== selectedChangesetDate.get() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> saveBtn.val( api.l10n.schedule );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- btnWrapper.addClass( 'button-see-me' );
</del><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> saveBtn.val( api.l10n.scheduled );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- btnWrapper.addClass( 'button-see-me' );
</del><span class="cx" style="display: block; padding: 0 10px"> saveBtn.val( api.l10n.schedule );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } else if ( ! api.settings.changeset.currentUserCanPublish ) {
</span></span></pre>
</div>
</div>
</body>
</html>