<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[41867] trunk/src/wp-includes/widgets: Widgets: Move empty title checks out of the `apply_filters( 'widget_title' )` calls for clarity.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/41867">41867</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/41867","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-10-15 21:42:52 +0000 (Sun, 15 Oct 2017)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Widgets: Move empty title checks out of the `apply_filters( 'widget_title' )` calls for clarity.

See <a href="https://core.trac.wordpress.org/ticket/42226">#42226</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludeswidgetsclasswpnavmenuwidgetphp">trunk/src/wp-includes/widgets/class-wp-nav-menu-widget.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgetarchivesphp">trunk/src/wp-includes/widgets/class-wp-widget-archives.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgetcalendarphp">trunk/src/wp-includes/widgets/class-wp-widget-calendar.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgetcategoriesphp">trunk/src/wp-includes/widgets/class-wp-widget-categories.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgetmetaphp">trunk/src/wp-includes/widgets/class-wp-widget-meta.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgetpagesphp">trunk/src/wp-includes/widgets/class-wp-widget-pages.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgetrssphp">trunk/src/wp-includes/widgets/class-wp-widget-rss.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgetsearchphp">trunk/src/wp-includes/widgets/class-wp-widget-search.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgettagcloudphp">trunk/src/wp-includes/widgets/class-wp-widget-tag-cloud.php</a></li>
<li><a href="#trunksrcwpincludeswidgetsclasswpwidgettextphp">trunk/src/wp-includes/widgets/class-wp-widget-text.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludeswidgetsclasswpnavmenuwidgetphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-nav-menu-widget.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-nav-menu-widget.php        2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-nav-menu-widget.php  2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -42,16 +42,20 @@
</span><span class="cx" style="display: block; padding: 0 10px">                // Get menu
</span><span class="cx" style="display: block; padding: 0 10px">                $nav_menu = ! empty( $instance['nav_menu'] ) ? wp_get_nav_menu_object( $instance['nav_menu'] ) : false;
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                if ( !$nav_menu )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         if ( ! $nav_menu ) {
</ins><span class="cx" style="display: block; padding: 0 10px">                         return;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                }
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                $title = ! empty( $instance['title'] ) ? $instance['title'] : '';
+
</ins><span class="cx" style="display: block; padding: 0 10px">                 /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                $instance['title'] = apply_filters( 'widget_title', empty( $instance['title'] ) ? '' : $instance['title'], $instance, $this->id_base );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                echo $args['before_widget'];
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                if ( !empty($instance['title']) )
-                       echo $args['before_title'] . $instance['title'] . $args['after_title'];
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         if ( $title ) {
+                       echo $args['before_title'] . $title . $args['after_title'];
+               }
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                $nav_menu_args = array(
</span><span class="cx" style="display: block; padding: 0 10px">                        'fallback_cb' => '',
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgetarchivesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-archives.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-archives.php        2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-widget-archives.php  2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -40,13 +40,16 @@
</span><span class="cx" style="display: block; padding: 0 10px">         * @param array $instance Settings for the current Archives widget instance.
</span><span class="cx" style="display: block; padding: 0 10px">         */
</span><span class="cx" style="display: block; padding: 0 10px">        public function widget( $args, $instance ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                $title = ! empty( $instance['title'] ) ? $instance['title'] : __( 'Archives' );
+
+               /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
+               $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
+
</ins><span class="cx" style="display: block; padding: 0 10px">                 $c = ! empty( $instance['count'] ) ? '1' : '0';
</span><span class="cx" style="display: block; padding: 0 10px">                $d = ! empty( $instance['dropdown'] ) ? '1' : '0';
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
-               $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? __( 'Archives' ) : $instance['title'], $instance, $this->id_base );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         echo $args['before_widget'];
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                echo $args['before_widget'];
</del><span class="cx" style="display: block; padding: 0 10px">                 if ( $title ) {
</span><span class="cx" style="display: block; padding: 0 10px">                        echo $args['before_title'] . $title . $args['after_title'];
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgetcalendarphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-calendar.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-calendar.php        2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-widget-calendar.php  2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -49,8 +49,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">         * @param array $instance The settings for the particular instance of the widget.
</span><span class="cx" style="display: block; padding: 0 10px">         */
</span><span class="cx" style="display: block; padding: 0 10px">        public function widget( $args, $instance ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                $title = ! empty( $instance['title'] ) ? $instance['title'] : '';
+
</ins><span class="cx" style="display: block; padding: 0 10px">                 /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? '' : $instance['title'], $instance, $this->id_base );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                echo $args['before_widget'];
</span><span class="cx" style="display: block; padding: 0 10px">                if ( $title ) {
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgetcategoriesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-categories.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-categories.php      2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-widget-categories.php        2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -44,14 +44,17 @@
</span><span class="cx" style="display: block; padding: 0 10px">        public function widget( $args, $instance ) {
</span><span class="cx" style="display: block; padding: 0 10px">                static $first_dropdown = true;
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                $title = ! empty( $instance['title'] ) ? $instance['title'] : __( 'Categories' );
+
</ins><span class="cx" style="display: block; padding: 0 10px">                 /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? __( 'Categories' ) : $instance['title'], $instance, $this->id_base );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                $c = ! empty( $instance['count'] ) ? '1' : '0';
</span><span class="cx" style="display: block; padding: 0 10px">                $h = ! empty( $instance['hierarchical'] ) ? '1' : '0';
</span><span class="cx" style="display: block; padding: 0 10px">                $d = ! empty( $instance['dropdown'] ) ? '1' : '0';
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                echo $args['before_widget'];
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px">                 if ( $title ) {
</span><span class="cx" style="display: block; padding: 0 10px">                        echo $args['before_title'] . $title . $args['after_title'];
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgetmetaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-meta.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-meta.php    2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-widget-meta.php      2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -42,10 +42,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">         * @param array $instance Settings for the current Meta widget instance.
</span><span class="cx" style="display: block; padding: 0 10px">         */
</span><span class="cx" style="display: block; padding: 0 10px">        public function widget( $args, $instance ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                $title = ! empty( $instance['title'] ) ? $instance['title'] : __( 'Meta' );
+
</ins><span class="cx" style="display: block; padding: 0 10px">                 /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                $title = apply_filters( 'widget_title', empty($instance['title']) ? __( 'Meta' ) : $instance['title'], $instance, $this->id_base );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                echo $args['before_widget'];
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px">                 if ( $title ) {
</span><span class="cx" style="display: block; padding: 0 10px">                        echo $args['before_title'] . $title . $args['after_title'];
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -75,6 +78,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        ?>
</span><span class="cx" style="display: block; padding: 0 10px">                        </ul>
</span><span class="cx" style="display: block; padding: 0 10px">                        <?php
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px">                 echo $args['after_widget'];
</span><span class="cx" style="display: block; padding: 0 10px">        }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgetpagesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-pages.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-pages.php   2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-widget-pages.php     2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -40,6 +40,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">         * @param array $instance Settings for the current Pages widget instance.
</span><span class="cx" style="display: block; padding: 0 10px">         */
</span><span class="cx" style="display: block; padding: 0 10px">        public function widget( $args, $instance ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                $title = ! empty( $instance['title'] ) ? $instance['title'] : __( 'Pages' );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                /**
</span><span class="cx" style="display: block; padding: 0 10px">                 * Filters the widget title.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -50,7 +51,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                 * @param array  $instance Array of settings for the current widget.
</span><span class="cx" style="display: block; padding: 0 10px">                 * @param mixed  $id_base  The widget ID.
</span><span class="cx" style="display: block; padding: 0 10px">                 */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? __( 'Pages' ) : $instance['title'], $instance, $this->id_base );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                $sortby = empty( $instance['sortby'] ) ? 'menu_order' : $instance['sortby'];
</span><span class="cx" style="display: block; padding: 0 10px">                $exclude = empty( $instance['exclude'] ) ? '' : $instance['exclude'];
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgetrssphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-rss.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-rss.php     2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-widget-rss.php       2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -68,8 +68,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                $link = substr($link, 1);
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                if ( empty($title) )
-                       $title = empty($desc) ? __('Unknown Feed') : $desc;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         if ( empty( $title ) ) {
+                       $title = ! empty( $desc ) ? $desc : __( 'Unknown Feed' );
+               }
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
</span><span class="cx" style="display: block; padding: 0 10px">                $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgetsearchphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-search.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-search.php  2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-widget-search.php    2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -40,8 +40,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">         * @param array $instance Settings for the current Search widget instance.
</span><span class="cx" style="display: block; padding: 0 10px">         */
</span><span class="cx" style="display: block; padding: 0 10px">        public function widget( $args, $instance ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                $title = ! empty( $instance['title'] ) ? $instance['title'] : '';
+
</ins><span class="cx" style="display: block; padding: 0 10px">                 /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? '' : $instance['title'], $instance, $this->id_base );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                echo $args['before_widget'];
</span><span class="cx" style="display: block; padding: 0 10px">                if ( $title ) {
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgettagcloudphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-tag-cloud.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-tag-cloud.php       2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-widget-tag-cloud.php 2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -39,14 +39,15 @@
</span><span class="cx" style="display: block; padding: 0 10px">         * @param array $instance Settings for the current Tag Cloud widget instance.
</span><span class="cx" style="display: block; padding: 0 10px">         */
</span><span class="cx" style="display: block; padding: 0 10px">        public function widget( $args, $instance ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                $current_taxonomy = $this->_get_current_taxonomy($instance);
-               if ( !empty($instance['title']) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         $current_taxonomy = $this->_get_current_taxonomy( $instance );
+
+               if ( ! empty( $instance['title'] ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px">                         $title = $instance['title'];
</span><span class="cx" style="display: block; padding: 0 10px">                } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        if ( 'post_tag' == $current_taxonomy ) {
-                               $title = __('Tags');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 if ( 'post_tag' === $current_taxonomy ) {
+                               $title = __( 'Tags' );
</ins><span class="cx" style="display: block; padding: 0 10px">                         } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                $tax = get_taxonomy($current_taxonomy);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         $tax = get_taxonomy( $current_taxonomy );
</ins><span class="cx" style="display: block; padding: 0 10px">                                 $title = $tax->labels->name;
</span><span class="cx" style="display: block; padding: 0 10px">                        }
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span></span></pre></div>
<a id="trunksrcwpincludeswidgetsclasswpwidgettextphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/widgets/class-wp-widget-text.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/widgets/class-wp-widget-text.php    2017-10-15 21:28:13 UTC (rev 41866)
+++ trunk/src/wp-includes/widgets/class-wp-widget-text.php      2017-10-15 21:42:52 UTC (rev 41867)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -192,8 +192,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">        public function widget( $args, $instance ) {
</span><span class="cx" style="display: block; padding: 0 10px">                global $post;
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                $title = ! empty( $instance['title'] ) ? $instance['title'] : '';
+
</ins><span class="cx" style="display: block; padding: 0 10px">                 /** This filter is documented in wp-includes/widgets/class-wp-widget-pages.php */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? '' : $instance['title'], $instance, $this->id_base );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                $text = ! empty( $instance['text'] ) ? $instance['text'] : '';
</span><span class="cx" style="display: block; padding: 0 10px">                $is_visual_text_widget = ( ! empty( $instance['visual'] ) && ! empty( $instance['filter'] ) );
</span></span></pre>
</div>
</div>

</body>
</html>