<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[41695] trunk/src/wp-admin: Plugins: Add plugin icons to the plugin list tables.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/41695">41695</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/41695","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>pento</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-10-03 00:24:31 +0000 (Tue, 03 Oct 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugins: Add plugin icons to the plugin list tables.
To mirror theme list table behaviour, the plugin icon now appears next to plugins in the plugin list tables. For plugins that don't have an icon, or non-W.org plugins, a fallback dashicon is shown.
Props melchoyce, afercia, paulwilde, pento, obenland.
Fixes <a href="https://core.trac.wordpress.org/ticket/30186">#30186</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsslisttablescss">trunk/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#trunksrcwpadminincludesclasswppluginslisttablephp">trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</a></li>
<li><a href="#trunksrcwpadminupdatecorephp">trunk/src/wp-admin/update-core.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsslisttablescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/list-tables.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/list-tables.css 2017-10-03 00:21:06 UTC (rev 41694)
+++ trunk/src/wp-admin/css/list-tables.css 2017-10-03 00:24:31 UTC (rev 41695)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1286,17 +1286,36 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border-left: 4px solid #00a0d2;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#wpbody-content .plugins .plugin-title,
-#wpbody-content .plugins .theme-title {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.wp-list-table.plugins .plugin-title,
+.wp-list-table.plugins .theme-title {
+ white-space: nowrap;
+}
+
+.wp-list-table.plugins .theme-title {
</ins><span class="cx" style="display: block; padding: 0 10px"> padding-right: 12px;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- white-space:nowrap;
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.updates-table-screenshot {
- float:left;
- padding: 0 10px 5px 0;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.wp-list-table.plugins .plugin-title {
+ padding-right: 86px; /* 64 (icon width) + 10 (icon padding) + 12 (title padding) = 86 */
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.plugins .plugin-title img,
+.plugins .plugin-title .dashicons {
+ float: left;
+ padding: 0 10px 0 0;
+ width: 64px;
+ height: 64px;
+}
+
+.plugins .plugin-title .dashicons:before {
+ font-size: 64px;
+}
+
+#update-themes-table .plugin-title img,
+#update-themes-table .plugin-title .dashicons {
+ width: 85px;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .plugins .inactive .plugin-title strong {
</span><span class="cx" style="display: block; padding: 0 10px"> font-weight: 400;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppluginslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2017-10-03 00:21:06 UTC (rev 41694)
+++ trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2017-10-03 00:24:31 UTC (rev 41695)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -751,9 +751,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> echo "<th scope='row' class='check-column'>$checkbox</th>";
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> case 'name':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "<td class='plugin-title column-primary'><strong>$plugin_name</strong>";
- echo $this->row_actions( $actions, true );
- echo "</td>";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $icon = '<span class="dashicons dashicons-admin-plugins"></span>';
+ if ( ! empty( $plugin_data['icons']['default'] ) ) {
+ $icon = '<img src="' . esc_url( $plugin_data['icons']['default'] ) . '" alt="" />';
+ }
+ ?>
+ <td class="plugin-title column-primary">
+ <?php echo $icon; ?>
+ <strong><?php echo $plugin_name; ?></strong>
+ <?php echo $this->row_actions( $actions, true ); ?>
+ </td>
+ <?php
</ins><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> case 'description':
</span><span class="cx" style="display: block; padding: 0 10px"> $classes = 'column-description desc';
</span></span></pre></div>
<a id="trunksrcwpadminupdatecorephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/update-core.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/update-core.php 2017-10-03 00:21:06 UTC (rev 41694)
+++ trunk/src/wp-admin/update-core.php 2017-10-03 00:24:31 UTC (rev 41695)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -252,6 +252,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( (array) $plugins as $plugin_file => $plugin_data ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $plugin_data = (object) _get_plugin_data_markup_translate( $plugin_file, (array) $plugin_data, false, true );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $icon = '<span class="dashicons dashicons-admin-plugins"></span>';
+ if ( ! empty( $plugin_data->update->icons['default'] ) ) {
+ $icon = '<img src="' . esc_url( $plugin_data->update->icons['default'] ) . '" alt="" />';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Get plugin compat for running version of WordPress.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset($plugin_data->update->tested) && version_compare($plugin_data->update->tested, $cur_wp_version, '>=') ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $compat = '<br />' . sprintf(__('Compatibility with WordPress %1$s: 100%% (according to its author)'), $cur_wp_version);
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -302,6 +307,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?></label>
</span><span class="cx" style="display: block; padding: 0 10px"> </td>
</span><span class="cx" style="display: block; padding: 0 10px"> <td class="plugin-title"><p>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <?php echo $icon; ?>
</ins><span class="cx" style="display: block; padding: 0 10px"> <strong><?php echo $plugin_data->Name; ?></strong>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: 1: plugin version, 2: new version */
</span></span></pre>
</div>
</div>
</body>
</html>