<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[40844] trunk/tests/phpunit/tests/media/sideload.php: Revert [40842] due to failing tests.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/40844">40844</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/40844","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>jnylen0</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-05-25 18:27:08 +0000 (Thu, 25 May 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Revert <a href="https://core.trac.wordpress.org/changeset/40842">[40842]</a> due to failing tests.
See <a href="https://core.trac.wordpress.org/ticket/19629">#19629</a>.</pre>
<h3>Removed Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsmediasideloadphp">trunk/tests/phpunit/tests/media/sideload.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsmediasideloadphp"></a>
<div class="delfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Deleted: trunk/tests/phpunit/tests/media/sideload.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/media/sideload.php 2017-05-25 18:01:16 UTC (rev 40843)
+++ trunk/tests/phpunit/tests/media/sideload.php 2017-05-25 18:27:08 UTC (rev 40844)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,106 +0,0 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php
-
-/**
- * @group media
- * @group sideload
- */
-class Tests_Media_Sideload extends WP_UnitTestCase {
- private $attachment_id = 0;
-
- public function setUp() {
- parent::setUp();
-
- add_filter( 'pre_http_request', array( $this, 'mock_sideload_request' ), 10, 3 );
- add_filter( 'wp_update_attachment_metadata', array( $this, 'get_attachment_metadata' ), 10, 2 );
- }
-
- public function tearDown() {
- parent::tearDown();
-
- remove_filter( 'pre_http_request', array( $this, 'mock_sideload_request' ), 10, 3 );
- remove_filter( 'wp_update_attachment_metadata', array( $this, 'get_attachment_metadata' ), 10, 2 );
- }
-
- /**
- * Catch the attachment ID as attachment meta is updated so that it
- * can be used to check against `media_sideload_image` output.
- *
- * @param array $data Attachment metadata.
- * @param int $id Attachment ID.
- * @return array Attachment metadata.
- */
- public function get_attachment_metadata( $data, $id ) {
- $this->attachment_id = $id;
- return $data;
- }
-
- /**
- * Intercept image sideload requests and mock responses.
- *
- * @param mixed $preempt Whether to preempt an HTTP request's return value. Default false.
- * @param mixed $r HTTP request arguments.
- * @param string $url The request URL.
- * @return array Response data.
- */
- public function mock_sideload_request( $preempt, $r, $url ) {
- // If `$url` is set to false, continue the request to
- // simulate failure using an improper URL.
- if ( false == $url ) {
- return $preempt;
- }
-
- // Copy the existing file to the expected temporary location to
- // simulate a successful upload.
- copy( DIR_TESTDATA . '/images/test-image.jpg', $r['filename'] );
- return array(
- 'response' => array(
- 'code' => 200,
- ),
- );
- }
-
- /**
- * Tests basic functionality and error handling of `media_sideload_image()`.
- *
- * @ticket 19629
- */
- function test_wp_media_sideload_image() {
- $source = 'https://example.com/test-image.jpg';
- $alt = 'alt text';
-
- // Test default return value, which should return the same as html.
- $result = media_sideload_image( $source, 0, $alt );
- $dest = wp_get_attachment_url( $this->attachment_id );
-
- $expected = "<img src='$dest' alt='$alt' />";
- $this->assertEquals( $expected, $result );
- wp_delete_file( get_attached_file( $this->attachment_id ) );
-
- // Test 'html' return value
- $result = media_sideload_image( $source, 0, $alt, 'html' );
- $dest = wp_get_attachment_url( $this->attachment_id );
-
- $expected = "<img src='$dest' alt='$alt' />";
- $this->assertEquals( $expected, $result );
- wp_delete_file( get_attached_file( $this->attachment_id ) );
-
- // Test 'id' return value
- $result = media_sideload_image( $source, 0, $alt, 'id' );
- $this->assertEquals( $this->attachment_id, $result);
- wp_delete_file( get_attached_file( $this->attachment_id ) );
-
- // Test 'src' return value
- $result = media_sideload_image( $source, 0, $alt, 'src' );
- $expected = wp_get_attachment_url( $this->attachment_id );
- $this->assertEquals( $expected, $result);
- wp_delete_file( get_attached_file( $this->attachment_id ) );
-
- // Test WP_Error on invalid URL.
- $result = media_sideload_image( false, 0, $alt, 'id' );
- $this->assertInstanceOf( 'WP_Error', $result);
-
- // Test WP_Error if file can't be sanitized to image.
- $result = media_sideload_image( 'invalid-image.html', 0, $alt, 'id' );
- $this->assertInstanceOf( 'WP_Error', $result);
- }
-}
</del></span></pre>
</div>
</div>
</body>
</html>