<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[39237] trunk/src: Customize: Only show video header controls if previewing front page; show explanatory notice when controls are hidden.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/39237">39237</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/39237","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>westonruter</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-11-15 03:46:14 +0000 (Tue, 15 Nov 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Customize: Only show video header controls if previewing front page; show explanatory notice when controls are hidden.
Also include todo for the `header_video` control's `button_labels`. See <a href="https://core.trac.wordpress.org/ticket/38796">#38796</a>.
Props westonruter, joemcgill, celloexpressions.
Fixes <a href="https://core.trac.wordpress.org/ticket/38778">#38778</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminjscustomizecontrolsjs">trunk/src/wp-admin/js/customize-controls.js</a></li>
<li><a href="#trunksrcwpincludesclasswpcustomizemanagerphp">trunk/src/wp-includes/class-wp-customize-manager.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminjscustomizecontrolsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/customize-controls.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/customize-controls.js 2016-11-15 03:36:13 UTC (rev 39236)
+++ trunk/src/wp-admin/js/customize-controls.js 2016-11-15 03:46:14 UTC (rev 39237)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5284,6 +5284,26 @@
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Toggle visibility of Header Video notice when active state change.
+ api.control( 'header_video', function( headerVideoControl ) {
+ headerVideoControl.deferred.embedded.done( function() {
+ var toggleNotice = function() {
+ var section = api.section( headerVideoControl.section() ), notice;
+ if ( ! section ) {
+ return;
+ }
+ notice = section.container.find( '.header-video-not-currently-previewable:first' );
+ if ( headerVideoControl.active.get() ) {
+ notice.stop().slideUp( 'fast' );
+ } else {
+ notice.stop().slideDown( 'fast' );
+ }
+ };
+ toggleNotice();
+ headerVideoControl.active.bind( toggleNotice );
+ } );
+ } );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Update the setting validities.
</span><span class="cx" style="display: block; padding: 0 10px"> api.previewer.bind( 'selective-refresh-setting-validities', function handleSelectiveRefreshedSettingValidities( settingValidities ) {
</span><span class="cx" style="display: block; padding: 0 10px"> api._handleSettingValidities( {
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpcustomizemanagerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-customize-manager.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-customize-manager.php 2016-11-15 03:36:13 UTC (rev 39236)
+++ trunk/src/wp-includes/class-wp-customize-manager.php 2016-11-15 03:46:14 UTC (rev 39237)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3407,7 +3407,12 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( current_theme_supports( 'custom-header', 'video' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $title = __( 'Header Media' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $description = __( 'If you add a video, the image will be used as a fallback while the video loads.' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $description = '<p>' . __( 'If you add a video, the image will be used as a fallback while the video loads.' ) . '</p>';
+
+ // @todo Customizer sections should support having notifications just like controls do. See <https://core.trac.wordpress.org/ticket/38794>.
+ $description .= '<div class="customize-control-notifications-container header-video-not-currently-previewable" style="display: none"><ul>';
+ $description .= '<li class="notice notice-info">' . __( 'This theme doesn\'t support video headers on this page. Navigate to the front page or another page that supports video headers.' ) . '</li>';
+ $description .= '</ul></div>';
</ins><span class="cx" style="display: block; padding: 0 10px"> $width = absint( get_theme_support( 'custom-header', 'width' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $height = absint( get_theme_support( 'custom-header', 'height' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $width && $height ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3478,13 +3483,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => $control_description,
</span><span class="cx" style="display: block; padding: 0 10px"> 'section' => 'header_image',
</span><span class="cx" style="display: block; padding: 0 10px"> 'mime_type' => 'video',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // @todo These button_labels can be removed once WP_Customize_Media_Control provides mime_type-specific labels automatically. See <https://core.trac.wordpress.org/ticket/38796>.
</ins><span class="cx" style="display: block; padding: 0 10px"> 'button_labels' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'select' => __( 'Select Video' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'change' => __( 'Change Video' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'placeholder' => __( 'No video selected' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'frame_title' => __( 'Select Video' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'frame_button' => __( 'Choose Video' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ ),
+ 'active_callback' => 'is_front_page',
</ins><span class="cx" style="display: block; padding: 0 10px"> ) ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->add_control( 'external_header_video', array(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3492,6 +3499,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'type' => 'url',
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => __( 'Or, enter a YouTube URL:' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'section' => 'header_image',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'active_callback'=> 'is_front_page',
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->add_control( new WP_Customize_Header_Image_Control( $this ) );
</span></span></pre>
</div>
</div>
</body>
</html>