<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[39035] trunk/tests/phpunit/tests/user/capabilities.php: Role/Capability: Introduce capability tests for promoting, removing, and deleting users, and capability tests for editing comments.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/39035">39035</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/39035","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>johnbillion</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-10-30 18:30:03 +0000 (Sun, 30 Oct 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Role/Capability: Introduce capability tests for promoting, removing, and deleting users, and capability tests for editing comments.
Also introduces a shared fixture for a super admin user.
See <a href="https://core.trac.wordpress.org/ticket/38236">#38236</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsusercapabilitiesphp">trunk/tests/phpunit/tests/user/capabilities.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsusercapabilitiesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/user/capabilities.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/user/capabilities.php 2016-10-30 18:27:28 UTC (rev 39034)
+++ trunk/tests/phpunit/tests/user/capabilities.php 2016-10-30 18:30:03 UTC (rev 39035)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -8,7 +8,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_User_Capabilities extends WP_UnitTestCase {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- protected static $users = array();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ protected static $users = array(
+ 'administrator' => null,
+ 'editor' => null,
+ 'author' => null,
+ 'contributor' => null,
+ 'subscriber' => null,
+ );
+ protected static $super_admin = null;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> public static function wpSetUpBeforeClass( $factory ) {
</span><span class="cx" style="display: block; padding: 0 10px"> self::$users = array(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,6 +25,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'contributor' => $factory->user->create_and_get( array( 'role' => 'contributor' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'subscriber' => $factory->user->create_and_get( array( 'role' => 'subscriber' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self::$super_admin = $factory->user->create_and_get( array( 'role' => 'contributor' ) );
+ grant_super_admin( self::$super_admin->ID );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function setUp() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -521,16 +530,83 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @dataProvider data_user_with_role_can_edit_own_post
+ *
+ * @param string $role User role name
+ * @param bool $can_edit_own_post Can users with this role edit their own posts?
+ */
+ public function test_user_can_edit_comment_on_own_post( $role, $can_edit_own_post ) {
+ $owner = self::$users[ $role ];
+ $post = self::factory()->post->create_and_get( array(
+ 'post_author' => $owner->ID,
+ ) );
+ $comment = self::factory()->comment->create_and_get( array(
+ 'comment_post_ID' => $post->ID,
+ ) );
+
+ $owner_can_edit = user_can( $owner->ID, 'edit_comment', $comment->comment_ID );
+ $this->assertSame( $can_edit_own_post, $owner_can_edit );
+ }
+
+ /**
+ * @dataProvider data_user_with_role_can_edit_others_posts
+ *
+ * @param string $role User role name
+ * @param bool $can_edit_others_post Can users with this role edit others' posts?
+ */
+ public function test_user_can_edit_comment_on_others_post( $role, $can_edit_others_post ) {
+ $user = self::$users[ $role ];
+ $owner = self::factory()->user->create_and_get( array(
+ 'role' => 'editor',
+ ) );
+ $post = self::factory()->post->create_and_get( array(
+ 'post_author' => $owner->ID,
+ ) );
+ $comment = self::factory()->comment->create_and_get( array(
+ 'comment_post_ID' => $post->ID,
+ ) );
+
+ $user_can_edit = user_can( $user->ID, 'edit_comment', $comment->comment_ID );
+ $this->assertSame( $can_edit_others_post, $user_can_edit );
+ }
+
+ public function data_user_with_role_can_edit_own_post() {
+ $data = array();
+ $caps = $this->getPrimitiveCapsAndRoles();
+
+ foreach ( self::$users as $role => $null ) {
+ $data[] = array(
+ $role,
+ in_array( $role, $caps['edit_published_posts'], true ),
+ );
+ }
+
+ return $data;
+ }
+
+ public function data_user_with_role_can_edit_others_posts() {
+ $data = array();
+ $caps = $this->getPrimitiveCapsAndRoles();
+
+ foreach ( self::$users as $role => $null ) {
+ $data[] = array(
+ $role,
+ in_array( $role, $caps['edit_others_posts'], true ),
+ );
+ }
+
+ return $data;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> function test_super_admin_caps() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! is_multisite() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->markTestSkipped( 'Test only runs in multisite' );
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> $caps = $this->getAllCapsAndRoles();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $user = self::$super_admin;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $user = self::$users['administrator'];
- grant_super_admin( $user->ID );
-
</del><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( is_super_admin( $user->ID ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $caps as $cap => $roles ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1345,6 +1421,59 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function test_only_admins_and_super_admins_can_remove_users() {
+ if ( is_multisite() ) {
+ $this->assertTrue( user_can( self::$super_admin->ID, 'remove_user', self::$users['subscriber']->ID ) );
+ }
+
+ $this->assertTrue( user_can( self::$users['administrator']->ID, 'remove_user', self::$users['subscriber']->ID ) );
+
+ $this->assertFalse( user_can( self::$users['editor']->ID, 'remove_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['author']->ID, 'remove_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['contributor']->ID, 'remove_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['subscriber']->ID, 'remove_user', self::$users['subscriber']->ID ) );
+ }
+
+ public function test_only_super_admins_can_delete_users_on_multisite() {
+ if ( ! is_multisite() ) {
+ $this->markTestSkipped( 'Test only runs on multisite' );
+ }
+
+ $this->assertTrue( user_can( self::$super_admin->ID, 'delete_user', self::$users['subscriber']->ID ) );
+
+ $this->assertFalse( user_can( self::$users['administrator']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['editor']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['author']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['contributor']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['subscriber']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+ }
+
+ public function test_only_admins_can_delete_users_on_single_site() {
+ if ( is_multisite() ) {
+ $this->markTestSkipped( 'Test does not run on multisite' );
+ }
+
+ $this->assertTrue( user_can( self::$users['administrator']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+
+ $this->assertFalse( user_can( self::$users['editor']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['author']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['contributor']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['subscriber']->ID, 'delete_user', self::$users['subscriber']->ID ) );
+ }
+
+ public function test_only_admins_and_super_admins_can_promote_users() {
+ if ( is_multisite() ) {
+ $this->assertTrue( user_can( self::$super_admin->ID, 'promote_user', self::$users['subscriber']->ID ) );
+ }
+
+ $this->assertTrue( user_can( self::$users['administrator']->ID, 'promote_user', self::$users['subscriber']->ID ) );
+
+ $this->assertFalse( user_can( self::$users['editor']->ID, 'promote_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['author']->ID, 'promote_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['contributor']->ID, 'promote_user', self::$users['subscriber']->ID ) );
+ $this->assertFalse( user_can( self::$users['subscriber']->ID, 'promote_user', self::$users['subscriber']->ID ) );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 33694
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1404,15 +1533,12 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $user = self::$users['administrator'];
</span><span class="cx" style="display: block; padding: 0 10px"> $user->add_cap( 'manage_network_users' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $super_admin = self::$users['subscriber'];
- grant_super_admin( $super_admin->ID );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp_set_current_user( $user->ID );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $can_edit_user = current_user_can( 'edit_user', $super_admin->ID );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $can_edit_user = current_user_can( 'edit_user', self::$super_admin->ID );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $user->remove_cap( 'manage_network_users' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- revoke_super_admin( $super_admin->ID );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( $can_edit_user );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>