<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[38972] trunk/src/wp-includes: Customize: Remove unnecessary code for edit shortcuts which is no longer required due to moving buttons inside of partial placement containers.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/38972">38972</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/38972","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>westonruter</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-10-26 22:37:35 +0000 (Wed, 26 Oct 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Customize: Remove unnecessary code for edit shortcuts which is no longer required due to moving buttons inside of partial placement containers.
Props sirbrillig.
Amends <a href="https://core.trac.wordpress.org/changeset/38967">[38967]</a>.
See <a href="https://core.trac.wordpress.org/ticket/27403">#27403</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescsscustomizepreviewcss">trunk/src/wp-includes/css/customize-preview.css</a></li>
<li><a href="#trunksrcwpincludesjscustomizeselectiverefreshjs">trunk/src/wp-includes/js/customize-selective-refresh.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescsscustomizepreviewcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/css/customize-preview.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/css/customize-preview.css 2016-10-26 22:19:08 UTC (rev 38971)
+++ trunk/src/wp-includes/css/customize-preview.css 2016-10-26 22:37:35 UTC (rev 38972)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -92,11 +92,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> visibility: hidden;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.widget button.customize-partial-edit-shortcut-absolute,
-.customize-partial-edit-shortcut-absolute {
- position: static;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .customize-partial-edit-shortcut-left-margin:before {
</span><span class="cx" style="display: block; padding: 0 10px"> left: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludesjscustomizeselectiverefreshjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/customize-selective-refresh.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/customize-selective-refresh.js 2016-10-26 22:19:08 UTC (rev 38971)
+++ trunk/src/wp-includes/js/customize-selective-refresh.js 2016-10-26 22:37:35 UTC (rev 38972)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -141,13 +141,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var partial = this, $placementContainer;
</span><span class="cx" style="display: block; padding: 0 10px"> $placementContainer = $( placement.container );
</span><span class="cx" style="display: block; padding: 0 10px"> $placementContainer.prepend( $editShortcut );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( 'absolute' === $placementContainer.css( 'position' ) ) {
- $editShortcut.addClass( 'customize-partial-edit-shortcut-absolute' );
- $editShortcut.css( partial.getEditShortcutPositionStyles( $placementContainer ) );
- partial.whenPageChanges( function() {
- $editShortcut.css( partial.getEditShortcutPositionStyles( $placementContainer ) );
- } );
- }
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! $placementContainer.is( ':visible' ) || 'none' === $placementContainer.css( 'display' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $editShortcut.addClass( 'customize-partial-edit-shortcut-hidden' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -155,49 +148,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Call a callback function when the page changes.
- *
- * This calls a callback for any change that might require refreshing the edit shortcuts.
- *
- * @since 4.7
- *
- * @param {Function} callback The function to call when the page changes.
- * @returns {void}
- */
- whenPageChanges: function( callback ) {
- var debouncedCallback, $document;
- debouncedCallback = _.debounce( function() {
- // Timeout allows any page animations to finish
- setTimeout( callback, 100 );
- }, 350 );
- // When window is resized.
- $( window ).resize( debouncedCallback );
- // When any customizer setting changes.
- api.bind( 'change', debouncedCallback );
- $document = $( window.document );
- // After scroll in case there are fixed position elements
- $document.on( 'scroll', debouncedCallback );
- // After page click (eg: hamburger menus)
- $document.on( 'click', debouncedCallback );
- },
-
- /**
- * Return the CSS positioning for the edit shortcut for a given partial placement.
- *
- * @since 4.7
- *
- * @param {jQuery} $placementContainer The placement container element as a jQuery object.
- * @return {Object} Object containing CSS positions.
- */
- getEditShortcutPositionStyles: function( $placementContainer ) {
- return {
- top: $placementContainer.css( 'top' ),
- left: $placementContainer.css( 'left' ),
- right: 'auto'
- };
- },
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * Return the unique class name for the edit shortcut button for this partial.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.7
</span></span></pre>
</div>
</div>
</body>
</html>