<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[38852] trunk: Pings: Allow ping functions to accept `WP_Post` objects as well as post IDs.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/38852">38852</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/38852","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>pento</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-10-21 05:59:34 +0000 (Fri, 21 Oct 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Pings: Allow ping functions to accept `WP_Post` objects as well as post IDs.
This removes the use of several `global $wpdb` instances, as well as bringing the ping functions into line with other post-related functions, which will accept a post ID or `WP_Post` object.
Props dshanke.
Fixes <a href="https://core.trac.wordpress.org/ticket/38202">#38202</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescommentphp">trunk/src/wp-includes/comment.php</a></li>
<li><a href="#trunksrcwpincludespostphp">trunk/src/wp-includes/post.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestspostpingsphp">trunk/tests/phpunit/tests/post/pings.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescommentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/comment.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/comment.php 2016-10-21 05:50:54 UTC (rev 38851)
+++ trunk/src/wp-includes/comment.php 2016-10-21 05:59:34 UTC (rev 38852)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2405,19 +2405,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Perform trackbacks.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.5.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 4.7.0 $post_id can be a WP_Post object.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @global wpdb $wpdb WordPress database abstraction object.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param int $post_id Post ID to do trackbacks on.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param int|WP_Post $post_id Post object or ID to do trackbacks on.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function do_trackbacks($post_id) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function do_trackbacks( $post_id ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> global $wpdb;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post = get_post( $post_id );
+ if ( ! $post ) {
+ return false;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post = get_post( $post_id );
- $to_ping = get_to_ping($post_id);
- $pinged = get_pung($post_id);
- if ( empty($to_ping) ) {
- $wpdb->update($wpdb->posts, array('to_ping' => ''), array('ID' => $post_id) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $to_ping = get_to_ping( $post );
+ $pinged = get_pung( $post );
+ if ( empty( $to_ping ) ) {
+ $wpdb->update($wpdb->posts, array( 'to_ping' => '' ), array( 'ID' => $post->ID ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2440,10 +2444,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( (array) $to_ping as $tb_ping ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $tb_ping = trim($tb_ping);
</span><span class="cx" style="display: block; padding: 0 10px"> if ( !in_array($tb_ping, $pinged) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- trackback($tb_ping, $post_title, $excerpt, $post_id);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ trackback( $tb_ping, $post_title, $excerpt, $post->ID );
</ins><span class="cx" style="display: block; padding: 0 10px"> $pinged[] = $tb_ping;
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $wpdb->query( $wpdb->prepare("UPDATE $wpdb->posts SET to_ping = TRIM(REPLACE(to_ping, %s, '')) WHERE ID = %d", $tb_ping, $post_id) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $wpdb->query( $wpdb->prepare( "UPDATE $wpdb->posts SET to_ping = TRIM(REPLACE(to_ping, %s,
+ '')) WHERE ID = %d", $tb_ping, $post->ID ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2474,19 +2479,29 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Pings back the links found in a post.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 0.71
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 4.7.0 $post_id can be a WP_Post object.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $content Post content to check for links.
- * @param int $post_ID Post ID.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string $content Post content to check for links. If empty will retrieve from post.
+ * @param int|WP_Post $post_id Post Object or ID.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function pingback($content, $post_ID) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function pingback( $content, $post_id ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> include_once( ABSPATH . WPINC . '/class-IXR.php' );
</span><span class="cx" style="display: block; padding: 0 10px"> include_once( ABSPATH . WPINC . '/class-wp-http-ixr-client.php' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // original code by Mort (http://mort.mine.nu:8080)
</span><span class="cx" style="display: block; padding: 0 10px"> $post_links = array();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pung = get_pung($post_ID);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post = get_post( $post_id );
+ if ( ! $post ) {
+ return;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $pung = get_pung( $post );
+
+ if ( empty( $content ) ) {
+ $content = $post->post_content;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Step 1
</span><span class="cx" style="display: block; padding: 0 10px"> // Parsing the post, external links (if any) are stored in the $post_links array
</span><span class="cx" style="display: block; padding: 0 10px"> $post_links_temp = wp_extract_urls( $content );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2501,7 +2516,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // We don't wanna ping first and second types, even if they have a valid <link/>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( (array) $post_links_temp as $link_test ) :
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !in_array($link_test, $pung) && (url_to_postid($link_test) != $post_ID) // If we haven't pung it already and it isn't a link to itself
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! in_array( $link_test, $pung ) && ( url_to_postid( $link_test ) != $post->ID ) // If we haven't pung it already and it isn't a link to itself
</ins><span class="cx" style="display: block; padding: 0 10px"> && !is_local_attachment($link_test) ) : // Also, let's never ping local attachments.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $test = @parse_url($link_test) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset($test['query']) )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2522,7 +2537,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array &$pung Whether a link has already been pinged, passed by reference.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $post_ID The post ID.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- do_action_ref_array( 'pre_ping', array( &$post_links, &$pung, $post_ID ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ do_action_ref_array( 'pre_ping', array( &$post_links, &$pung, $post->ID ) );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( (array) $post_links as $pagelinkedto ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $pingback_server_url = discover_pingback_server_uri( $pagelinkedto );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2530,7 +2545,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $pingback_server_url ) {
</span><span class="cx" style="display: block; padding: 0 10px"> @ set_time_limit( 60 );
</span><span class="cx" style="display: block; padding: 0 10px"> // Now, the RPC call
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pagelinkedfrom = get_permalink($post_ID);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $pagelinkedfrom = get_permalink( $post );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // using a timeout of 3 seconds should be enough to cover slow servers
</span><span class="cx" style="display: block; padding: 0 10px"> $client = new WP_HTTP_IXR_Client($pingback_server_url);
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2552,7 +2567,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $client->debug = false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $client->query('pingback.ping', $pagelinkedfrom, $pagelinkedto) || ( isset($client->error->code) && 48 == $client->error->code ) ) // Already registered
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_ping( $post_ID, $pagelinkedto );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_ping( $post, $pagelinkedto );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludespostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/post.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/post.php 2016-10-21 05:50:54 UTC (rev 38851)
+++ trunk/src/wp-includes/post.php 2016-10-21 05:59:34 UTC (rev 38852)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3991,19 +3991,32 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Add a URL to those already pinged.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.5.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 4.7.0 $post_id can be a WP_Post object.
+ * @since 4.7.0 $uri can be an array of URIs.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @global wpdb $wpdb WordPress database abstraction object.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param int $post_id Post ID.
- * @param string $uri Ping URI.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param int|WP_Post $post_id Post object or ID.
+ * @param string|array $uri Ping URI or array of URIs.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return int|false How many rows were updated.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function add_ping( $post_id, $uri ) {
</span><span class="cx" style="display: block; padding: 0 10px"> global $wpdb;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pung = $wpdb->get_var( $wpdb->prepare( "SELECT pinged FROM $wpdb->posts WHERE ID = %d", $post_id ));
- $pung = trim($pung);
- $pung = preg_split('/\s/', $pung);
- $pung[] = $uri;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $post = get_post( $post_id );
+ if ( ! $post ) {
+ return false;
+ }
+
+ $pung = trim( $post->pinged );
+ $pung = preg_split( '/\s/', $pung );
+
+ if ( is_array( $uri ) ) {
+ $pung = array_merge( $pung, $uri );
+ }
+ else {
+ $pung[] = $uri;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> $new = implode("\n", $pung);
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4015,9 +4028,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> $new = apply_filters( 'add_ping', $new );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // expected_slashed ($new).
- $new = wp_unslash($new);
- return $wpdb->update( $wpdb->posts, array( 'pinged' => $new ), array( 'ID' => $post_id ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $return = $wpdb->update( $wpdb->posts, array( 'pinged' => $new ), array( 'ID' => $post->ID ) );
+ clean_post_cache( $post->ID );
+ return $return;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4059,17 +4072,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.5.0
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @global wpdb $wpdb WordPress database abstraction object.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 4.7.0 $post_id can be a WP_Post object.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param int $post_id Post ID.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param int|WP_Post $post_id Post ID or object.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function get_pung( $post_id ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- global $wpdb;
- $pung = $wpdb->get_var( $wpdb->prepare( "SELECT pinged FROM $wpdb->posts WHERE ID = %d", $post_id ));
- $pung = trim($pung);
- $pung = preg_split('/\s/', $pung);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post = get_post( $post_id );
+ if ( ! $post ) {
+ return false;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $pung = trim( $post->pinged );
+ $pung = preg_split( '/\s/', $pung );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Filters the list of already-pinged URLs for the given post.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4084,16 +4100,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Retrieve URLs that need to be pinged.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.5.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 4.7.0 $post_id can be a WP_Post object.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @global wpdb $wpdb WordPress database abstraction object.
- *
- * @param int $post_id Post ID
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param int|WP_Post $post_id Post Object or ID
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function get_to_ping( $post_id ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- global $wpdb;
- $to_ping = $wpdb->get_var( $wpdb->prepare( "SELECT to_ping FROM $wpdb->posts WHERE ID = %d", $post_id ));
- $to_ping = sanitize_trackback_urls( $to_ping );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post = get_post( $post_id );
+
+ if ( ! $post ) {
+ return false;
+ }
+
+ $to_ping = sanitize_trackback_urls( $post->to_ping );
</ins><span class="cx" style="display: block; padding: 0 10px"> $to_ping = preg_split('/\s/', $to_ping, -1, PREG_SPLIT_NO_EMPTY);
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunktestsphpunittestspostpingsphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/post/pings.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/post/pings.php (rev 0)
+++ trunk/tests/phpunit/tests/post/pings.php 2016-10-21 05:59:34 UTC (rev 38852)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,53 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * @group post
+ * @group ping
+ */
+class Tests_Ping_and_Trackback_Sending extends WP_UnitTestCase {
+
+ public function test_returns_to_ping_sites_from_post_id() {
+ $post_id = self::factory()->post->create( array( 'to_ping' => 'http://www.example.com
+ http://www.otherexample.com' ) );
+ $this->assertSame( array( 'http://www.example.com', 'http://www.otherexample.com' ), get_to_ping( $post_id ) );
+ }
+
+ public function test_returns_to_ping_sites_from_post_object() {
+ $post_id = self::factory()->post->create( array( 'to_ping' => 'http://www.example.com
+ http://www.otherexample.com' ) );
+ $post = get_post( $post_id );
+ $this->assertSame( array( 'http://www.example.com', 'http://www.otherexample.com' ), get_to_ping( $post ) );
+ }
+
+ public function test_returns_pinged_sites_from_post_id() {
+ $post_id = self::factory()->post->create( array( 'pinged' => 'foo bar baz' ) );
+ $this->assertSame( array( 'foo', 'bar', 'baz' ), get_pung( $post_id ) );
+ }
+
+ public function test_returns_pinged_sites_from_post_object() {
+ $post_id = self::factory()->post->create( array( 'pinged' => 'foo bar baz' ) );
+ $post = get_post( $post_id );
+ $this->assertSame( array( 'foo', 'bar', 'baz' ), get_pung( $post ) );
+ }
+
+ public function test_add_ping_with_post_id() {
+ $post_id = self::factory()->post->create();
+ add_ping( $post_id, 'foo' );
+ add_ping( $post_id, 'bar' );
+ add_ping( $post_id, 'baz' );
+ $this->assertSame( array( 'foo', 'bar', 'baz' ), get_pung( $post_id ) );
+ }
+
+ public function test_add_ping_array_with_post_id() {
+ $post_id = self::factory()->post->create();
+ add_ping( $post_id, array( 'foo', 'bar', 'baz' ) );
+ $this->assertSame( array( 'foo', 'bar', 'baz' ), get_pung( $post_id ) );
+ }
+
+ public function test_add_ping_with_post_object() {
+ $post_id = self::factory()->post->create();
+ $post = get_post( $post_id );
+ add_ping( $post, 'foo' );
+ $this->assertSame( array( 'foo' ), get_pung( $post_id ) );
+ }
+}
</ins></span></pre>
</div>
</div>
</body>
</html>