<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[38732] trunk/tests/phpunit/tests/user/capabilities.php: Role/capability: Add more complete capability and role assertions to existing user capability tests.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/38732">38732</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/38732","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>johnbillion</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-10-05 17:17:02 +0000 (Wed, 05 Oct 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Role/capability: Add more complete capability and role assertions to existing user capability tests. Also reuses one more user account fixtures.
Fixes <a href="https://core.trac.wordpress.org/ticket/38236">#38236</a>
See <a href="https://core.trac.wordpress.org/ticket/38235">#38235</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsusercapabilitiesphp">trunk/tests/phpunit/tests/user/capabilities.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsusercapabilitiesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/user/capabilities.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/user/capabilities.php 2016-10-05 16:56:32 UTC (rev 38731)
+++ trunk/tests/phpunit/tests/user/capabilities.php 2016-10-05 17:17:02 UTC (rev 38732)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -683,10 +683,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue($user->has_cap('sweep_floor'));
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // shouldn't have any other caps
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertFalse($user->has_cap('upload_files'));
- $this->assertFalse($user->has_cap('edit_published_posts'));
- $this->assertFalse($user->has_cap('upload_files'));
- $this->assertFalse($user->has_cap('level_4'));
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $caps = $this->getAllCapsAndRoles();
+ foreach ( $caps as $cap => $roles ) {
+ if ( 'level_1' !== $cap ) {
+ $this->assertFalse( $user->has_cap( $cap ), "User should not have the {$cap} capability" );
+ }
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // clean up
</span><span class="cx" style="display: block; padding: 0 10px"> remove_role($role_name);
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -757,13 +759,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($user_2->has_cap('publish_posts'));
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // make sure the other caps didn't get messed up
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertTrue($user_1->has_cap('edit_posts'));
- $this->assertTrue($user_1->has_cap('read'));
- $this->assertTrue($user_1->has_cap('level_1'));
- $this->assertTrue($user_1->has_cap('level_0'));
- $this->assertFalse($user_1->has_cap('upload_files'));
- $this->assertFalse($user_1->has_cap('edit_published_posts'));
- $this->assertFalse($user_1->has_cap('level_2'));
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $caps = $this->getAllCapsAndRoles();
+ foreach ( $caps as $cap => $roles ) {
+ if ( in_array( 'contributor', $roles, true ) || 'publish_posts' === $cap ) {
+ $this->assertTrue( $user_1->has_cap( $cap ), "User should have the {$cap} capability" );
+ } else {
+ $this->assertFalse( $user_1->has_cap( $cap ), "User should not have the {$cap} capability" );
+ }
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -847,11 +850,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $user = new WP_User($id);
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue($user->exists(), "Problem getting user $id");
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // capabilities for the author role should be gone
-# $this->assertFalse($user->has_cap('edit_posts'));
-# $this->assertFalse($user->has_cap('edit_published_posts'));
-# $this->assertFalse($user->has_cap('upload_files'));
-# $this->assertFalse($user->has_cap('level_2'));
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // all capabilities for the user should be gone
+ foreach ( $this->getAllCapsAndRoles() as $cap => $roles ) {
+ $this->assertFalse( $user->has_cap( $cap ), "User should not have the {$cap} capability" );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // the extra capabilities should be gone
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($user->has_cap('make_coffee'));
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -959,12 +961,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $editor = self::$users['editor'];
</span><span class="cx" style="display: block; padding: 0 10px"> $contributor = self::$users['contributor'];
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // editor can edit, view, and trash
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // editor can publish, edit, view, and trash
+ $this->assertTrue( $editor->has_cap( 'publish_post', $post ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( $editor->has_cap( 'edit_post', $post ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( $editor->has_cap( 'delete_post', $post ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( $editor->has_cap( 'read_post', $post ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // a contributor cannot (except read a published post)
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse( $contributor->has_cap( 'publish_post', $post ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( $contributor->has_cap( 'edit_post', $post ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( $contributor->has_cap( 'delete_post', $post ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals( $status === 'publish', $contributor->has_cap( 'read_post', $post ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -978,12 +982,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $author = self::$users['author'];
</span><span class="cx" style="display: block; padding: 0 10px"> $editor = self::$users['editor'];
</span><span class="cx" style="display: block; padding: 0 10px"> $contributor = self::$users['contributor'];
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $subscriber = self::$users['subscriber'];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // create_posts isn't a real cap.
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($admin->has_cap('create_posts'));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($author->has_cap('create_posts'));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($editor->has_cap('create_posts'));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($contributor->has_cap('create_posts'));
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse($subscriber->has_cap('create_posts'));
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> register_post_type( 'foobar' );
</span><span class="cx" style="display: block; padding: 0 10px"> $cap = get_post_type_object( 'foobar' )->cap;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -994,6 +1000,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue($author->has_cap( $cap->create_posts ));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue($editor->has_cap( $cap->create_posts ));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue($contributor->has_cap( $cap->create_posts ));
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse($subscriber->has_cap( $cap->create_posts ));
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> _unregister_post_type( 'foobar' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1007,6 +1014,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($author->has_cap( $cap->create_posts ));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($editor->has_cap( $cap->create_posts ));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($contributor->has_cap( $cap->create_posts ));
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse($subscriber->has_cap( $cap->create_posts ));
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Add edit_foobars primitive cap to a user.
</span><span class="cx" style="display: block; padding: 0 10px"> $admin->add_cap( 'edit_foobars', true );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1015,6 +1023,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($author->has_cap( $cap->create_posts ));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($editor->has_cap( $cap->create_posts ));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse($contributor->has_cap( $cap->create_posts ));
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse($subscriber->has_cap( $cap->create_posts ));
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $admin->remove_cap( 'edit_foobars' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1028,6 +1037,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( $author->has_cap( $cap->edit_posts ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( $contributor->has_cap( $cap->edit_posts ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( $contributor->has_cap( $cap->create_posts ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse( $subscriber->has_cap( $cap->create_posts ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function test_page_meta_caps() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1196,10 +1206,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function test_negative_caps() {
</span><span class="cx" style="display: block; padding: 0 10px"> $author = self::$users['author'];
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> $author->add_cap( 'foo', false );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue ( isset( $author->caps['foo'] ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse( user_can( $author->ID, 'foo' ) );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $author->remove_cap( 'foo' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse ( isset( $author->caps['foo'] ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse( user_can( $author->ID, 'foo' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1363,7 +1377,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $user = new WP_User( self::factory()->user->create( array( 'role' => 'administrator' ) ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $user->add_cap( 'manage_network_users' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $other_user = new WP_User( self::factory()->user->create( array( 'role' => 'subscriber' ) ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $other_user = self::$users['subscriber'];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp_set_current_user( $user->ID );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1465,6 +1479,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( current_user_can( $cap ), "Non-logged-in user should not have the {$cap} capability" );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->assertFalse( current_user_can( 'do_not_allow' ), "Non-logged-in user should not have the do_not_allow capability" );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>