<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[38697] trunk/tests/phpunit/tests/user/capabilities.php: Role/Capability: Introduce tests that assert the primitive and meta capability tests test the correct capabilities.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/38697">38697</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/38697","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>johnbillion</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-09-30 22:11:47 +0000 (Fri, 30 Sep 2016)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Role/Capability: Introduce tests that assert the primitive and meta capability tests test the correct capabilities.

Fixes <a href="https://core.trac.wordpress.org/ticket/38191">#38191</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsusercapabilitiesphp">trunk/tests/phpunit/tests/user/capabilities.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsusercapabilitiesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/user/capabilities.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/user/capabilities.php   2016-09-30 22:10:27 UTC (rev 38696)
+++ trunk/tests/phpunit/tests/user/capabilities.php     2016-09-30 22:11:47 UTC (rev 38697)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -307,6 +307,111 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">        }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+        /**
+        * Test the tests. The administrator role has all primitive capabilities, therefore the
+        * primitive capabilitity tests can be tested by checking that the list of tested
+        * capabilities matches those of the administrator role.
+        *
+        * @group capTestTests
+        */
+       public function testPrimitiveCapsTestsAreCorrect() {
+               $actual   = $this->getPrimitiveCapsAndRoles();
+               $admin    = get_role( 'administrator' );
+               $expected = $admin->capabilities;
+
+               unset(
+                       // Role names as capabilities are a special case:
+                       $actual['administrator'],
+                       $actual['editor'],
+                       $actual['author'],
+                       $actual['subscriber'],
+                       $actual['contributor']
+               );
+
+               unset(
+                       // `manage_links` is a special case in the caps tests:
+                       $expected['manage_links'],
+                       // `unfiltered_upload` is a special case in the caps tests:
+                       $expected['unfiltered_upload']
+               );
+
+               $expected = array_keys( $expected );
+               $actual   = array_keys( $actual );
+
+               $missing_primitive_cap_checks = array_diff( $expected, $actual );
+               $this->assertSame( array(), $missing_primitive_cap_checks, 'These primitive capabilities are not tested' );
+
+               $incorrect_primitive_cap_checks = array_diff( $actual, $expected );
+               $this->assertSame( array(), $incorrect_primitive_cap_checks, 'These capabilities are not primitive' );
+       }
+
+       /**
+        * Test the tests. All meta capabilities should have a condition in the `map_meta_cap()`
+        * function that handles the capability.
+        *
+        * @group capTestTests
+        */
+       public function testMetaCapsTestsAreCorrect() {
+               $actual = $this->getMetaCapsAndRoles();
+               $file   = file_get_contents( ABSPATH . WPINC . '/capabilities.php' );
+
+               $matched = preg_match( '/^function map_meta_cap\((.*?)^\}/ms', $file, $function );
+               $this->assertSame( 1, $matched );
+               $this->assertNotEmpty( $function );
+
+               $matched = preg_match_all( '/^[\t]case \'([^\']+)/m', $function[0], $cases );
+               $this->assertNotEmpty( $matched );
+               $this->assertNotEmpty( $cases );
+
+               $expected = array_flip( $cases[1] );
+
+               unset(
+                       // These primitive capabilities have a 'case' in `map_meta_cap()` but aren't meta capabilities:
+                       $expected['unfiltered_upload'],
+                       $expected['unfiltered_html'],
+                       $expected['edit_files'],
+                       $expected['edit_plugins'],
+                       $expected['edit_themes'],
+                       $expected['update_plugins'],
+                       $expected['delete_plugins'],
+                       $expected['install_plugins'],
+                       $expected['update_themes'],
+                       $expected['delete_themes'],
+                       $expected['install_themes'],
+                       $expected['update_core'],
+                       $expected['activate_plugins'],
+                       $expected['edit_users'],
+                       $expected['delete_users'],
+                       $expected['create_users'],
+                       $expected['manage_links'],
+                       // Singular object meta capabilities (where an object ID is passed) are not tested:
+                       $expected['remove_user'],
+                       $expected['promote_user'],
+                       $expected['edit_user'],
+                       $expected['delete_post'],
+                       $expected['delete_page'],
+                       $expected['edit_post'],
+                       $expected['edit_page'],
+                       $expected['read_post'],
+                       $expected['read_page'],
+                       $expected['publish_post'],
+                       $expected['edit_post_meta'],
+                       $expected['delete_post_meta'],
+                       $expected['add_post_meta'],
+                       $expected['edit_comment'],
+                       $expected['delete_user']
+               );
+
+               $expected = array_keys( $expected );
+               $actual   = array_keys( $actual );
+
+               $missing_meta_cap_checks = array_diff( $expected, $actual );
+               $this->assertSame( array(), $missing_meta_cap_checks, 'These meta capabilities are not tested' );
+
+               $incorrect_meta_cap_checks = array_diff( $actual, $expected );
+               $this->assertSame( array(), $incorrect_meta_cap_checks, 'These capabilities are not meta' );
+       }
+
</ins><span class="cx" style="display: block; padding: 0 10px">         // test the default roles and caps
</span><span class="cx" style="display: block; padding: 0 10px">        function test_all_roles_and_caps() {
</span><span class="cx" style="display: block; padding: 0 10px">                $caps = $this->getAllCapsAndRoles();
</span></span></pre>
</div>
</div>

</body>
</html>