<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[38634] trunk: Toolbar: Add a 'View Posts' link to the toolbar when on the post listing screen.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/38634">38634</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/38634","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>swissspidy</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-09-20 20:01:55 +0000 (Tue, 20 Sep 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Toolbar: Add a 'View Posts' link to the toolbar when on the post listing screen.
This adds a new link to visit the post type archive if the post type supports it. Also introduces a new `view_items` label to `get_post_type_labels()`.
Props paulwilde, akibjorklund, swissspidy.
Fixes <a href="https://core.trac.wordpress.org/ticket/34113">#34113</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesadminbarphp">trunk/src/wp-includes/admin-bar.php</a></li>
<li><a href="#trunksrcwpincludespostphp">trunk/src/wp-includes/post.php</a></li>
<li><a href="#trunktestsphpunittestsadminbarphp">trunk/tests/phpunit/tests/adminbar.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesadminbarphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/admin-bar.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/admin-bar.php 2016-09-20 19:54:26 UTC (rev 38633)
+++ trunk/src/wp-includes/admin-bar.php 2016-09-20 20:01:55 UTC (rev 38634)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -577,6 +577,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'href' => get_permalink( $post->ID )
</span><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } elseif ( 'edit' == $current_screen->base
+ && ( $post_type_object = get_post_type_object( $current_screen->post_type ) )
+ && ( $post_type_object->public )
+ && ( $post_type_object->show_in_admin_bar )
+ && ( get_post_type_archive_link( $post_type_object->name ) ) )
+ {
+ $wp_admin_bar->add_node( array(
+ 'id' => 'archive',
+ 'title' => $post_type_object->labels->view_items,
+ 'href' => get_post_type_archive_link( $current_screen->post_type )
+ ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> } elseif ( 'term' == $current_screen->base
</span><span class="cx" style="display: block; padding: 0 10px"> && isset( $tag ) && is_object( $tag ) && ! is_wp_error( $tag )
</span><span class="cx" style="display: block; padding: 0 10px"> && ( $tax = get_taxonomy( $tag->taxonomy ) )
</span></span></pre></div>
<a id="trunksrcwpincludespostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/post.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/post.php 2016-09-20 19:54:26 UTC (rev 38633)
+++ trunk/src/wp-includes/post.php 2016-09-20 20:01:55 UTC (rev 38634)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1234,6 +1234,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * - `edit_item` - Label for editing a singular item. Default is 'Edit Post' / 'Edit Page'.
</span><span class="cx" style="display: block; padding: 0 10px"> * - `new_item` - Label for the new item page title. Default is 'New Post' / 'New Page'.
</span><span class="cx" style="display: block; padding: 0 10px"> * - `view_item` - Label for viewing a singular item. Default is 'View Post' / 'View Page'.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * - `view_items` - Label for viewing post type archives. Default is 'View Posts' / 'View Pages'.
</ins><span class="cx" style="display: block; padding: 0 10px"> * - `search_items` - Label for searching plural items. Default is 'Search Posts' / 'Search Pages'.
</span><span class="cx" style="display: block; padding: 0 10px"> * - `not_found` - Label used when no items are found. Default is 'No posts found' / 'No pages found'.
</span><span class="cx" style="display: block; padding: 0 10px"> * - `not_found_in_trash` - Label used when no items are in the trash. Default is 'No posts found in Trash' /
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1267,6 +1268,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.4.0 Added the `insert_into_item`, `uploaded_to_this_item`, `filter_items_list`,
</span><span class="cx" style="display: block; padding: 0 10px"> * `items_list_navigation`, and `items_list` labels.
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.6.0 Converted the `$post_type` parameter to accept a WP_Post_Type object.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 4.7.0 Added the `view_items` label.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @access private
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1282,6 +1284,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'edit_item' => array( __('Edit Post'), __('Edit Page') ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'new_item' => array( __('New Post'), __('New Page') ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'view_item' => array( __('View Post'), __('View Page') ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'view_items' => array( __('View Posts'), __('View Pages') ),
</ins><span class="cx" style="display: block; padding: 0 10px"> 'search_items' => array( __('Search Posts'), __('Search Pages') ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'not_found' => array( __('No posts found.'), __('No pages found.') ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'not_found_in_trash' => array( __('No posts found in Trash.'), __('No pages found in Trash.') ),
</span></span></pre></div>
<a id="trunktestsphpunittestsadminbarphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/adminbar.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/adminbar.php 2016-09-20 19:54:26 UTC (rev 38633)
+++ trunk/tests/phpunit/tests/adminbar.php 2016-09-20 20:01:55 UTC (rev 38634)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -380,4 +380,31 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertNull( $node_edit );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 34113
+ */
+ public function test_admin_bar_contains_view_archive_link() {
+ set_current_screen( 'edit-post' );
+
+ $wp_admin_bar = $this->get_standard_admin_bar();
+ $node = $wp_admin_bar->get_node( 'archive' );
+
+ set_current_screen( 'front' );
+
+ $this->assertNotNull( $node );
+ }
+
+ /**
+ * @ticket 34113
+ */
+ public function test_admin_bar_has_no_archives_link_for_post_types_without_archive() {
+ set_current_screen( 'edit-page' );
+
+ $wp_admin_bar = $this->get_standard_admin_bar();
+ $node = $wp_admin_bar->get_node( 'archive' );
+
+ set_current_screen( 'front' );
+
+ $this->assertNull( $node );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>