<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[38454] trunk: OEmbed: add unit tests.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/38454">38454</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/38454","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>wonderboymusic</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-08-30 18:54:53 +0000 (Tue, 30 Aug 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>OEmbed: add unit tests. `@group external-oembed` is not run by default.
Props johnbillion, wonderboymusic.
See <a href="https://core.trac.wordpress.org/ticket/32360">#32360</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkGruntfilejs">trunk/Gruntfile.js</a></li>
<li><a href="#trunkphpunitxmldist">trunk/phpunit.xml.dist</a></li>
<li><a href="#trunktestsphpunitincludesbootstrapphp">trunk/tests/phpunit/includes/bootstrap.php</a></li>
<li><a href="#trunktestsphpunitmultisitexml">trunk/tests/phpunit/multisite.xml</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsoembedphp">trunk/tests/phpunit/tests/oembed.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkGruntfilejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/Gruntfile.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/Gruntfile.js 2016-08-30 18:30:51 UTC (rev 38453)
+++ trunk/Gruntfile.js 2016-08-30 18:54:53 UTC (rev 38454)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -438,6 +438,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> cmd: 'phpunit',
</span><span class="cx" style="display: block; padding: 0 10px"> args: ['-c', 'phpunit.xml.dist', '--group', 'external-http']
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ //,
+ //'external-oembed': {
+ // cmd: 'phpunit',
+ // args: ['-c', 'phpunit.xml.dist', '--group', 'external-oembed']
+ //}
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> uglify: {
</span><span class="cx" style="display: block; padding: 0 10px"> options: {
</span></span></pre></div>
<a id="trunkphpunitxmldist"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/phpunit.xml.dist</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/phpunit.xml.dist 2016-08-30 18:30:51 UTC (rev 38453)
+++ trunk/phpunit.xml.dist 2016-08-30 18:54:53 UTC (rev 38454)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -24,6 +24,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <group>ajax</group>
</span><span class="cx" style="display: block; padding: 0 10px"> <group>ms-files</group>
</span><span class="cx" style="display: block; padding: 0 10px"> <group>external-http</group>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <group>external-oembed</group>
</ins><span class="cx" style="display: block; padding: 0 10px"> </exclude>
</span><span class="cx" style="display: block; padding: 0 10px"> </groups>
</span><span class="cx" style="display: block; padding: 0 10px"> <logging>
</span></span></pre></div>
<a id="trunktestsphpunitincludesbootstrapphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/includes/bootstrap.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/includes/bootstrap.php 2016-08-30 18:30:51 UTC (rev 38453)
+++ trunk/tests/phpunit/includes/bootstrap.php 2016-08-30 18:54:53 UTC (rev 38454)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -133,6 +133,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'ajax' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'ms-files' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'external-http' => true,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'external-oembed' => true,
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $options as $option ) {
</span></span></pre></div>
<a id="trunktestsphpunitmultisitexml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/multisite.xml</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/multisite.xml 2016-08-30 18:30:51 UTC (rev 38453)
+++ trunk/tests/phpunit/multisite.xml 2016-08-30 18:54:53 UTC (rev 38454)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -25,6 +25,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <group>ajax</group>
</span><span class="cx" style="display: block; padding: 0 10px"> <group>ms-files</group>
</span><span class="cx" style="display: block; padding: 0 10px"> <group>external-http</group>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <group>external-oembed</group>
</ins><span class="cx" style="display: block; padding: 0 10px"> <group>oembed-headers</group>
</span><span class="cx" style="display: block; padding: 0 10px"> </exclude>
</span><span class="cx" style="display: block; padding: 0 10px"> </groups>
</span></span></pre></div>
<a id="trunktestsphpunittestsoembedphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/oembed.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/oembed.php (rev 0)
+++ trunk/tests/phpunit/tests/oembed.php 2016-08-30 18:54:53 UTC (rev 38454)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,870 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+class Tests_oEmbed extends WP_UnitTestCase {
+ protected static $oembed;
+ protected static $provider_map = array(
+ 'youtube' => '#https?://((m|www)\.)?youtube\.com/watch.*#i',
+ 'youtube-playlist' => '#https?://((m|www)\.)?youtube\.com/playlist.*#i',
+ 'youtube-shorturl' => '#https?://youtu\.be/.*#i',
+ 'vimeo' => '#https?://(.+\.)?vimeo\.com/.*#i',
+ 'dailymotion' => '#https?://(www\.)?dailymotion\.com/.*#i',
+ 'dailymotion-shorturl' => '#https?://dai.ly/.*#i',
+ 'flickr' => '#https?://(www\.)?flickr\.com/.*#i',
+ 'flickr-shorturl' => '#https?://flic\.kr/.*#i',
+ 'smugmug' => '#https?://(.+\.)?smugmug\.com/.*#i',
+ 'hulu' => '#https?://(www\.)?hulu\.com/watch/.*#i',
+ 'photobucket-album' => 'http://i*.photobucket.com/albums/*',
+ 'photobucket-group' => 'http://gi*.photobucket.com/groups/*',
+ 'scribd' => '#https?://(www\.)?scribd\.com/doc/.*#i',
+ 'wordpress-tv' => '#https?://wordpress.tv/.*#i',
+ 'polldaddy' => '#https?://(.+\.)?polldaddy\.com/.*#i',
+ 'polldaddy-shorturl' => '#https?://poll\.fm/.*#i',
+ 'funnyordie' => '#https?://(www\.)?funnyordie\.com/videos/.*#i',
+ 'twitter' => '#https?://(www\.)?twitter\.com/.+?/status(es)?/.*#i',
+ 'twitter-timeline' => '#https?://(www\.)?twitter\.com/.+?/timelines/.*#i',
+ 'twitter-moment' => '#https?://(www\.)?twitter\.com/i/moments/.*#i',
+ 'vine' => '#https?://vine.co/v/.*#i',
+ 'soundcloud' => '#https?://(www\.)?soundcloud\.com/.*#i',
+ 'slideshare' => '#https?://(.+?\.)?slideshare\.net/.*#i',
+ 'instagram' => '#https?://(www\.)?instagr(\.am|am\.com)/p/.*#i',
+ 'spotify' => '#https?://(open|play)\.spotify\.com/.*#i',
+ 'imgur' => '#https?://(.+\.)?imgur\.com/.*#i',
+ 'meetup' => '#https?://(www\.)?meetu(\.ps|p\.com)/.*#i',
+ 'issuu' => '#https?://(www\.)?issuu\.com/.+/docs/.+#i',
+ 'collegehumor' => '#https?://(www\.)?collegehumor\.com/video/.*#i',
+ 'mixcloud' => '#https?://(www\.)?mixcloud\.com/.*#i',
+ 'ted' => '#https?://(www\.|embed\.)?ted\.com/talks/.*#i',
+ 'animoto' => '#https?://(www\.)?(animoto|video214)\.com/play/.*#i',
+ 'tumblr' => '#https?://(.+)\.tumblr\.com/post/.*#i',
+ 'kickstarter' => '#https?://(www\.)?kickstarter\.com/projects/.*#i',
+ 'kickstarter-shorturl' => '#https?://kck\.st/.*#i',
+ 'cloudup' => '#https?://cloudup\.com/.*#i',
+ 'reverbnation' => '#https?://(www\.)?reverbnation\.com/.*#i',
+ 'videopress' => '#https?://videopress.com/v/.*#',
+ 'reddit-comments' => '#https?://(www\.)?reddit\.com/r/[^/]+/comments/.*#i',
+ 'speakerdeck' => '#https?://(www\.)?speakerdeck\.com/.*#i',
+ 'facebook-post' => '#https?://www\.facebook\.com/.*/posts/.*#i',
+ 'facebook-photo' => '#https?://www\.facebook\.com/photo(s/|\.php).*#i',
+ 'facebook-permalink' => '#https?://www\.facebook\.com/permalink\.php.*#i',
+ 'facebook-media' => '#https?://www\.facebook\.com/media/.*#i',
+ 'facebook-notes' => '#https?://www\.facebook\.com/notes/.*#i',
+ 'facebook-video' => '#https?://www\.facebook\.com/.*/videos/.*#i',
+ 'facebook-videophp' => '#https?://www\.facebook\.com/video\.php.*#i',
+ // I can't find URLs in this format
+ //'facebook-activity' => '#https?://www\.facebook\.com/.*/activity/.*#i',
+ // Questions has been RIP since 2012, URLs (if you can find them) should still work
+ //'facebook-questions' => '#https?://www\.facebook\.com/questions/.*#i',
+ );
+
+ /**
+ * An HTTP API response.
+ *
+ * @var array
+ */
+ protected $http_response = array();
+
+ public static function wpSetUpBeforeClass() {
+ self::$oembed = _wp_oembed_get_object();
+ }
+
+ /**
+ * Test the tests
+ *
+ * @group external-oembed
+ * @ticket 28507
+ * @ticket 32360
+ *
+ * @dataProvider oEmbedProviderData
+ */
+ public function testOembedTestURLsResolve( $match, array $urls, $supports_https ) {
+
+ if ( empty( $urls ) ) {
+ $this->markTestIncomplete();
+ }
+
+ foreach ( $urls as $url ) {
+
+ $msg = sprintf( 'Test URL: %s', $url );
+
+ $r = wp_remote_head( $url, array(
+ 'redirection' => 3,
+ ) );
+
+ if ( is_wp_error( $r ) ) {
+ $this->fail( sprintf( "%s (%s)\n%s", $r->get_error_message(), $r->get_error_code(), $msg ) );
+ }
+
+ $this->assertSame( 200, wp_remote_retrieve_response_code( $r ), $msg );
+
+ }
+
+ }
+
+ /**
+ * Test the response from each oEmbed provider
+ *
+ * @group external-oembed
+ * @ticket 32360
+ *
+ * @dataProvider oEmbedProviderData
+ */
+ public function testOembedProviderReturnsExpectedResponse( $match, array $urls, $supports_https ) {
+
+ if ( empty( $urls ) ) {
+ $this->markTestIncomplete();
+ }
+
+ $this->setup_http_hooks();
+
+ $args = array(
+ 'width' => 500,
+ 'height' => 500,
+ );
+ $test_urls = $urls;
+
+ if ( $supports_https ) {
+ foreach ( $urls as $url ) {
+ $test_urls[] = set_url_scheme( $url, 'https' );
+ }
+ }
+
+ foreach ( $test_urls as $url ) {
+
+ $msg = sprintf( "- Test URL: %s", $url );
+
+ $provider = self::$oembed->get_provider( $url, array(
+ 'discover' => false,
+ ) );
+ $this->assertNotFalse( $provider, $msg );
+
+ $data = self::$oembed->fetch( $provider, $url, $args );
+
+ $r = $this->http_response;
+
+ $msg .= sprintf( "\n- oEmbed URL: %s", $r['url'] );
+
+ $scheme = parse_url( $r['url'], PHP_URL_SCHEME );
+ $query = parse_url( $r['url'], PHP_URL_QUERY );
+ parse_str( $query, $query_vars );
+
+ // Test request
+ $this->assertInternalType( 'array', $query_vars, $msg );
+ $this->assertArrayHasKey( 'maxheight', $query_vars, $msg );
+ $this->assertArrayHasKey( 'maxwidth', $query_vars, $msg );
+ $this->assertArrayHasKey( 'url', $query_vars, $msg );
+ $this->assertArrayHasKey( 'format', $query_vars, $msg );
+ $this->assertTrue( in_array( $query_vars['format'], array( 'json', 'xml' ), true ), $msg );
+ $this->assertEquals( $args['width'], $query_vars['maxwidth'], $msg );
+ $this->assertEquals( $args['height'], $query_vars['maxheight'], $msg );
+
+ // `WP_oEmbed::fetch()` only returns boolean false, so we need to hook into the HTTP API to get its error
+ if ( is_wp_error( $r['response'] ) ) {
+ $error_message = $r['response']->get_error_message();
+ if ( empty( $error_message ) ) {
+ $error_message = '- no message -';
+ }
+
+ $this->fail( sprintf( "%s (%s)\n%s", $error_message, $r['response']->get_error_code(), $msg ) );
+ }
+
+ $this->assertSame( 200, wp_remote_retrieve_response_code( $r['response'] ), $msg );
+
+ // Test response
+ $this->assertNotFalse( $data, $msg );
+
+ // Check for required response parameters
+ $this->assertObjectHasAttribute( 'type', $data, $msg );
+ $this->assertObjectHasAttribute( 'version', $data, $msg );
+ $this->assertEquals( '1.0', $data->version, $msg );
+
+ switch ( $data->type ) {
+
+ case 'photo':
+
+ // Check for required response parameters
+ $this->assertObjectHasAttribute( 'url', $data, $msg );
+ $this->assertObjectHasAttribute( 'width', $data, $msg );
+ $this->assertObjectHasAttribute( 'height', $data, $msg );
+
+ // Validate response parameters
+ $this->assertNotEmpty( $data->url, $msg );
+ $this->assertInternalType( 'string', $data->url, $msg );
+
+ // Validate response URL scheme
+ if ( 'https' === $scheme ) {
+ $response_scheme = parse_url( $data->url, PHP_URL_SCHEME );
+ if ( ! in_array( $response_scheme, array( null, 'https' ), true ) ) {
+ $this->fail( sprintf( "Invalid scheme in response URL: %s\n%s", $data->url, $msg ) );
+ }
+ }
+
+ break;
+
+ case 'video':
+
+ // Check for required response parameters
+ $this->assertObjectHasAttribute( 'html', $data, $msg );
+ $this->assertObjectHasAttribute( 'width', $data, $msg );
+ $this->assertObjectHasAttribute( 'height', $data, $msg );
+
+ // Validate response parameters
+ $this->assertNotEmpty( $data->html, $msg );
+ $this->assertInternalType( 'string', $data->html, $msg );
+
+ break;
+
+ case 'rich':
+
+ // Check for required response parameters
+ $this->assertObjectHasAttribute( 'html', $data, $msg );
+ $this->assertObjectHasAttribute( 'width', $data, $msg );
+ $this->assertObjectHasAttribute( 'height', $data, $msg );
+
+ // Validate response parameters
+ $this->assertNotEmpty( $data->html, $msg );
+ $this->assertInternalType( 'string', $data->html, $msg );
+
+ // Validate response URL schemes
+ if ( 'https' === $scheme ) {
+
+ if ( preg_match_all( '#src="([^"]+)"#', $data->html, $matches ) ) {
+ foreach ( $matches[1] as $src ) {
+ $src_scheme = parse_url( $src, PHP_URL_SCHEME );
+ if ( ! in_array( $src_scheme, array( null, 'https' ), true ) ) {
+ $this->fail( sprintf( "Invalid src scheme in response: %s\n%s", $src, $msg ) );
+ }
+ }
+ }
+
+ }
+
+ break;
+
+ case 'link':
+
+ // Check for required response parameters
+ $this->assertObjectHasAttribute( 'title', $data, $msg );
+
+ // Validate response parameters
+ $this->assertNotEmpty( $data->title, $msg );
+ $this->assertInternalType( 'string', $data->title, $msg );
+
+ break;
+
+ default:
+
+ $this->fail( sprintf( "Invalid value for the 'type' response parameter\n%s", $msg ) );
+
+ break;
+
+ }
+
+ if ( ! empty( $data->width ) ) {
+
+ // Validate response parameter
+ $this->assertTrue( is_numeric( $data->width ), $msg );
+ $this->assertLessThanOrEqual( intval( $query_vars['maxwidth'] ), $data->width, $msg );
+
+ }
+
+ if ( ! empty( $data->height ) ) {
+
+ // Validate response parameter
+ $this->assertTrue( is_numeric( $data->height ), $msg );
+ $this->assertLessThanOrEqual( intval( $query_vars['maxheight'] ), $data->height, $msg );
+
+ }
+
+ if ( ! empty( $data->thumbnail_url ) ) {
+
+ // Check for required response parameters
+ $this->assertObjectHasAttribute( 'thumbnail_width', $data, $msg );
+ $this->assertObjectHasAttribute( 'thumbnail_height', $data, $msg );
+
+ }
+
+ if ( ! empty( $data->thumbnail_width ) ) {
+
+ // Check for required response parameters
+ $this->assertObjectHasAttribute( 'thumbnail_url', $data, $msg );
+
+ // Validate response parameter
+ $this->assertTrue( is_numeric( $data->thumbnail_width ), $msg );
+ $this->assertLessThanOrEqual( intval( $query_vars['maxwidth'] ), $data->thumbnail_width, $msg );
+
+ }
+
+ if ( ! empty( $data->thumbnail_height ) ) {
+
+ // Check for required response parameters
+ $this->assertObjectHasAttribute( 'thumbnail_url', $data, $msg );
+
+ // Validate response parameter
+ $this->assertTrue( is_numeric( $data->thumbnail_height ), $msg );
+ $this->assertLessThanOrEqual( intval( $query_vars['maxheight'] ), $data->thumbnail_height, $msg );
+
+ }
+
+ }
+
+ $this->teardown_http_hooks();
+
+ }
+
+ /**
+ * Test the response from each oEmbed provider when provided with invalid data
+ *
+ * @group external-oembed
+ * @ticket 32360
+ *
+ * @dataProvider oEmbedProviderData
+ */
+ public function testOembedProviderHandlesInvalidData( $match, array $urls, $supports_https ) {
+
+ if ( empty( $urls ) ) {
+ $this->markTestIncomplete();
+ }
+
+ $this->setup_http_hooks();
+ add_filter( 'oembed_fetch_url', array( $this, 'filter_oembed_fetch_url' ), 99, 3 );
+
+ $invalid = '500" onmouseover="alert(document.cookie)';
+
+ $args = array(
+ 'width' => $invalid,
+ 'height' => $invalid,
+ );
+
+ // Only need to test with one URL for each provider
+ $url = $urls[0];
+
+ $msg = sprintf( "- Test URL: %s", $url );
+
+ $provider = self::$oembed->get_provider( $url, array(
+ 'discover' => false,
+ ) );
+ $this->assertNotFalse( $provider, $msg );
+ $data = self::$oembed->fetch( $provider, $url, $args );
+
+ $r = $this->http_response;
+
+ $msg .= sprintf( "\n- oEmbed URL: %s", $r['url'] );
+
+ $query = parse_url( $r['url'], PHP_URL_QUERY );
+ parse_str( $query, $query_vars );
+
+ // Test request
+ $this->assertInternalType( 'array', $query_vars, $msg );
+ $this->assertArrayHasKey( 'maxheight', $query_vars, $msg );
+ $this->assertArrayHasKey( 'maxwidth', $query_vars, $msg );
+ $this->assertEquals( $args['width'], $query_vars['maxwidth'], $msg );
+ $this->assertEquals( $args['height'], $query_vars['maxheight'], $msg );
+
+ // `WP_oEmbed::fetch()` only returns boolean false, so we need to hook into the HTTP API to get its error
+ if ( is_wp_error( $r['response'] ) ) {
+ $error_message = $r['response']->get_error_message();
+ if ( empty( $error_message ) ) {
+ $error_message = '- no message -';
+ }
+
+ $this->fail( sprintf( "%s (%s)\n%s", $error_message, $r['response']->get_error_code(), $msg ) );
+ }
+
+ $this->assertTrue( in_array( wp_remote_retrieve_response_code( $r['response'] ), array(
+ 200,
+ 400,
+ 404,
+ ), true ), $msg );
+
+ if ( false === $data ) {
+ // For an erroneous request, it's valid to return no data (or no JSON/XML, which evaluates to false) and
+ // therefore the rest of the assertions can be skipped
+ return;
+ }
+
+ // Check invalid data isn't echoed
+ $this->assertNotContains( 'onmouseover', wp_remote_retrieve_body( $r['response'] ), $msg );
+
+ if ( isset( $data->width ) ) {
+ $this->assertTrue( is_numeric( $data->width ), $msg );
+ }
+
+ if ( isset( $data->height ) ) {
+ $this->assertTrue( is_numeric( $data->height ), $msg );
+ }
+
+ if ( isset( $data->thumbnail_width ) ) {
+ $this->assertTrue( is_numeric( $data->thumbnail_width ), $msg );
+ }
+
+ if ( isset( $data->thumbnail_height ) ) {
+ $this->assertTrue( is_numeric( $data->thumbnail_height ), $msg );
+ }
+
+ remove_filter( 'oembed_fetch_url', array( $this, 'filter_oembed_fetch_url' ), 99 );
+ $this->teardown_http_hooks();
+
+ }
+
+ /**
+ * Test the tests
+ *
+ * @group oembed
+ * @ticket 32360
+ */
+ public function testOembedTestsCoverAllProviders() {
+
+ $tests = wp_list_pluck( $this->oEmbedProviderData(), 0 );
+ $providers = array_values( self::$provider_map );
+ $missing = array_diff( $providers, $tests );
+
+ $this->assertEmpty( $missing, sprintf( "These oEmbed providers are not tested:\n- %s", implode( "\n- ", $missing ) ) );
+
+ }
+
+ /**
+ * Test the tests
+ *
+ * @group oembed
+ * @ticket 32360
+ *
+ */
+ public function testOembedTestsAreAllUseful() {
+
+ $tests = wp_list_pluck( $this->oEmbedProviderData(), 0 );
+ $providers = array_keys( self::$oembed->providers );
+ $useless = array_diff( $tests, $providers );
+
+ $this->assertEmpty( $useless, sprintf( "These tests do not cover any oEmbed provider:\n- %s", implode( "\n- ", $useless ) ) );
+
+ }
+
+ /**
+ * Data provider for our oEmbed tests
+ *
+ * @return array
+ */
+ public function oEmbedProviderData() {
+ $providers = self::$provider_map;
+
+ return array(
+ // YouTube without www
+ array(
+ $providers['youtube'],
+ array(
+ 'http://youtube.com/watch?v=zdtD19tXX30',
+ 'http://m.youtube.com/watch?v=QkP_rOCBrpY',
+ ),
+ false, // HTTPS handled by different endpoints
+ ),
+ // YouTube with www
+ array(
+ $providers['youtube'],
+ array(
+ 'https://www.youtube.com/watch?v=bDRQRdFaFEo',
+ 'https://m.youtube.com/watch?v=yfUflij74P4',
+ ),
+ false, // HTTPS handled by different endpoints
+ ),
+ // YouTube Playlist without www
+ array(
+ $providers['youtube-playlist'],
+ array(
+ 'https://youtube.com/playlist?list=PL93B9F6B77FBB0160',
+ 'https://m.youtube.com/playlist?list=PL1AC02C68F976A10F',
+ ),
+ false, // HTTPS handled by different endpoints
+ ),
+ // YouTube Playlist with www
+ array(
+ $providers['youtube-playlist'],
+ array(
+ 'http://www.youtube.com/playlist?list=PLC7D2959C96B8D27B',
+ 'http://m.youtube.com/playlist?list=PLEC422D53B7588DC7',
+ ),
+ false, // HTTPS handled by different endpoints
+ ),
+ // YouTube HTTP Short Url
+ array(
+ $providers['youtube-shorturl'],
+ array(
+ 'http://youtu.be/nfWlot6h_JM?list=PLirAqAtl_h2r5g8xGajEwdXd3x1sZh8hC',
+ ),
+ false, // HTTPS handled by different endpoints
+ ),
+ // YouTube HTTPS Short Url
+ array(
+ $providers['youtube-shorturl'],
+ array(
+ 'https://youtu.be/U8SYRUYfs_I',
+ ),
+ false, // HTTPS handled by different endpoints
+ ),
+ array(
+ $providers['vimeo'],
+ array(
+ 'http://vimeo.com/12339198',
+ ),
+ true,
+ ),
+ array(
+ $providers['dailymotion'],
+ array(
+ 'http://www.dailymotion.com/video/x27bwvb_how-to-wake-up-better_news',
+ ),
+ true,
+ ),
+ array(
+ $providers['dailymotion-shorturl'],
+ array(
+ 'http://dai.ly/x33exze',
+ ),
+ false, // No HTTPS support
+ ),
+ array(
+ $providers['flickr'],
+ array(
+ 'http://www.flickr.com/photos/bon/14004280667/',
+ ),
+ true,
+ ),
+ array(
+ $providers['flickr-shorturl'],
+ array(
+ 'http://flic.kr/p/6BFrbQ',
+ ),
+ true,
+ ),
+ array(
+ $providers['smugmug'],
+ array(
+ 'http://fotoeffects.smugmug.com/Daily-shots-for-the-dailies/Dailies/6928550_9gMRmv/476011624_WhGWpts#!i=476011624&k=WhGWpts',
+ ),
+ true,
+ ),
+ array(
+ $providers['hulu'],
+ array(
+ 'http://www.hulu.com/watch/807443',
+ ),
+ true,
+ ),
+ array(
+ $providers['photobucket-album'],
+ array(
+ 'http://i415.photobucket.com/albums/pp236/Keefers_/Keffers%20Animals/funny-cats-a10.jpg',
+ ),
+ false, // No HTTPS support
+ ),
+ array(
+ $providers['photobucket-group'],
+ array(
+ // ??
+ ),
+ false, // No HTTPS support
+ ),
+ array(
+ $providers['scribd'],
+ array(
+ 'http://www.scribd.com/doc/110799637/Synthesis-of-Knowledge-Effects-of-Fire-and-Thinning-Treatments-on-Understory-Vegetation-in-Dry-U-S-Forests',
+ ),
+ true,
+ ),
+ array(
+ $providers['wordpress-tv'],
+ array(
+ 'http://wordpress.tv/2015/08/18/billie/',
+ ),
+ true,
+ ),
+ array(
+ $providers['polldaddy'],
+ array(
+ 'http://polldaddy.com/poll/9066794/',
+ ),
+ true,
+ ),
+ array(
+ $providers['polldaddy-shorturl'],
+ array(
+ 'http://poll.fm/5ebze',
+ ),
+ false, // No HTTPS support
+ ),
+ array(
+ $providers['funnyordie'],
+ array(
+ 'http://www.funnyordie.com/videos/e5ef40bf2a/cute-overload',
+ ),
+ true,
+ ),
+ array(
+ $providers['twitter'],
+ array(
+ 'http://twitter.com/WordPress/status/633718182335922177',
+ ),
+ true,
+ ),
+ array(
+ $providers['twitter-timeline'],
+ array(
+ 'https://twitter.com/wordpress',
+ ),
+ true,
+ ),
+ array(
+ $providers['twitter-moment'],
+ array(
+ 'https://twitter.com/i/moments/770661957397573633',
+ ),
+ true,
+ ),
+ array(
+ $providers['reddit-comments'],
+ array(
+ 'https://www.reddit.com/r/Wordpress/comments/3xerq8/list_of_useful_wordpress_functions/'
+ ),
+ true,
+ ),
+ array(
+ $providers['vine'],
+ array(
+ 'http://vine.co/v/OjiLun5LuQ6',
+ ),
+ true,
+ ),
+ array(
+ $providers['soundcloud'],
+ array(
+ 'http://soundcloud.com/steveaoki/kid-cudi-pursuit-of-happiness',
+ ),
+ true,
+ ),
+ array(
+ $providers['slideshare'],
+ array(
+ 'http://www.slideshare.net/haraldf/business-quotes-for-2011',
+ ),
+ true,
+ ),
+ array(
+ $providers['instagram'],
+ array(
+ 'http://instagram.com/p/68WqXbTcfl/',
+ 'https://instagram.com/p/68WqXbTcfl/',
+ 'http://instagr.am/p/MRM3HQy6kh/',
+ ),
+ false, // No HTTPS support on instagr.am
+ ),
+ array(
+ $providers['spotify'],
+ array(
+ 'http://open.spotify.com/track/2i1KmyEXN3pNLwdxAWSGcg',
+ ),
+ true,
+ ),
+ array(
+ $providers['imgur'],
+ array(
+ 'http://imgur.com/a/WdJim',
+ 'http://i.imgur.com/mbOPX2L.png',
+ ),
+ true,
+ ),
+ array(
+ $providers['meetup'],
+ array(
+ 'http://www.meetup.com/WordPress-Amsterdam/events/224346396/',
+ 'http://meetu.ps/2L533w',
+ ),
+ true,
+ ),
+ array(
+ $providers['issuu'],
+ array(
+ 'http://issuu.com/vmagazine/docs/v87',
+ ),
+ true,
+ ),
+ array(
+ $providers['collegehumor'],
+ array(
+ 'http://www.collegehumor.com/video/2862877/jake-and-amir-math',
+ ),
+ true,
+ ),
+ array(
+ $providers['mixcloud'],
+ array(
+ 'http://www.mixcloud.com/8_8s/disclosurefriends/',
+ ),
+ true,
+ ),
+ array(
+ $providers['ted'],
+ array(
+ 'http://www.ted.com/talks/rodney_mullen_pop_an_ollie_and_innovate',
+ ),
+ true,
+ ),
+ array(
+ $providers['animoto'],
+ array(
+ 'http://animoto.com/play/MlRRgXHhoT8gOZyHanM6TA',
+ 'http://video214.com/play/MlRRgXHhoT8gOZyHanM6TA',
+ ),
+ true,
+ ),
+ array(
+ $providers['tumblr'],
+ array(
+ 'http://yahoo.tumblr.com/post/50902111638/tumblr-yahoo',
+ ),
+ false, // No HTTPS support
+ ),
+ array(
+ $providers['kickstarter'],
+ array(
+ 'http://www.kickstarter.com/projects/zackdangerbrown/potato-salad',
+ ),
+ true,
+ ),
+ array(
+ $providers['kickstarter-shorturl'],
+ array(
+ 'http://kck.st/1ukxHcx',
+ ),
+ false, // No HTTPS support
+ ),
+ array(
+ $providers['cloudup'],
+ array(
+ 'http://cloudup.com/cWX2Bi5DmfJ',
+ ),
+ true,
+ ),
+ array(
+ $providers['reverbnation'],
+ array(
+ 'http://www.reverbnation.com/enemyplanes/song/16729753-we-want-blood',
+ 'http://www.reverbnation.com/enemyplanes',
+ ),
+ true,
+ ),
+ array(
+ $providers['videopress'],
+ array(
+ 'https://videopress.com/v/kUJmAcSf',
+ ),
+ true,
+ ),
+ array(
+ $providers['speakerdeck'],
+ array(
+ 'https://speakerdeck.com/tollmanz/scaling-wordpress'
+ ),
+ true
+ ),
+ array(
+ $providers['facebook-post'],
+ array(
+ 'https://www.facebook.com/WordPress/posts/10154220015487911'
+ ),
+ true
+ ),
+// array(
+// $providers['facebook-activity'],
+// array(
+// ''
+// ),
+// true
+// ),
+ array(
+ $providers['facebook-photo'],
+ array(
+ 'https://www.facebook.com/WordPress/photos/a.111006762910.97747.6427302910/10153207719422911/'
+ ),
+ true
+ ),
+ array(
+ $providers['facebook-permalink'],
+ array(
+ 'https://www.facebook.com/permalink.php?story_fbid=10154220015487911'
+ ),
+ true
+ ),
+ array(
+ $providers['facebook-media'],
+ array(
+ 'https://www.facebook.com/media/set/?set=a.164630483698579.1073741878.150601778434783&type=1&l=6c3a7725d5'
+ ),
+ true
+ ),
+// array(
+// $providers['facebook-questions'],
+// array(
+// ''
+// ),
+// true
+// ),
+ array(
+ $providers['facebook-notes'],
+ array(
+ 'https://www.facebook.com/notes/facebook/searching-for-answers-ask-facebook-questions/411795942130/'
+ ),
+ true
+ ),
+ array(
+ $providers['facebook-video'],
+ array(
+ 'https://www.facebook.com/WordPress/videos/317622575398/'
+ ),
+ true
+ ),
+ array(
+ $providers['facebook-videophp'],
+ array(
+ 'https://www.facebook.com/video.php?v=317622575398',
+ 'https://www.facebook.com/video.php?id=317622575398',
+ ),
+ true
+ ),
+ );
+ }
+
+ protected function setup_http_hooks() {
+ add_action( 'http_api_debug', array( $this, 'action_http_api_debug' ), 99, 5 );
+ }
+
+ protected function teardown_http_hooks() {
+ remove_action( 'http_api_debug', array( $this, 'action_http_api_debug' ), 99 );
+ $this->http_response = null;
+ }
+
+ public function filter_oembed_fetch_url( $provider_url, $embed_url, $args ) {
+ // this allows us to test invalid data without it being converted to an integer in `WP_oEmbed::fetch()`
+ $provider_url = add_query_arg( 'maxwidth', $args['width'], $provider_url );
+ $provider_url = add_query_arg( 'maxheight', $args['height'], $provider_url );
+ return $provider_url;
+ }
+
+ /**
+ * Debugging action for the HTTP API response.
+ *
+ * @param array|WP_Error $response The HTTP response.
+ * @param string $action The debug action.
+ * @param string $class The HTTP transport class name.
+ * @param array $args HTTP request arguments.
+ * @param string $url The request URL.
+ */
+ public function action_http_api_debug( $response, $action, $class, $args, $url ) {
+
+ if ( 'response' !== $action ) {
+ return;
+ }
+
+ $this->http_response = compact( 'response', 'args', 'url' );
+
+ }
+
+}
</ins></span></pre>
</div>
</div>
</body>
</html>