<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[38159] trunk/src: TinyMCE, inline link:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/38159">38159</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/38159","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>azaozz</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-07-26 23:23:21 +0000 (Tue, 26 Jul 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>TinyMCE, inline link:
- Remove proxying through WordPress to test if an URL exists.
- Fix and enhance the regex that tests if the URL is well formed.
Fixes <a href="https://core.trac.wordpress.org/ticket/36638">#36638</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminadminajaxphp">trunk/src/wp-admin/admin-ajax.php</a></li>
<li><a href="#trunksrcwpadminincludesajaxactionsphp">trunk/src/wp-admin/includes/ajax-actions.php</a></li>
<li><a href="#trunksrcwpincludesclasswpeditorphp">trunk/src/wp-includes/class-wp-editor.php</a></li>
<li><a href="#trunksrcwpincludesjstinymcepluginswplinkpluginjs">trunk/src/wp-includes/js/tinymce/plugins/wplink/plugin.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminadminajaxphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/admin-ajax.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/admin-ajax.php 2016-07-26 23:12:14 UTC (rev 38158)
+++ trunk/src/wp-admin/admin-ajax.php 2016-07-26 23:23:21 UTC (rev 38159)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -64,7 +64,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'parse-media-shortcode', 'destroy-sessions', 'install-plugin', 'update-plugin', 'press-this-save-post',
</span><span class="cx" style="display: block; padding: 0 10px"> 'press-this-add-category', 'crop-image', 'generate-password', 'save-wporg-username', 'delete-plugin',
</span><span class="cx" style="display: block; padding: 0 10px"> 'search-plugins', 'search-install-plugins', 'activate-plugin', 'update-theme', 'delete-theme',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'install-theme', 'test_url', 'get-post-thumbnail-html',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'install-theme', 'get-post-thumbnail-html',
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Deprecated
</span></span></pre></div>
<a id="trunksrcwpadminincludesajaxactionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/ajax-actions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/ajax-actions.php 2016-07-26 23:12:14 UTC (rev 38158)
+++ trunk/src/wp-admin/includes/ajax-actions.php 2016-07-26 23:23:21 UTC (rev 38159)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3886,46 +3886,3 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp_send_json_success( $status );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
-/**
- * Ajax handler for testing if a URL exists.
- *
- * Used in the editor.
- *
- * @since 4.6.0
- */
-function wp_ajax_test_url() {
- if ( ! current_user_can( 'edit_posts' ) || ! wp_verify_nonce( $_POST['nonce'], 'wp-test-url' ) ) {
- wp_send_json_error();
- }
-
- $href = esc_url_raw( $_POST['href'] );
-
- // Relative URL
- if ( strpos( $href, '//' ) !== 0 && in_array( $href[0], array( '/', '#', '?' ), true ) ) {
- $href = get_bloginfo( 'url' ) . $href;
- }
-
- // No redirects
- $response = wp_safe_remote_get( $href, array(
- 'timeout' => 15,
- // Use an explicit user-agent
- 'user-agent' => 'WordPress URL Test',
- ) );
-
- $error = false;
-
- if ( is_wp_error( $response ) ) {
- if ( strpos( $response->get_error_message(), 'resolve host' ) !== false ) {
- $error = true;
- }
- } elseif ( wp_remote_retrieve_response_code( $response ) === 404 ) {
- $error = true;
- }
-
- if ( $error ) {
- wp_send_json_error( array( 'httpError' => true ) );
- }
-
- wp_send_json_success();
-}
</del></span></pre></div>
<a id="trunksrcwpincludesclasswpeditorphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-editor.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-editor.php 2016-07-26 23:12:14 UTC (rev 38158)
+++ trunk/src/wp-includes/class-wp-editor.php 2016-07-26 23:23:21 UTC (rev 38159)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1065,7 +1065,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'Ctrl + letter:' => __( 'Ctrl + letter:' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'Letter' => __( 'Letter' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'Action' => __( 'Action' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'Warning: the link has been inserted but the destination cannot be reached.' => __( 'Warning: the link has been inserted but the destination cannot be reached.' ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'Warning: the link has been inserted but may have errors. Please test it.' => __( 'Warning: the link has been inserted but may have errors. Please test it.' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> 'To move focus to other buttons use Tab or the arrow keys. To return focus to the editor press Escape or use one of the buttons.' =>
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'To move focus to other buttons use Tab or the arrow keys. To return focus to the editor press Escape or use one of the buttons.' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'When starting a new paragraph with one of these formatting shortcuts followed by a space, the formatting will be applied automatically. Press Backspace or Escape to undo.' =>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1286,13 +1286,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </script>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $has_wplink = in_array( 'wplink', self::$plugins, true );
-
- if ( $has_wplink ) {
- echo '<input type="hidden" id="_wplink_urltest_nonce" value="' . wp_create_nonce( 'wp-test-url' ) . '" />';
- }
-
- if ( $has_wplink || in_array( 'link', self::$qt_buttons, true ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( in_array( 'wplink', self::$plugins, true ) || in_array( 'link', self::$qt_buttons, true ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> self::wp_link_dialog();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesjstinymcepluginswplinkpluginjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/tinymce/plugins/wplink/plugin.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/tinymce/plugins/wplink/plugin.js 2016-07-26 23:12:14 UTC (rev 38158)
+++ trunk/src/wp-includes/js/tinymce/plugins/wplink/plugin.js 2016-07-26 23:23:21 UTC (rev 38159)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -93,8 +93,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var doingUndoRedo;
</span><span class="cx" style="display: block; padding: 0 10px"> var doingUndoRedoTimer;
</span><span class="cx" style="display: block; padding: 0 10px"> var $ = window.jQuery;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var urlErrors = {};
</del><span class="cx" style="display: block; padding: 0 10px"> var emailRegex = /^(mailto:)?[a-z0-9._%+-]+@[a-z0-9][a-z0-9.-]*\.[a-z]{2,63}$/i;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var urlRegex1 = /^https?:\/\/([^\s/?.#-][^\s\/?.#]*\.?)+(\/[^\s"]*)?$/i;
+ var urlRegex2 = /^https?:\/\/[^\/]+\.[^\/]+($|\/)/i;
</ins><span class="cx" style="display: block; padding: 0 10px"> var speak = ( typeof window.wp !== 'undefined' && window.wp.a11y && window.wp.a11y.speak ) ? window.wp.a11y.speak : function() {};
</span><span class="cx" style="display: block; padding: 0 10px"> var hasLinkError = false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -150,16 +151,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function setLinkError( $link ) {
- hasLinkError = true;
- $link.attr( 'data-wplink-url-error', 'true' );
- speak( editor.translate( 'Warning: the link has been inserted but the destination cannot be reached.' ), 'assertive' );
-
- if ( toolbar && toolbar.visible() ) {
- toolbar.$el.find( '.wp-link-preview a' ).addClass( 'wplink-url-error' );
- }
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> function checkLink( node ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var $link = editor.$( node );
</span><span class="cx" style="display: block; padding: 0 10px"> var href = $link.attr( 'href' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -170,34 +161,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> hasLinkError = false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( /^http/i.test( href ) && ! /^https?:\/\/[a-z0-9][a-z0-9.-]*\.[a-z]{2,63}(\/|$)/i.test( href ) ) {
- urlErrors[href] = true;
- }
-
- if ( urlErrors.hasOwnProperty( href ) ) {
- setLinkError( $link );
- return;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( /^http/i.test( href ) && ( ! urlRegex1.test( href ) || ! urlRegex2.test( href ) ) ) {
+ hasLinkError = true;
+ $link.attr( 'data-wplink-url-error', 'true' );
+ speak( editor.translate( 'Warning: the link has been inserted but may have errors. Please test it.' ), 'assertive' );
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $link.removeAttr( 'data-wplink-url-error' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- $.post(
- window.ajaxurl, {
- action: 'test_url',
- nonce: $( '#_wplink_urltest_nonce' ).val(),
- href: href
- },
- 'json'
- ).done( function( response ) {
- if ( response.success ) {
- return;
- }
-
- if ( response.data && response.data.httpError ) {
- urlErrors[href] = true;
- setLinkError( $link );
- }
- });
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> editor.on( 'preinit', function() {
</span></span></pre>
</div>
</div>
</body>
</html>