<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[37814] branches/4.3: Media: Improve handling of extensionless filenames.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/37814">37814</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/37814","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>joemcgill</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-06-21 14:54:36 +0000 (Tue, 21 Jun 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: Improve handling of extensionless filenames.
Merge of <a href="https://core.trac.wordpress.org/changeset/37756">[37756]</a> to the 4.3 branch.
See <a href="https://core.trac.wordpress.org/ticket/37111">#37111</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches43srcwpincludesformattingphp">branches/4.3/src/wp-includes/formatting.php</a></li>
<li><a href="#branches43testsphpunittestsformattingSanitizeFileNamephp">branches/4.3/tests/phpunit/tests/formatting/SanitizeFileName.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches43srcwpincludesformattingphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.3/src/wp-includes/formatting.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.3/src/wp-includes/formatting.php 2016-06-21 14:54:22 UTC (rev 37813)
+++ branches/4.3/src/wp-includes/formatting.php 2016-06-21 14:54:36 UTC (rev 37814)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1298,7 +1298,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * operating systems and special characters requiring special escaping
</span><span class="cx" style="display: block; padding: 0 10px"> * to manipulate at the command line. Replaces spaces and consecutive
</span><span class="cx" style="display: block; padding: 0 10px"> * dashes with a single dash. Trims period, dash and underscore from beginning
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * and end of filename.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * and end of filename. It is not guaranteed that this function will return a
+ * filename that is allowed to be uploaded.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 2.1.0
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1323,6 +1324,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $filename = preg_replace( '/[\r\n\t -]+/', '-', $filename );
</span><span class="cx" style="display: block; padding: 0 10px"> $filename = trim( $filename, '.-_' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( false === strpos( $filename, '.' ) ) {
+ $mime_types = wp_get_mime_types();
+ $filetype = wp_check_filetype( 'test.' . $filename, $mime_types );
+ if ( $filetype['ext'] === $filename ) {
+ $filename = 'unnamed-file.' . $filetype['ext'];
+ }
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Split the filename into a base and extension[s]
</span><span class="cx" style="display: block; padding: 0 10px"> $parts = explode('.', $filename);
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="branches43testsphpunittestsformattingSanitizeFileNamephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.3/tests/phpunit/tests/formatting/SanitizeFileName.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.3/tests/phpunit/tests/formatting/SanitizeFileName.php 2016-06-21 14:54:22 UTC (rev 37813)
+++ branches/4.3/tests/phpunit/tests/formatting/SanitizeFileName.php 2016-06-21 14:54:36 UTC (rev 37814)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -49,4 +49,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals("a-t", sanitize_file_name("a t"));
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals("a-t", sanitize_file_name("a \n\n\nt"));
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ function test_replaces_unnammed_file_extensions() {
+ // Test filenames with both supported and unsupported extensions.
+ $this->assertEquals( 'unnamed-file.exe', sanitize_file_name( '_.exe' ) );
+ $this->assertEquals( 'unnamed-file.jpg', sanitize_file_name( '_.jpg' ) );
+ }
+
+ function test_replaces_unnammed_file_extensionless() {
+ // Test a filenames that becomes extensionless.
+ $this->assertEquals( 'no-extension', sanitize_file_name( '_.no-extension' ) );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>