<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[37465] trunk: Introduce `required` argument for `wp_dropdown_categories()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/37465">37465</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/37465","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-05-19 02:38:33 +0000 (Thu, 19 May 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Introduce `required` argument for `wp_dropdown_categories()`.
This allows the HTML5 `required` attribute to be added to the `select` element.
Props wzislam, pcarvalho.
Fixes <a href="https://core.trac.wordpress.org/ticket/31909">#31909</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescategorytemplatephp">trunk/src/wp-includes/category-template.php</a></li>
<li><a href="#trunktestsphpunittestscategorywpDropdownCategoriesphp">trunk/tests/phpunit/tests/category/wpDropdownCategories.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescategorytemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/category-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/category-template.php 2016-05-19 02:22:59 UTC (rev 37464)
+++ trunk/src/wp-includes/category-template.php 2016-05-19 02:38:33 UTC (rev 37465)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -314,6 +314,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 2.1.0
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.2.0 Introduced the `value_field` argument.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 4.6.0 Introduced the `required` argument.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string|array $args {
</span><span class="cx" style="display: block; padding: 0 10px"> * Optional. Array or string of arguments to generate a categories drop-down element.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -351,6 +352,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string|array $taxonomy Name of the category or categories to retrieve. Default 'category'.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool $hide_if_empty True to skip generating markup if no categories are found.
</span><span class="cx" style="display: block; padding: 0 10px"> * Default false (create select element even if no categories are found).
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @type bool $required Whether the <select> element should have the HTML5 'required' attribute.
+ * Default false.
</ins><span class="cx" style="display: block; padding: 0 10px"> * }
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string HTML content only if 'echo' argument is 0.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -376,6 +379,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'hide_if_empty' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'option_none_value' => -1,
</span><span class="cx" style="display: block; padding: 0 10px"> 'value_field' => 'term_id',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'required' => false,
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $defaults['selected'] = ( is_category() ) ? get_query_var( 'cat' ) : 0;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -414,9 +418,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $name = esc_attr( $r['name'] );
</span><span class="cx" style="display: block; padding: 0 10px"> $class = esc_attr( $r['class'] );
</span><span class="cx" style="display: block; padding: 0 10px"> $id = $r['id'] ? esc_attr( $r['id'] ) : $name;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $required = $r['required'] ? 'required' : '';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $r['hide_if_empty'] || ! empty( $categories ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $output = "<select name='$name' id='$id' class='$class' $tab_index_attribute>\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $output = "<select $required name='$name' id='$id' class='$class' $tab_index_attribute>\n";
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $output = '';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunittestscategorywpDropdownCategoriesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/category/wpDropdownCategories.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/category/wpDropdownCategories.php 2016-05-19 02:22:59 UTC (rev 37464)
+++ trunk/tests/phpunit/tests/category/wpDropdownCategories.php 2016-05-19 02:38:33 UTC (rev 37465)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -153,4 +153,72 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertNotContains( 'value="' . $_cat->slug . '" selected="selected"', $found );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * @ticket 31909
+ */
+ public function test_required_true_should_add_required_attribute() {
+ // Create a test category.
+ $cat_id = self::factory()->category->create( array(
+ 'name' => 'Test Category',
+ 'slug' => 'test_category',
+ ) );
+
+ $args = array(
+ 'show_option_none' => __( 'Select one', 'text-domain' ),
+ 'option_none_value' => "",
+ 'required' => true,
+ 'hide_empty' => 0,
+ 'echo' => 0,
+ );
+ $dropdown_categories = wp_dropdown_categories( $args );
+
+ // Test to see if it contains the "required" attribute.
+ $this->assertRegExp( '/<select[^>]+required/', $dropdown_categories );
+ }
+
+ /**
+ * @ticket 31909
+ */
+ public function test_required_false_should_omit_required_attribute() {
+ // Create a test category.
+ $cat_id = self::factory()->category->create( array(
+ 'name' => 'Test Category',
+ 'slug' => 'test_category',
+ ) );
+
+ $args = array(
+ 'show_option_none' => __( 'Select one', 'text-domain' ),
+ 'option_none_value' => "",
+ 'required' => false,
+ 'hide_empty' => 0,
+ 'echo' => 0,
+ );
+ $dropdown_categories = wp_dropdown_categories( $args );
+
+ // Test to see if it contains the "required" attribute.
+ $this->assertNotRegExp( '/<select[^>]+required/', $dropdown_categories );
+ }
+
+ /**
+ * @ticket 31909
+ */
+ public function test_required_should_default_to_false() {
+ // Create a test category.
+ $cat_id = self::factory()->category->create( array(
+ 'name' => 'Test Category',
+ 'slug' => 'test_category',
+ ) );
+
+ $args = array(
+ 'show_option_none' => __( 'Select one', 'text-domain' ),
+ 'option_none_value' => "",
+ 'hide_empty' => 0,
+ 'echo' => 0,
+ );
+ $dropdown_categories = wp_dropdown_categories( $args );
+
+ // Test to see if it contains the "required" attribute.
+ $this->assertNotRegExp( '/<select[^>]+required/', $dropdown_categories );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>