<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[36625] trunk: Query: `is_*( $int )` should not falsely match strings starting with "$int".</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/36625">36625</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/36625","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-02-23 02:20:28 +0000 (Tue, 23 Feb 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Query: `is_*( $int )` should not falsely match strings starting with "$int".
Another chapter in the Storied Annals of Weird `in_array()` Behavior:
`in_array( 4, array( "4-cool-dudes" ) );` resolves to `true`, such that
`is_page( 4 )` was returning true for posts with the name `'4-cool-dudes'`.
We work around this behavior by ensuring that values passed to the `is_`
methods are cast to strings before the `in_array()` checks. ID checks still
work as expected; see <a href="https://core.trac.wordpress.org/ticket/24674">#24674</a>.
Props mikejolley, swissspidy, boonebgorges.
Fixes <a href="https://core.trac.wordpress.org/ticket/35902">#35902</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesqueryphp">trunk/src/wp-includes/query.php</a></li>
<li><a href="#trunktestsphpunittestsqueryconditionalsphp">trunk/tests/phpunit/tests/query/conditionals.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesqueryphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/query.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/query.php 2016-02-23 01:27:55 UTC (rev 36624)
+++ trunk/src/wp-includes/query.php 2016-02-23 02:20:28 UTC (rev 36625)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4202,7 +4202,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attachment = (array) $attachment;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attachment = array_map( 'strval', (array) $attachment );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $post_obj = $this->get_queried_object();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4236,7 +4236,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $author_obj = $this->get_queried_object();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $author = (array) $author;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $author = array_map( 'strval', (array) $author );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( (string) $author_obj->ID, $author ) )
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4268,7 +4268,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $cat_obj = $this->get_queried_object();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $category = (array) $category;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $category = array_map( 'strval', (array) $category );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( (string) $cat_obj->term_id, $category ) )
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4300,7 +4300,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $tag_obj = $this->get_queried_object();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $tag = (array) $tag;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $tag = array_map( 'strval', (array) $tag );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( (string) $tag_obj->term_id, $tag ) )
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4502,7 +4502,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $page_obj = $this->get_queried_object();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $page = (array) $page;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $page = array_map( 'strval', (array) $page );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( (string) $page_obj->ID, $page ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4595,7 +4595,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $post_obj = $this->get_queried_object();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post = (array) $post;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post = array_map( 'strval', (array) $post );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( (string) $post_obj->ID, $post ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span></span></pre></div>
<a id="trunktestsphpunittestsqueryconditionalsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/query/conditionals.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/query/conditionals.php 2016-02-23 01:27:55 UTC (rev 36624)
+++ trunk/tests/phpunit/tests/query/conditionals.php 2016-02-23 02:20:28 UTC (rev 36625)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1017,4 +1017,252 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( is_page_template( array( 'test.php' ) ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( is_page_template( array('test.php', 'example.php') ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_attachment_should_not_match_numeric_id_to_post_title_beginning_with_id() {
+ $p1 = self::factory()->post->create( array(
+ 'post_type' => 'attachment',
+ 'post_title' => 'Foo',
+ 'post_name' => 'foo',
+ ) );
+ $p2 = self::factory()->post->create( array(
+ 'post_type' => 'attachment',
+ 'post_title' => "$p1 Foo",
+ 'post_name' => 'foo-2',
+ ) );
+
+ $this->go_to( get_permalink( $p2 ) );
+
+ $this->assertTrue( is_attachment( $p2 ) );
+ $this->assertFalse( is_attachment( $p1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_attachment_should_not_match_numeric_id_to_post_name_beginning_with_id() {
+ $p1 = self::factory()->post->create( array(
+ 'post_type' => 'attachment',
+ 'post_title' => 'Foo',
+ 'post_name' => 'foo',
+ ) );
+ $p2 = self::factory()->post->create( array(
+ 'post_type' => 'attachment',
+ 'post_title' => 'Foo',
+ 'post_name' => "$p1-foo",
+ ) );
+
+ $this->go_to( get_permalink( $p2 ) );
+
+ $this->assertTrue( is_attachment( $p2 ) );
+ $this->assertFalse( is_attachment( $p1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_author_should_not_match_numeric_id_to_nickname_beginning_with_id() {
+ $u1 = self::factory()->user->create( array(
+ 'nickname' => 'Foo',
+ 'user_nicename' => 'foo',
+ ) );
+ $u2 = self::factory()->user->create( array(
+ 'nickname' => "$u1 Foo",
+ 'user_nicename' => 'foo-2',
+ ) );
+
+ $this->go_to( get_author_posts_url( $u2 ) );
+
+ $this->assertTrue( is_author( $u2 ) );
+ $this->assertFalse( is_author( $u1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_author_should_not_match_numeric_id_to_user_nicename_beginning_with_id() {
+ $u1 = self::factory()->user->create( array(
+ 'nickname' => 'Foo',
+ 'user_nicename' => 'foo',
+ ) );
+ $u2 = self::factory()->user->create( array(
+ 'nickname' => 'Foo',
+ 'user_nicename' => "$u1-foo",
+ ) );
+
+ $this->go_to( get_author_posts_url( $u2 ) );
+
+ $this->assertTrue( is_author( $u2 ) );
+ $this->assertFalse( is_author( $u1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_category_should_not_match_numeric_id_to_name_beginning_with_id() {
+ $t1 = self::factory()->term->create( array(
+ 'taxonomy' => 'category',
+ 'slug' => 'foo',
+ 'name' => 'foo',
+ ) );
+ $t2 = self::factory()->term->create( array(
+ 'taxonomy' => 'category',
+ 'slug' => "$t1-foo",
+ 'name' => 'foo 2',
+ ) );
+
+ $this->go_to( get_term_link( $t2 ) );
+
+ $this->assertTrue( is_category( $t2 ) );
+ $this->assertFalse( is_category( $t1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_category_should_not_match_numeric_id_to_slug_beginning_with_id() {
+ $t1 = self::factory()->term->create( array(
+ 'taxonomy' => 'category',
+ 'slug' => 'foo',
+ 'name' => 'foo',
+ ) );
+ $t2 = self::factory()->term->create( array(
+ 'taxonomy' => 'category',
+ 'slug' => 'foo-2',
+ 'name' => "$t1 foo",
+ ) );
+
+ $this->go_to( get_term_link( $t2 ) );
+
+ $this->assertTrue( is_category( $t2 ) );
+ $this->assertFalse( is_category( $t1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_tag_should_not_match_numeric_id_to_name_beginning_with_id() {
+ $t1 = self::factory()->term->create( array(
+ 'taxonomy' => 'post_tag',
+ 'slug' => 'foo',
+ 'name' => 'foo',
+ ) );
+ $t2 = self::factory()->term->create( array(
+ 'taxonomy' => 'post_tag',
+ 'slug' => "$t1-foo",
+ 'name' => 'foo 2',
+ ) );
+
+ $this->go_to( get_term_link( $t2 ) );
+
+ $this->assertTrue( is_tag( $t2 ) );
+ $this->assertFalse( is_tag( $t1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_tag_should_not_match_numeric_id_to_slug_beginning_with_id() {
+ $t1 = self::factory()->term->create( array(
+ 'taxonomy' => 'post_tag',
+ 'slug' => 'foo',
+ 'name' => 'foo',
+ ) );
+ $t2 = self::factory()->term->create( array(
+ 'taxonomy' => 'post_tag',
+ 'slug' => 'foo-2',
+ 'name' => "$t1 foo",
+ ) );
+
+ $this->go_to( get_term_link( $t2 ) );
+
+ $this->assertTrue( is_tag( $t2 ) );
+ $this->assertFalse( is_tag( $t1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_page_should_not_match_numeric_id_to_post_title_beginning_with_id() {
+ $p1 = self::factory()->post->create( array(
+ 'post_type' => 'page',
+ 'post_title' => 'Foo',
+ 'post_name' => 'foo',
+ ) );
+ $p2 = self::factory()->post->create( array(
+ 'post_type' => 'page',
+ 'post_title' => "$p1 Foo",
+ 'post_name' => 'foo-2',
+ ) );
+
+ $this->go_to( get_permalink( $p2 ) );
+
+ $this->assertTrue( is_page( $p2 ) );
+ $this->assertFalse( is_page( $p1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_page_should_not_match_numeric_id_to_post_name_beginning_with_id() {
+ $p1 = self::factory()->post->create( array(
+ 'post_type' => 'page',
+ 'post_title' => 'Foo',
+ 'post_name' => 'foo',
+ ) );
+ $p2 = self::factory()->post->create( array(
+ 'post_type' => 'page',
+ 'post_title' => 'Foo',
+ 'post_name' => "$p1-foo",
+ ) );
+
+ $this->go_to( get_permalink( $p2 ) );
+
+ $this->assertTrue( is_page( $p2 ) );
+ $this->assertFalse( is_page( $p1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_single_should_not_match_numeric_id_to_post_title_beginning_with_id() {
+ $p1 = self::factory()->post->create( array(
+ 'post_type' => 'post',
+ 'post_title' => 'Foo',
+ 'post_name' => 'foo',
+ ) );
+ $p2 = self::factory()->post->create( array(
+ 'post_type' => 'post',
+ 'post_title' => "$p1 Foo",
+ 'post_name' => 'foo-2',
+ ) );
+
+ $this->go_to( get_permalink( $p2 ) );
+
+ $this->assertTrue( is_single( $p2 ) );
+ $this->assertFalse( is_single( $p1 ) );
+ }
+
+ /**
+ * @ticket 35902
+ */
+ public function test_is_single_should_not_match_numeric_id_to_post_name_beginning_with_id() {
+ $p1 = self::factory()->post->create( array(
+ 'post_type' => 'post',
+ 'post_title' => 'Foo',
+ 'post_name' => 'foo',
+ ) );
+ $p2 = self::factory()->post->create( array(
+ 'post_type' => 'post',
+ 'post_title' => 'Foo',
+ 'post_name' => "$p1-foo",
+ ) );
+
+ $this->go_to( get_permalink( $p2 ) );
+
+ $this->assertTrue( is_single( $p2 ) );
+ $this->assertFalse( is_single( $p1 ) );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>