<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[35834] trunk/src/wp-admin: About Page: use ReverbNation instead of Cloudup to avoid Ad Blocker cruff with tracking pixels.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/35834">35834</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/35834","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>wonderboymusic</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-12-08 20:24:52 +0000 (Tue, 08 Dec 2015)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>About Page: use ReverbNation instead of Cloudup to avoid Ad Blocker cruff with tracking pixels. Adjust the layout accordingly, and improve the layout at smaller breakpoints.

Props melchoyce.
See <a href="https://core.trac.wordpress.org/ticket/34663">#34663</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminaboutphp">trunk/src/wp-admin/about.php</a></li>
<li><a href="#trunksrcwpadmincssaboutcss">trunk/src/wp-admin/css/about.css</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminaboutphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/about.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/about.php      2015-12-08 18:14:57 UTC (rev 35833)
+++ trunk/src/wp-admin/about.php        2015-12-08 20:24:52 UTC (rev 35834)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -85,23 +85,22 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                <div class="embed-container">
</span><span class="cx" style="display: block; padding: 0 10px">                                        <blockquote data-secret="OcUe7B6Edh" class="wp-embedded-content"><a href="https://make.wordpress.org/core/2015/10/28/new-embeds-feature-in-wordpress-4-4/">New Embeds Feature in WordPress 4.4</a></blockquote><iframe class="wp-embedded-content" sandbox="allow-scripts" security="restricted" style="display:none;" src="https://make.wordpress.org/core/2015/10/28/new-embeds-feature-in-wordpress-4-4/embed/#?secret=OcUe7B6Edh" data-secret="OcUe7B6Edh" width="600" height="338" title="Embedded WordPress Post" frameborder="0" marginwidth="0" marginheight="0" scrolling="no"></iframe>
</span><span class="cx" style="display: block; padding: 0 10px">                                </div>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                        </div>
+                       <div class="col">
</ins><span class="cx" style="display: block; padding: 0 10px">                                 <h3><?php _e( 'Embed your WordPress content' ); ?></h3>
</span><span class="cx" style="display: block; padding: 0 10px">                                <p><?php _e( 'Now you can embed your posts on other sites, even other WordPress sites. Simply drop a post URL into the editor and see an instant embed preview, complete with the title, excerpt, and featured image if you&#8217;ve set one. We&#8217;ll even include your site icon and links for comments and sharing.' ); ?></p>
</span><span class="cx" style="display: block; padding: 0 10px">                        </div>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                </div>
+
+               <hr />
+
+               <div class="feature-section two-col">
</ins><span class="cx" style="display: block; padding: 0 10px">                         <div class="col">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                <div class="embed-container">
-                                       <?php
-                                       $embed2 = get_site_transient( 'about-page-embed-2' );
-                                       if ( false === $embed2 ) {
-                                               $embed2 = wp_oembed_get( 'https://cloudup.com/cD3duXiAI5k' );
-                                               if ( ! $embed2 ) {
-                                                       $embed2 = '{{unknown}}';
-                                               }
-                                               set_site_transient( 'about-page-embed-2', $embed2 );
-                                       }
-                                       echo '{{unknown}}' !== $embed2 ? $embed2 : '';
-                                       ?>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         <div class="embed-container embed-reverbnation">
+                                       <iframe width="640" height="150" scrolling="no" frameborder="no" src="https://www.reverbnation.com/widget_code/html_widget/artist_607?widget_id=55&amp;pwc[song_ids]=3731874&amp;pwc[size]=small"></iframe>
</ins><span class="cx" style="display: block; padding: 0 10px">                                 </div>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                        </div>
+                       <div class="col">
</ins><span class="cx" style="display: block; padding: 0 10px">                                 <h3><?php _e( 'Even more embed providers' ); ?></h3>
</span><span class="cx" style="display: block; padding: 0 10px">                                <p><?php _e( 'In addition to post embeds, WordPress 4.4 also adds support for five new oEmbed providers: Cloudup, Reddit&nbsp;Comments, ReverbNation, Speaker&nbsp;Deck, and VideoPress.' ); ?></p>
</span><span class="cx" style="display: block; padding: 0 10px">                        </div>
</span></span></pre></div>
<a id="trunksrcwpadmincssaboutcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/about.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/about.css  2015-12-08 18:14:57 UTC (rev 35833)
+++ trunk/src/wp-admin/css/about.css    2015-12-08 20:24:52 UTC (rev 35834)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -141,6 +141,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">        margin-right: 4.799999999%;
</span><span class="cx" style="display: block; padding: 0 10px">        width: 47.6%;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.about-wrap .feature-section.two-col .col {
+       display: inline-block;
+       float: none;
+       margin-right: 4.799999999%;
+       width: calc( 47.6% - 4px );
+       vertical-align: middle;
+}
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px"> .about-wrap .three-col .col {
</span><span class="cx" style="display: block; padding: 0 10px">        margin-right: 4.999999999%;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -186,6 +193,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">        text-align: left;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.about-wrap .feature-section.two-col h3 {
+       margin-top: 0;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .about-wrap .feature-list h2 {
</span><span class="cx" style="display: block; padding: 0 10px">        margin: 30px 0 15px;
</span><span class="cx" style="display: block; padding: 0 10px">        text-align: center;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -273,10 +284,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">        text-align: center;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.about-wrap .embed-cloudup iframe {
-       height: 299px;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .about-wrap .embed-container iframe {
</span><span class="cx" style="display: block; padding: 0 10px">        max-width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -498,11 +505,21 @@
</span><span class="cx" style="display: block; padding: 0 10px">                width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px">        }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+        .about-wrap .feature-section.two-col .col,
</ins><span class="cx" style="display: block; padding: 0 10px">         .about-wrap .three-col .col,
</span><span class="cx" style="display: block; padding: 0 10px">        .about-wrap .headline-feature .feature-section .col {
</span><span class="cx" style="display: block; padding: 0 10px">                width: 100% !important;
</span><span class="cx" style="display: block; padding: 0 10px">                float: none !important;
</span><span class="cx" style="display: block; padding: 0 10px">        }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+       .about-wrap .feature-section.two-col .col:last-of-type {
+               margin-top: 0;
+       }
+
+       .feature-section.under-the-hood.three-col .col,
+       .feature-section.under-the-hood.one-col .col {
+               padding-bottom: 0;
+       }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px"> @media only screen and (max-width: 400px) {
</span></span></pre>
</div>
</div>

</body>
</html>