<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[35164] trunk/tests/phpunit/tests/admin/includesListTable.php: Share fixtures in `Tests_Admin_includesListTable` tests.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/35164">35164</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/35164","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-10-14 21:40:44 +0000 (Wed, 14 Oct 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Share fixtures in `Tests_Admin_includesListTable` tests.
See <a href="https://core.trac.wordpress.org/ticket/30017">#30017</a>, <a href="https://core.trac.wordpress.org/ticket/33968">#33968</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsadminincludesListTablephp">trunk/tests/phpunit/tests/admin/includesListTable.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestsadminincludesListTablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/admin/includesListTable.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/admin/includesListTable.php 2015-10-14 21:29:59 UTC (rev 35163)
+++ trunk/tests/phpunit/tests/admin/includesListTable.php 2015-10-14 21:40:44 UTC (rev 35164)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4,51 +4,78 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group admin
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_Admin_includesListTable extends WP_UnitTestCase {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ protected static $top;
+ protected static $children;
+ protected static $grandchildren;
+ protected static $post_ids;
+
</ins><span class="cx" style="display: block; padding: 0 10px"> function setUp() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ parent::setUp();
</ins><span class="cx" style="display: block; padding: 0 10px"> set_current_screen( 'edit-page' );
</span><span class="cx" style="display: block; padding: 0 10px"> $GLOBALS['hook_suffix'] = '';
</span><span class="cx" style="display: block; padding: 0 10px"> $this->table = _get_list_table( 'WP_Posts_List_Table' );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- parent::setUp();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function setUpBeforeClass() {
+ $factory = new WP_UnitTest_Factory();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // note that our top/children/grandchildren arrays are 1-indexed
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // create top level pages
</span><span class="cx" style="display: block; padding: 0 10px"> $num_posts = 5;
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( range( 1, $num_posts ) as $i ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->top[$i] = $this->factory->post->create_and_get( array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $p = $factory->post->create_and_get( array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'post_type' => 'page',
</span><span class="cx" style="display: block; padding: 0 10px"> 'post_title' => sprintf( 'Top Level Page %d', $i ),
</span><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ self::$top[ $i ] = $p;
+ self::$post_ids[] = $p;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // create child pages
</span><span class="cx" style="display: block; padding: 0 10px"> $num_children = 3;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( $this->top as $top => $top_page ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( self::$top as $top => $top_page ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> foreach ( range( 1, $num_children ) as $i ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->children[$top][$i] = $this->factory->post->create_and_get( array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $p = $factory->post->create_and_get( array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'post_type' => 'page',
</span><span class="cx" style="display: block; padding: 0 10px"> 'post_parent' => $top_page->ID,
</span><span class="cx" style="display: block; padding: 0 10px"> 'post_title' => sprintf( 'Child %d', $i ),
</span><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ self::$children[ $top ][ $i ] = $p;
+ self::$post_ids[] = $p;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // create grand-child pages for the third and fourth top-level pages
</span><span class="cx" style="display: block; padding: 0 10px"> $num_grandchildren = 3;
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( range( 3, 4 ) as $top ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( $this->children[$top] as $child => $child_page ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( self::$children[ $top ] as $child => $child_page ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> foreach ( range( 1, $num_grandchildren ) as $i ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->grandchildren[$top][$child][$i] = $this->factory->post->create_and_get( array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $p = $factory->post->create_and_get( array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'post_type' => 'page',
</span><span class="cx" style="display: block; padding: 0 10px"> 'post_parent' => $child_page->ID,
</span><span class="cx" style="display: block; padding: 0 10px"> 'post_title' => sprintf( 'Grandchild %d', $i ),
</span><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ self::$grandchildren[ $top ][ $child ][ $i ] = $p;
+ self::$post_ids = $p;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ self::commit_transaction();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function tearDownAfterClass() {
+ foreach ( self::$post_ids as $post_id ) {
+ wp_delete_post( $post_id, true );
+ }
+
+ self::commit_transaction();
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 15459
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -57,8 +84,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'paged' => 1,
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => 2,
</span><span class="cx" style="display: block; padding: 0 10px"> ), array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->top[1]->ID,
- $this->children[1][1]->ID,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self::$top[1]->ID,
+ self::$children[1][1]->ID,
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -70,9 +97,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'paged' => 2,
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => 2,
</span><span class="cx" style="display: block; padding: 0 10px"> ), array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->top[1]->ID,
- $this->children[1][2]->ID,
- $this->children[1][3]->ID,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self::$top[1]->ID,
+ self::$children[1][2]->ID,
+ self::$children[1][3]->ID,
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -85,8 +112,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => 2,
</span><span class="cx" style="display: block; padding: 0 10px"> 's' => 'Child',
</span><span class="cx" style="display: block; padding: 0 10px"> ), array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->children[1][1]->ID,
- $this->children[1][2]->ID,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self::$children[1][1]->ID,
+ self::$children[1][2]->ID,
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -99,8 +126,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => 2,
</span><span class="cx" style="display: block; padding: 0 10px"> 's' => 'Top',
</span><span class="cx" style="display: block; padding: 0 10px"> ), array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->top[3]->ID,
- $this->top[4]->ID,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self::$top[3]->ID,
+ self::$top[4]->ID,
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -113,10 +140,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'paged' => 6,
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => 2,
</span><span class="cx" style="display: block; padding: 0 10px"> ), array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->top[3]->ID,
- $this->children[3][1]->ID,
- $this->grandchildren[3][1][1]->ID,
- $this->grandchildren[3][1][2]->ID,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self::$top[3]->ID,
+ self::$children[3][1]->ID,
+ self::$grandchildren[3][1][1]->ID,
+ self::$grandchildren[3][1][2]->ID,
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -129,10 +156,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'paged' => 7,
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => 2,
</span><span class="cx" style="display: block; padding: 0 10px"> ), array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->top[3]->ID,
- $this->children[3][1]->ID,
- $this->grandchildren[3][1][3]->ID,
- $this->children[3][2]->ID,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self::$top[3]->ID,
+ self::$children[3][1]->ID,
+ self::$grandchildren[3][1][3]->ID,
+ self::$children[3][2]->ID,
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>