<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[34801] trunk/tests/phpunit/tests/comment-submission.php: Add missing unit tests from [34799].</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/34801">34801</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/34801","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-10-03 15:09:57 +0000 (Sat, 03 Oct 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Add missing unit tests from <a href="https://core.trac.wordpress.org/changeset/34799">[34799]</a>.
Props johnbillion.
See <a href="https://core.trac.wordpress.org/ticket/34059">#34059</a>.</pre>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestscommentsubmissionphp">trunk/tests/phpunit/tests/comment-submission.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestscommentsubmissionphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/comment-submission.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/comment-submission.php (rev 0)
+++ trunk/tests/phpunit/tests/comment-submission.php 2015-10-03 15:09:57 UTC (rev 34801)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,540 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * @group comment
+ */
+class Tests_Comment_Submission extends WP_UnitTestCase {
+
+ function setUp() {
+ parent::setUp();
+ require_once ABSPATH . WPINC . '/class-phpass.php';
+ }
+
+ function tearDown() {
+ wp_set_current_user( 0 );
+ parent::tearDown();
+ }
+
+ public function test_submitting_comment_to_invalid_post_returns_error() {
+
+ $error = 'comment_id_not_found';
+
+ $this->assertSame( 0, did_action( $error ) );
+
+ $data = array(
+ 'comment_post_ID' => 0,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertSame( 1, did_action( $error ) );
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_to_post_with_closed_comments_returns_error() {
+
+ $error = 'comment_closed';
+
+ $this->assertSame( 0, did_action( $error ) );
+
+ $post = $this->factory->post->create_and_get( array(
+ 'comment_status' => 'closed',
+ ) );
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertSame( 1, did_action( $error ) );
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_to_trashed_post_returns_error() {
+
+ $error = 'comment_on_trash';
+
+ $this->assertSame( 0, did_action( $error ) );
+
+ $post = $this->factory->post->create_and_get();
+ wp_trash_post( $post );
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertSame( 1, did_action( $error ) );
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_to_draft_post_returns_error() {
+
+ $error = 'comment_on_draft';
+
+ $this->assertSame( 0, did_action( $error ) );
+
+ $post = $this->factory->post->create_and_get( array(
+ 'post_status' => 'draft',
+ ) );
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertSame( 1, did_action( $error ) );
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_to_scheduled_post_returns_error() {
+
+ // Same error as commenting on a draft
+ $error = 'comment_on_draft';
+
+ $this->assertSame( 0, did_action( $error ) );
+
+ $post = $this->factory->post->create_and_get( array(
+ 'post_date' => date( 'Y-m-d H:i:s', strtotime( '+1 day' ) ),
+ ) );
+
+ $this->assertSame( 'future', $post->post_status );
+
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertSame( 1, did_action( $error ) );
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_to_password_required_post_returns_error() {
+
+ $error = 'comment_on_password_protected';
+
+ $this->assertSame( 0, did_action( $error ) );
+
+ $post = $this->factory->post->create_and_get( array(
+ 'post_password' => 'password',
+ ) );
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertSame( 1, did_action( $error ) );
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_to_password_protected_post_succeeds() {
+
+ $password = 'password';
+ $hasher = new PasswordHash( 8, true );
+
+ $_COOKIE['wp-postpass_' . COOKIEHASH] = $hasher->HashPassword( $password );
+
+ $post = $this->factory->post->create_and_get( array(
+ 'post_password' => $password,
+ ) );
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment',
+ 'author' => 'Comment Author',
+ 'email' => 'comment@example.org',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ unset( $_COOKIE['wp-postpass_' . COOKIEHASH] );
+
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+
+ }
+
+ public function test_submitting_valid_comment_as_logged_in_user_succeeds() {
+
+ $user = $this->factory->user->create_and_get( array(
+ 'user_url' => 'http://user.example.org'
+ ) );
+
+ wp_set_current_user( $user->ID );
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+
+ $this->assertSame( 'Comment', $comment->comment_content);
+ $this->assertSame( $user->display_name, $comment->comment_author );
+ $this->assertSame( $user->user_email, $comment->comment_author_email );
+ $this->assertSame( $user->user_url, $comment->comment_author_url );
+
+ }
+
+ public function test_submitting_valid_comment_anonymously_succeeds() {
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment',
+ 'author' => 'Comment Author',
+ 'email' => 'comment@example.org',
+ 'url' => 'user.example.org'
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+
+ $this->assertSame( 'Comment', $comment->comment_content);
+ $this->assertSame( 'Comment Author', $comment->comment_author );
+ $this->assertSame( 'comment@example.org', $comment->comment_author_email );
+ $this->assertSame( 'http://user.example.org', $comment->comment_author_url );
+
+ }
+
+ /**
+ * wp_handle_comment_submission() expects un-slashed data.
+ *
+ * @group slashes
+ */
+ public function test_submitting_comment_handles_slashes_correctly_handles_slashes() {
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment with 1 slash: \\',
+ 'author' => 'Comment Author with 1 slash: \\',
+ 'email' => 'comment@example.org',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+
+ $this->assertSame( 'Comment with 1 slash: \\', $comment->comment_content);
+ $this->assertSame( 'Comment Author with 1 slash: \\', $comment->comment_author );
+ $this->assertSame( 'comment@example.org', $comment->comment_author_email );
+
+ }
+
+ public function test_submitting_comment_anonymously_to_private_post_returns_error() {
+
+ $error = 'not_logged_in';
+
+ $post = $this->factory->post->create_and_get( array(
+ 'post_status' => 'private',
+ ) );
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertFalse( is_user_logged_in() );
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_to_own_private_post_succeeds() {
+
+ $user = $this->factory->user->create_and_get();
+
+ wp_set_current_user( $user->ID );
+
+ $post = $this->factory->post->create_and_get( array(
+ 'post_status' => 'private',
+ 'post_author' => $user->ID,
+ ) );
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertTrue( current_user_can( 'read_post', $post->ID ) );
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+
+ }
+
+ public function test_submitting_comment_to_accessible_private_post_succeeds() {
+
+ $author = $this->factory->user->create_and_get( array(
+ 'role' => 'author',
+ ) );
+ $user = $this->factory->user->create_and_get( array(
+ 'role' => 'editor',
+ ) );
+
+ wp_set_current_user( $user->ID );
+
+ $post = $this->factory->post->create_and_get( array(
+ 'post_status' => 'private',
+ 'post_author' => $author->ID,
+ ) );
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertTrue( current_user_can( 'read_post', $post->ID ) );
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+
+ }
+
+ public function test_anonymous_user_cannot_comment_unfiltered_html() {
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment <script>alert(document.cookie);</script>',
+ 'author' => 'Comment Author',
+ 'email' => 'comment@example.org',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+ $this->assertNotContains( '<script', $comment->comment_content );
+
+ }
+
+ public function test_unprivileged_user_cannot_comment_unfiltered_html() {
+
+ $user = $this->factory->user->create_and_get( array(
+ 'role' => 'author',
+ ) );
+ wp_set_current_user( $user->ID );
+
+ $this->assertFalse( current_user_can( 'unfiltered_html' ) );
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment <script>alert(document.cookie);</script>',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+ $this->assertNotContains( '<script', $comment->comment_content );
+
+ }
+
+ public function test_unprivileged_user_cannot_comment_unfiltered_html_even_with_valid_nonce() {
+
+ $user = $this->factory->user->create_and_get( array(
+ 'role' => 'author',
+ ) );
+ wp_set_current_user( $user->ID );
+
+ $this->assertFalse( current_user_can( 'unfiltered_html' ) );
+
+ $post = $this->factory->post->create_and_get();
+ $action = 'unfiltered-html-comment_' . $post->ID;
+ $nonce = wp_create_nonce( $action );
+
+ $this->assertNotEmpty( wp_verify_nonce( $nonce, $action ) );
+
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment <script>alert(document.cookie);</script>',
+ '_wp_unfiltered_html_comment' => $nonce,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+ $this->assertNotContains( '<script', $comment->comment_content );
+
+ }
+
+ public function test_privileged_user_can_comment_unfiltered_html_with_valid_nonce() {
+
+ $this->assertFalse( defined( 'DISALLOW_UNFILTERED_HTML' ) );
+
+ $user = $this->factory->user->create_and_get( array(
+ 'role' => 'editor',
+ ) );
+
+ if ( is_multisite() ) {
+ // In multisite, only Super Admins can post unfiltered HTML
+ $this->assertFalse( user_can( $user->ID, 'unfiltered_html' ) );
+ grant_super_admin( $user->ID );
+ }
+
+ wp_set_current_user( $user->ID );
+
+ $this->assertTrue( current_user_can( 'unfiltered_html' ) );
+
+ $post = $this->factory->post->create_and_get();
+ $action = 'unfiltered-html-comment_' . $post->ID;
+ $nonce = wp_create_nonce( $action );
+
+ $this->assertNotEmpty( wp_verify_nonce( $nonce, $action ) );
+
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment <script>alert(document.cookie);</script>',
+ '_wp_unfiltered_html_comment' => $nonce,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+ $this->assertContains( '<script', $comment->comment_content );
+
+ }
+
+ public function test_privileged_user_cannot_comment_unfiltered_html_without_valid_nonce() {
+
+ $user = $this->factory->user->create_and_get( array(
+ 'role' => 'editor',
+ ) );
+
+ if ( is_multisite() ) {
+ // In multisite, only Super Admins can post unfiltered HTML
+ $this->assertFalse( user_can( $user->ID, 'unfiltered_html' ) );
+ grant_super_admin( $user->ID );
+ }
+
+ wp_set_current_user( $user->ID );
+
+ $this->assertTrue( current_user_can( 'unfiltered_html' ) );
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment <script>alert(document.cookie);</script>',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertNotWPError( $comment );
+ $this->assertInstanceOf( 'WP_Comment', $comment );
+ $this->assertNotContains( '<script', $comment->comment_content );
+
+ }
+
+ public function test_submitting_comment_as_anonymous_user_when_registration_required_returns_error() {
+
+ $error = 'not_logged_in';
+
+ $_comment_registration = get_option( 'comment_registration' );
+ update_option( 'comment_registration', '1' );
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ update_option( 'comment_registration', $_comment_registration );
+
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_with_no_name_when_name_email_required_returns_error() {
+
+ $error = 'require_name_email';
+
+ $_require_name_email = get_option( 'require_name_email' );
+ update_option( 'require_name_email', '1' );
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment',
+ 'email' => 'comment@example.org',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ update_option( 'require_name_email', $_require_name_email );
+
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_with_no_email_when_name_email_required_returns_error() {
+
+ $error = 'require_name_email';
+
+ $_require_name_email = get_option( 'require_name_email' );
+ update_option( 'require_name_email', '1' );
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment',
+ 'author' => 'Comment Author',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ update_option( 'require_name_email', $_require_name_email );
+
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_with_invalid_email_when_name_email_required_returns_error() {
+
+ $error = 'require_valid_email';
+
+ $_require_name_email = get_option( 'require_name_email' );
+ update_option( 'require_name_email', '1' );
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => 'Comment',
+ 'author' => 'Comment Author',
+ 'email' => 'not_an_email',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ update_option( 'require_name_email', $_require_name_email );
+
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+ public function test_submitting_comment_with_no_comment_content_returns_error() {
+
+ $error = 'require_valid_comment';
+
+ $post = $this->factory->post->create_and_get();
+ $data = array(
+ 'comment_post_ID' => $post->ID,
+ 'comment' => '',
+ 'author' => 'Comment Author',
+ 'email' => 'comment@example.org',
+ );
+ $comment = wp_handle_comment_submission( $data );
+
+ $this->assertWPError( $comment );
+ $this->assertSame( $error, $comment->get_error_code() );
+
+ }
+
+}
</ins></span></pre>
</div>
</div>
</body>
</html>