<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[34743] trunk/src/wp-admin: In `wp_comment_reply()` change the H5 headings in fieldset legends for better accessibility.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/34743">34743</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/34743","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>afercia</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-10-01 14:51:25 +0000 (Thu, 01 Oct 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>In `wp_comment_reply()` change the H5 headings in fieldset legends for better accessibility.
Also, add a "Edit Comment" legend before the Quick Edit form to pair it with "Reply to Comment" and "Add new Comment" and move the Name, Email, and URL fields after the Comment textarea.
Props joedolson, afercia.
Fixes <a href="https://core.trac.wordpress.org/ticket/33757">#33757</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsseditcss">trunk/src/wp-admin/css/edit.css</a></li>
<li><a href="#trunksrcwpadmincsslisttablescss">trunk/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#trunksrcwpadminincludestemplatefunctionsphp">trunk/src/wp-admin/includes/template-functions.php</a></li>
<li><a href="#trunksrcwpadminjseditcommentsjs">trunk/src/wp-admin/js/edit-comments.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsseditcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/edit.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/edit.css 2015-10-01 14:32:15 UTC (rev 34742)
+++ trunk/src/wp-admin/css/edit.css 2015-10-01 14:51:25 UTC (rev 34743)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -24,11 +24,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> #save-action .spinner,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#show-comments a,
-#show-comments .spinner {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#show-comments a {
</ins><span class="cx" style="display: block; padding: 0 10px"> float: left;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#show-comments .spinner {
+ float: none;
+ margin-top: 0;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> #lost-connection-notice .spinner {
</span><span class="cx" style="display: block; padding: 0 10px"> visibility: visible;
</span><span class="cx" style="display: block; padding: 0 10px"> float: left;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -247,7 +251,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #normal-sortables .postbox #replyrow .submit {
</span><span class="cx" style="display: block; padding: 0 10px"> float: none;
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- padding: 0 7px 5px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ padding: 5px 7px 10px;
+ overflow: hidden;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> #side-sortables .submitbox .submit input,
</span></span></pre></div>
<a id="trunksrcwpadmincsslisttablescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/list-tables.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/list-tables.css 2015-10-01 14:32:15 UTC (rev 34742)
+++ trunk/src/wp-admin/css/list-tables.css 2015-10-01 14:51:25 UTC (rev 34743)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -152,7 +152,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> #replysubmit {
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- padding: 0 5px 3px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ padding: 5px 7px 10px;
+ overflow: hidden;
</ins><span class="cx" style="display: block; padding: 0 10px"> text-align: center;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -166,13 +167,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> text-align: center;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#replyrow h5 {
- margin: .2em 0 0;
- padding: 0 5px;
- line-height: 1.4em;
- font-size: 1em;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#replyrow.inline-edit-row fieldset.comment-reply {
+ font-size: inherit;
+ line-height: inherit;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#replyrow legend {
+ margin: 0;
+ padding: .2em 5px 0;
+ font-size: 13px;
+ line-height: 1.4;
+ font-weight: 600;
+}
+
+#replyrow.inline-edit-row label {
+ display: inline;
+ vertical-align: baseline;
+ line-height: inherit;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> #edithead .inside,
</span><span class="cx" style="display: block; padding: 0 10px"> #commentsdiv #edithead .inside {
</span><span class="cx" style="display: block; padding: 0 10px"> float: left;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -433,7 +446,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> #commentsdiv #edithead .inside input {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- vertical-align: middle;
</del><span class="cx" style="display: block; padding: 0 10px"> width: 160px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludestemplatefunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/template-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/template-functions.php 2015-10-01 14:32:15 UTC (rev 34742)
+++ trunk/src/wp-admin/includes/template-functions.php 2015-10-01 14:51:25 UTC (rev 34743)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -380,8 +380,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php else : ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="com-reply" style="display:none;"><div id="replyrow" style="display:none;">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <div id="replyhead" style="display:none;"><h5><?php _e( 'Reply to Comment' ); ?></h5></div>
- <div id="addhead" style="display:none;"><h5><?php _e('Add new Comment'); ?></h5></div>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <fieldset class="comment-reply">
+ <legend>
+ <span class="hidden" id="editlegend"><?php _e( 'Edit Comment' ); ?></span>
+ <span class="hidden" id="replyhead"><?php _e( 'Reply to Comment' ); ?></span>
+ <span class="hidden" id="addhead"><?php _e( 'Add new Comment' ); ?></span>
+ </legend>
+
+ <div id="replycontainer">
+ <label for="replycontent" class="screen-reader-text"><?php _e( 'Comment' ); ?></label>
+ <?php
+ $quicktags_settings = array( 'buttons' => 'strong,em,link,block,del,ins,img,ul,ol,li,code,close' );
+ wp_editor( '', 'replycontent', array( 'media_buttons' => false, 'tinymce' => false, 'quicktags' => $quicktags_settings ) );
+ ?>
+ </div>
+
</ins><span class="cx" style="display: block; padding: 0 10px"> <div id="edithead" style="display:none;">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="inside">
</span><span class="cx" style="display: block; padding: 0 10px"> <label for="author-name"><?php _e( 'Name' ) ?></label>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -397,16 +410,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <label for="author-url"><?php _e('URL') ?></label>
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" id="author-url" name="newcomment_author_url" class="code" size="103" value="" />
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <div style="clear:both;"></div>
</del><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <div id="replycontainer">
- <?php
- $quicktags_settings = array( 'buttons' => 'strong,em,link,block,del,ins,img,ul,ol,li,code,close' );
- wp_editor( '', 'replycontent', array( 'media_buttons' => false, 'tinymce' => false, 'quicktags' => $quicktags_settings ) );
- ?>
- </div>
-
</del><span class="cx" style="display: block; padding: 0 10px"> <p id="replysubmit" class="submit">
</span><span class="cx" style="display: block; padding: 0 10px"> <a href="#comments-form" class="save button-primary alignright">
</span><span class="cx" style="display: block; padding: 0 10px"> <span id="addbtn" style="display:none;"><?php _e('Add Comment'); ?></span>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -415,7 +420,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <a href="#comments-form" class="cancel button-secondary alignleft"><?php _e('Cancel'); ?></a>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="waiting spinner"></span>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="error" style="display:none;"></span>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <br class="clear" />
</del><span class="cx" style="display: block; padding: 0 10px"> </p>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="hidden" name="action" id="action" value="" />
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -430,6 +434,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( current_user_can( 'unfiltered_html' ) )
</span><span class="cx" style="display: block; padding: 0 10px"> wp_nonce_field( 'unfiltered-html-comment', '_wp_unfiltered_html_comment', false );
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ </fieldset>
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php if ( $table_row ) : ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </td></tr></tbody></table>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php else : ?>
</span></span></pre></div>
<a id="trunksrcwpadminjseditcommentsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/edit-comments.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/edit-comments.js 2015-10-01 14:32:15 UTC (rev 34742)
+++ trunk/src/wp-admin/js/edit-comments.js 2015-10-01 14:51:25 UTC (rev 34743)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -676,7 +676,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $('#author-url', editRow).val( $('div.author-url', rowData).text() );
</span><span class="cx" style="display: block; padding: 0 10px"> $('#status', editRow).val( $('div.comment_status', rowData).text() );
</span><span class="cx" style="display: block; padding: 0 10px"> $('#replycontent', editRow).val( $('textarea.comment', rowData).val() );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#edithead, #savebtn', editRow).show();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '#edithead, #editlegend, #savebtn', editRow ).show();
</ins><span class="cx" style="display: block; padding: 0 10px"> $('#replyhead, #replybtn, #addhead, #addbtn', editRow).hide();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( h > 120 ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -691,12 +691,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> } else if ( action == 'add' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $('#addhead, #addbtn', editRow).show();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#replyhead, #replybtn, #edithead, #savebtn', editRow).hide();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '#replyhead, #replybtn, #edithead, #editlegend, #savebtn', editRow ) .hide();
</ins><span class="cx" style="display: block; padding: 0 10px"> $('#the-comment-list').prepend(editRow);
</span><span class="cx" style="display: block; padding: 0 10px"> $('#replyrow').fadeIn(300);
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> replyButton = $('#replybtn', editRow);
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#edithead, #savebtn, #addhead, #addbtn', editRow).hide();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '#edithead, #editlegend, #savebtn, #addhead, #addbtn', editRow ).hide();
</ins><span class="cx" style="display: block; padding: 0 10px"> $('#replyhead, #replybtn', editRow).show();
</span><span class="cx" style="display: block; padding: 0 10px"> c.after(editRow);
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>