<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[33806] trunk: `get_comment_count()` currently increments `awaiting_moderation` when comments are in the trash.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/33806">33806</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/33806","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>wonderboymusic</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-08-30 02:18:18 +0000 (Sun, 30 Aug 2015)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>`get_comment_count()` currently increments `awaiting_moderation` when comments are in the trash. This occurs because `case 0:` will match any value passed to `switch` that is a string that isn't specified in the list of cases. This is terrifying.

* Cases for `0` and `1` should be `'1'` and `'0'`
* Add unit tests for `get_comment_count()`. Currently, there are none.

See <a href="https://core.trac.wordpress.org/ticket/33414">#33414</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescommentfunctionsphp">trunk/src/wp-includes/comment-functions.php</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestscommentgetCommentCountphp">trunk/tests/phpunit/tests/comment/getCommentCount.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescommentfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/comment-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/comment-functions.php       2015-08-29 19:58:13 UTC (rev 33805)
+++ trunk/src/wp-includes/comment-functions.php 2015-08-30 02:18:18 UTC (rev 33806)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -375,11 +375,11 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                $comment_count['spam'] = $row['total'];
</span><span class="cx" style="display: block; padding: 0 10px">                                $comment_count["total_comments"] += $row['total'];
</span><span class="cx" style="display: block; padding: 0 10px">                                break;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        case 1:
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 case '1':
</ins><span class="cx" style="display: block; padding: 0 10px">                                 $comment_count['approved'] = $row['total'];
</span><span class="cx" style="display: block; padding: 0 10px">                                $comment_count['total_comments'] += $row['total'];
</span><span class="cx" style="display: block; padding: 0 10px">                                break;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        case 0:
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 case '0':
</ins><span class="cx" style="display: block; padding: 0 10px">                                 $comment_count['awaiting_moderation'] = $row['total'];
</span><span class="cx" style="display: block; padding: 0 10px">                                $comment_count['total_comments'] += $row['total'];
</span><span class="cx" style="display: block; padding: 0 10px">                                break;
</span></span></pre></div>
<a id="trunktestsphpunittestscommentgetCommentCountphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/comment/getCommentCount.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/comment/getCommentCount.php                             (rev 0)
+++ trunk/tests/phpunit/tests/comment/getCommentCount.php       2015-08-30 02:18:18 UTC (rev 33806)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,65 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+class Tests_Get_Comment_Count extends WP_UnitTestCase {
+
+       public function test_get_comment_count() {
+               $count = get_comment_count();
+
+               $this->assertEquals( 0, $count['approved'] );
+               $this->assertEquals( 0, $count['awaiting_moderation'] );
+               $this->assertEquals( 0, $count['spam'] );
+               $this->assertEquals( 0, $count['total_comments'] );
+       }
+
+       public function test_get_comment_count_approved() {
+               $this->factory->comment->create( array(
+                       'comment_approved' => 1
+               ) );
+
+               $count = get_comment_count();
+
+               $this->assertEquals( 1, $count['approved'] );
+               $this->assertEquals( 0, $count['awaiting_moderation'] );
+               $this->assertEquals( 0, $count['spam'] );
+               $this->assertEquals( 1, $count['total_comments'] );
+       }
+
+       public function test_get_comment_count_awaiting() {
+               $this->factory->comment->create( array(
+                       'comment_approved' => 0
+               ) );
+
+               $count = get_comment_count();
+
+               $this->assertEquals( 0, $count['approved'] );
+               $this->assertEquals( 1, $count['awaiting_moderation'] );
+               $this->assertEquals( 0, $count['spam'] );
+               $this->assertEquals( 1, $count['total_comments'] );
+       }
+
+       public function test_get_comment_count_spam() {
+               $this->factory->comment->create( array(
+                       'comment_approved' => 'spam'
+               ) );
+
+               $count = get_comment_count();
+
+               $this->assertEquals( 0, $count['approved'] );
+               $this->assertEquals( 0, $count['awaiting_moderation'] );
+               $this->assertEquals( 1, $count['spam'] );
+               $this->assertEquals( 1, $count['total_comments'] );
+       }
+
+       public function test_get_comment_count_trash() {
+               $this->factory->comment->create( array(
+                       'comment_approved' => 'trash'
+               ) );
+
+               $count = get_comment_count();
+
+               $this->assertEquals( 0, $count['approved'] );
+               $this->assertEquals( 0, $count['awaiting_moderation'] );
+               $this->assertEquals( 0, $count['spam'] );
+               $this->assertEquals( 0, $count['total_comments'] );
+       }
+}
</ins></span></pre>
</div>
</div>

</body>
</html>