<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[33490] trunk/src/wp-admin: Comments list table: Display that cute lil comment bubble.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/33490">33490</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/33490","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>helen</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-07-29 18:07:03 +0000 (Wed, 29 Jul 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Comments list table: Display that cute lil comment bubble.
The comments list table suffers from "wall of text" problems, which the two plain text links compounded.
props obenland. fixes <a href="https://core.trac.wordpress.org/ticket/33149">#33149</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsslisttablescss">trunk/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#trunksrcwpadminincludesclasswpcommentslisttablephp">trunk/src/wp-admin/includes/class-wp-comments-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsslisttablescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/list-tables.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/list-tables.css 2015-07-29 17:58:06 UTC (rev 33489)
+++ trunk/src/wp-admin/css/list-tables.css 2015-07-29 18:07:03 UTC (rev 33490)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -15,51 +15,38 @@
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 12px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.column-response .post-com-count .screen-reader-text {
- position: static;
- width: auto;
- height: auto;
- margin: 0;
-}
-
-.column-response .post-com-count [aria-hidden="true"] {
- display: none;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .post-com-count-wrapper strong {
</span><span class="cx" style="display: block; padding: 0 10px"> font-weight: 400;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.column-response .post-com-count.post-com-count-pending {
- color: #bb2a2a;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .comments-view-item-link {
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline-block;
</span><span class="cx" style="display: block; padding: 0 10px"> clear: both;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.column-response .post-com-count-wrapper,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-wrapper {
</span><span class="cx" style="display: block; padding: 0 10px"> white-space: nowrap;
</span><span class="cx" style="display: block; padding: 0 10px"> word-wrap: normal;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* comments bubble common */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.column-response .post-com-count,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count {
</span><span class="cx" style="display: block; padding: 0 10px"> display: inline-block;
</span><span class="cx" style="display: block; padding: 0 10px"> vertical-align: top;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.column-response .post-com-count {
- display: block;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> /* comments bubble approved */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.column-response .post-com-count-no-comments,
+.column-response .post-com-count-approved,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-no-comments,
</span><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-approved {
</span><span class="cx" style="display: block; padding: 0 10px"> margin-top: 5px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.column-response .comment-count-no-comments,
+.column-response .comment-count-approved,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .comment-count-no-comments,
</span><span class="cx" style="display: block; padding: 0 10px"> .column-comments .comment-count-approved {
</span><span class="cx" style="display: block; padding: 0 10px"> -webkit-box-sizing: border-box;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -78,11 +65,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> text-align: center;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.ie8 .column-response .comment-count-no-comments,
+.ie8 .column-response .comment-count-approved,
</ins><span class="cx" style="display: block; padding: 0 10px"> .ie8 .column-comments .comment-count-no-comments,
</span><span class="cx" style="display: block; padding: 0 10px"> .ie8 .column-comments .comment-count-approved {
</span><span class="cx" style="display: block; padding: 0 10px"> min-width: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.column-response .post-com-count-no-comments:after,
+.column-response .post-com-count-approved:after,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-no-comments:after,
</span><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-approved:after {
</span><span class="cx" style="display: block; padding: 0 10px"> content: "";
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -94,17 +85,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border-right: 5px solid transparent;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.column-response .post-com-count-approved:hover .comment-count-approved,
+.column-response .post-com-count-approved:focus .comment-count-approved,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-approved:hover .comment-count-approved,
</span><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-approved:focus .comment-count-approved {
</span><span class="cx" style="display: block; padding: 0 10px"> background: #0073aa;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.column-response .post-com-count-approved:hover:after,
+.column-response .post-com-count-approved:focus:after,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-approved:hover:after,
</span><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-approved:focus:after {
</span><span class="cx" style="display: block; padding: 0 10px"> border-top-color: #0073aa;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* comments bubble pending */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.column-response .post-com-count-pending,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-pending {
</span><span class="cx" style="display: block; padding: 0 10px"> position: relative;
</span><span class="cx" style="display: block; padding: 0 10px"> left: -3px;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -208,10 +204,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> vertical-align: text-top;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#the-comment-list .attachment-80x60 {
- padding: 4px 8px;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> #the-comment-list tr.undo,
</span><span class="cx" style="display: block; padding: 0 10px"> #the-comment-list div.undo {
</span><span class="cx" style="display: block; padding: 0 10px"> background-color: #f4f4f4;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1854,29 +1846,37 @@
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .column-response .post-com-count-no-comments:after,
+ .column-response .post-com-count-approved:after,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-no-comments:after,
</span><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-approved:after {
</span><span class="cx" style="display: block; padding: 0 10px"> content: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .column-response .post-com-count [aria-hidden="true"],
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count [aria-hidden="true"] {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .column-response .post-com-count-wrapper,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-wrapper {
</span><span class="cx" style="display: block; padding: 0 10px"> white-space: normal;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .column-response .post-com-count-wrapper > a,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-wrapper > a {
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .column-response .post-com-count-no-comments,
+ .column-response .post-com-count-approved,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-no-comments,
</span><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-approved {
</span><span class="cx" style="display: block; padding: 0 10px"> margin-top: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> margin-right: 0.5em;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .column-response .post-com-count-pending,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-pending {
</span><span class="cx" style="display: block; padding: 0 10px"> position: static;
</span><span class="cx" style="display: block; padding: 0 10px"> height: auto;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1892,6 +1892,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> text-align: left;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .column-response .post-com-count-pending:hover,
</ins><span class="cx" style="display: block; padding: 0 10px"> .column-comments .post-com-count-pending:hover {
</span><span class="cx" style="display: block; padding: 0 10px"> color: #dc3232;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpcommentslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-comments-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-comments-list-table.php 2015-07-29 17:58:06 UTC (rev 33489)
+++ trunk/src/wp-admin/includes/class-wp-comments-list-table.php 2015-07-29 18:07:03 UTC (rev 33490)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -687,16 +687,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<div class="response-links">';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( 'attachment' == $post->post_type && ( $thumb = wp_get_attachment_image( $post->ID, array( 80, 60 ), true ) ) ) {
+ echo $thumb;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> echo $post_link;
</span><span class="cx" style="display: block; padding: 0 10px"> $post_type_object = get_post_type_object( $post->post_type );
</span><span class="cx" style="display: block; padding: 0 10px"> echo "<a href='" . get_permalink( $post->ID ) . "' class='comments-view-item-link'>" . $post_type_object->labels->view_item . '</a>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( 'attachment' == $post->post_type && ( $thumb = wp_get_attachment_image( $post->ID, array( 80, 60 ), true ) ) ) {
- echo $thumb;
- }
- echo '</div>';
</del><span class="cx" style="display: block; padding: 0 10px"> echo '<span class="post-com-count-wrapper">';
</span><span class="cx" style="display: block; padding: 0 10px"> $this->comments_bubble( $post->ID, $pending_comments );
</span><span class="cx" style="display: block; padding: 0 10px"> echo '</span> ';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo '</div>';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre>
</div>
</div>
</body>
</html>