<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[33362] trunk/src/wp-admin: Make password field toggling work in IE8, and clean up a bunch of password CSS issues.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/33362">33362</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/33362","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>markjaquith</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-07-22 16:55:17 +0000 (Wed, 22 Jul 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Make password field toggling work in IE8, and clean up a bunch of password CSS issues.
fixes <a href="https://core.trac.wordpress.org/ticket/32886">#32886</a>
props peterwilsoncc, adamsilverstein</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincssformscss">trunk/src/wp-admin/css/forms.css</a></li>
<li><a href="#trunksrcwpadmincssinstallcss">trunk/src/wp-admin/css/install.css</a></li>
<li><a href="#trunksrcwpadmininstallphp">trunk/src/wp-admin/install.php</a></li>
<li><a href="#trunksrcwpadminjsuserprofilejs">trunk/src/wp-admin/js/user-profile.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincssformscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/forms.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/forms.css 2015-07-22 05:50:03 UTC (rev 33361)
+++ trunk/src/wp-admin/css/forms.css 2015-07-22 16:55:17 UTC (rev 33362)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -479,19 +479,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> opacity: 1;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#pass1.short {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1.short, #pass1-text.short {
</ins><span class="cx" style="display: block; padding: 0 10px"> border-color: #e35b5b;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#pass1.bad {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1.bad, #pass1-text.bad {
</ins><span class="cx" style="display: block; padding: 0 10px"> border-color: #f78b53;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#pass1.good {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1.good, #pass1-text.good {
</ins><span class="cx" style="display: block; padding: 0 10px"> border-color: #ffc733;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#pass1.strong {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1.strong, #pass1-text.strong {
</ins><span class="cx" style="display: block; padding: 0 10px"> border-color: #83c373;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -503,6 +503,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> padding-top: 8px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1-text,
+.show-password #pass1 {
+ display: none;
+}
+
+.show-password #pass1-text
+{
+ display: inline-block;
+}
+
+.form-table span.description.important {
+ font-size: 12px;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> p.search-box {
</span><span class="cx" style="display: block; padding: 0 10px"> float: right;
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0;
</span></span></pre></div>
<a id="trunksrcwpadmincssinstallcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/install.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/install.css 2015-07-22 05:50:03 UTC (rev 33361)
+++ trunk/src/wp-admin/css/install.css 2015-07-22 16:55:17 UTC (rev 33362)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -205,13 +205,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> background-color: #eee;
</span><span class="cx" style="display: block; padding: 0 10px"> border: 1px solid #ddd;
</span><span class="cx" style="display: block; padding: 0 10px"> color: #23282d;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ margin: -2px 5px 5px 0px;
+ padding: 3px 5px;
+ text-align: center;
+ width: 218px;
</ins><span class="cx" style="display: block; padding: 0 10px"> -webkit-box-sizing: border-box;
</span><span class="cx" style="display: block; padding: 0 10px"> -moz-box-sizing: border-box;
</span><span class="cx" style="display: block; padding: 0 10px"> box-sizing: border-box;
</span><span class="cx" style="display: block; padding: 0 10px"> opacity: 0;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- padding: 3px 5px;
- text-align: center;
- width: 218px;
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> #pass-strength-result.short {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -238,19 +239,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> opacity: 1;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-[name="admin_password"].short {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1.short, #pass1-text.short {
</ins><span class="cx" style="display: block; padding: 0 10px"> border-color: #e35b5b;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-[name="admin_password"].bad {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1.bad, #pass1-text.bad {
</ins><span class="cx" style="display: block; padding: 0 10px"> border-color: #f78b53;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-[name="admin_password"].good {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1.good, #pass1-text.good {
</ins><span class="cx" style="display: block; padding: 0 10px"> border-color: #ffc733;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-[name="admin_password"].strong {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1.strong, #pass1-text.strong {
</ins><span class="cx" style="display: block; padding: 0 10px"> border-color: #83c373;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -278,7 +279,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> direction: ltr;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#pass1-text,
+.show-password #pass1 {
+ display: none;
+}
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.show-password #pass1-text
+{
+ display: inline-block;
+}
+
+.form-table span.description.important {
+ font-size: 12px;
+}
+
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* localization */
</span><span class="cx" style="display: block; padding: 0 10px"> body.rtl,
</span><span class="cx" style="display: block; padding: 0 10px"> .rtl textarea,
</span></span></pre></div>
<a id="trunksrcwpadmininstallphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/install.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/install.php 2015-07-22 05:50:03 UTC (rev 33361)
+++ trunk/src/wp-admin/install.php 2015-07-22 16:55:17 UTC (rev 33362)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -137,8 +137,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><span class="cx" style="display: block; padding: 0 10px"> </th>
</span><span class="cx" style="display: block; padding: 0 10px"> <td>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <button type="button" class="button button-secondary wp-generate-pw hide-if-no-js"><?php _e( 'Show password' ); ?></button>
- <div class="wp-pwd hide-if-js">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <div class="">
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php $initial_password = wp_generate_password( 24 ); ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="password" name="admin_password" id="pass1" class="regular-text" autocomplete="off" data-reveal="1" data-pw="<?php echo esc_attr( $initial_password ); ?>" aria-describedby="pass-strength-result" />
</span><span class="cx" style="display: block; padding: 0 10px"> <button type="button" class="button button-secondary wp-hide-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -147,7 +146,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </button>
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="pass-strength-result" aria-live="polite"></div>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p><span class="description hide-if-no-js"><?php _e( 'A password reset link will be sent to you via email.' ); ?></span></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p><span class="description important hide-if-no-js">
+ <strong><?php _e( 'Important:' )?></strong> <?php _e( 'You will need this password to log in, please store it in a secure location.' ); ?></span></p>
</ins><span class="cx" style="display: block; padding: 0 10px"> </td>
</span><span class="cx" style="display: block; padding: 0 10px"> </tr>
</span><span class="cx" style="display: block; padding: 0 10px"> <tr class="form-field form-required user-pass2-wrap hide-if-js">
</span></span></pre></div>
<a id="trunksrcwpadminjsuserprofilejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/user-profile.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/user-profile.js 2015-07-22 05:50:03 UTC (rev 33361)
+++ trunk/src/wp-admin/js/user-profile.js 2015-07-22 16:55:17 UTC (rev 33362)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,4 +1,4 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/* global ajaxurl, pwsL10n, userProfileL10n */
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* global ajaxurl, pwsL10n */
</ins><span class="cx" style="display: block; padding: 0 10px"> (function($){
</span><span class="cx" style="display: block; padding: 0 10px"> $(function(){
</span><span class="cx" style="display: block; padding: 0 10px"> var pw_new = $('.user-pass1-wrap'),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -13,17 +13,37 @@
</span><span class="cx" style="display: block; padding: 0 10px"> pw_submitbtn_edit = $('#submit'),
</span><span class="cx" style="display: block; padding: 0 10px"> pw_submitbtn_new = $( '#createusersub' ),
</span><span class="cx" style="display: block; padding: 0 10px"> pw_checkbox = $('.pw-checkbox'),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- pw_weak = $('.pw-weak')
- ;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ pw_weak = $('.pw-weak'),
+ // Set up a text version of the password input
+ newField = document.createElement( 'input');
+ newField.type = 'text';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var pwFieldText = $( newField );
+
+ if ( pw_field.length > 0 ) {
+ pwFieldText
+ .attr( {
+ 'id': 'pass1-text',
+ 'name': 'pass1-text',
+ 'autocomplete': 'off'
+ } )
+ .addClass( pw_field[0].className )
+ .data( 'pw', pw_field.data( 'pw' ) )
+ .val( pw_field.val() );
+
+ pw_field
+ .wrap( '<span class="password-input-wrapper"></span>' )
+ .after( pwFieldText );
+ }
+
+ var pwWrapper = pw_field.parent();
</ins><span class="cx" style="display: block; padding: 0 10px"> var generatePassword = window.generatePassword = function() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( typeof zxcvbn !== 'function' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> setTimeout( generatePassword, 50 );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> pw_field.val( pw_field.data( 'pw' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> pw_field.trigger( 'propertychange' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- pw_field.attr( 'type', 'text' ).focus();
- pw_field[0].setSelectionRange(100, 100);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ pwWrapper.addClass( 'show-password' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -31,23 +51,28 @@
</span><span class="cx" style="display: block; padding: 0 10px"> pw_line.hide();
</span><span class="cx" style="display: block; padding: 0 10px"> pw_togglebtn.show();
</span><span class="cx" style="display: block; padding: 0 10px"> pw_generatebtn.show();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><span class="cx" style="display: block; padding: 0 10px"> if ( pw_field.data( 'reveal' ) == 1 ) {
</span><span class="cx" style="display: block; padding: 0 10px"> generatePassword();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> parentform.on('submit', function(){
</span><span class="cx" style="display: block; padding: 0 10px"> pw_field2.val( pw_field.val() );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- pw_field.attr('type', 'password');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ pwWrapper.removeClass( 'show-password' );
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ pwFieldText.on( 'input', function(){
+ pw_field.val( pwFieldText.val() );
+ pw_field.trigger( 'propertychange' );
+ } );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> pw_field.on('input propertychange', function(){
</span><span class="cx" style="display: block; padding: 0 10px"> setTimeout( function(){
</span><span class="cx" style="display: block; padding: 0 10px"> var cssClass = pw_strength.attr('class');
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- pw_field.removeClass( 'short bad good strong' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ pwFieldText.val( pw_field.val() );
+ pw_field.add(pwFieldText).removeClass( 'short bad good strong' );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( 'undefined' !== typeof cssClass ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- pw_field.addClass( cssClass );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ pw_field.add(pwFieldText).addClass( cssClass );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( cssClass == 'short' || cssClass == 'bad' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! pw_checkbox.attr( 'checked' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> pw_submitbtn_new.attr( 'disabled','disabled' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -88,23 +113,37 @@
</span><span class="cx" style="display: block; padding: 0 10px"> pw_generatebtn.hide();
</span><span class="cx" style="display: block; padding: 0 10px"> pw_line.show();
</span><span class="cx" style="display: block; padding: 0 10px"> generatePassword();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ _.defer( function() {
+ pwFieldText.focus();
+ if ( ! _.isUndefined( pwFieldText[0].setSelectionRange ) ) {
+ pwFieldText[0].setSelectionRange( 0, 100 );
+ }
+ }, 0 );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> pw_togglebtn.on( 'click', function() {
</span><span class="cx" style="display: block; padding: 0 10px"> var show = pw_togglebtn.attr( 'data-toggle' );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( show == 1 ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- pw_field.attr( 'type', 'text' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ pwWrapper.addClass( 'show-password' );
</ins><span class="cx" style="display: block; padding: 0 10px"> pw_togglebtn.attr({ 'data-toggle': 0, 'aria-label': userProfileL10n.ariaHide })
</span><span class="cx" style="display: block; padding: 0 10px"> .find( '.text' ).text( userProfileL10n.hide )
</span><span class="cx" style="display: block; padding: 0 10px"> ;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ pwFieldText.focus();
+ if ( ! _.isUndefined( pwFieldText[0].setSelectionRange ) ) {
+ pwFieldText[0].setSelectionRange( 0, 100 );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- pw_field.attr( 'type', 'password' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ pwWrapper.removeClass( 'show-password' );
</ins><span class="cx" style="display: block; padding: 0 10px"> pw_togglebtn.attr({ 'data-toggle': 1, 'aria-label': userProfileL10n.ariaShow })
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .find( '.text' ).text( userProfileL10n.show )
- ;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .find( '.text' ).text( userProfileL10n.show );
+ pw_field.focus();
+ if ( ! _.isUndefined( pw_field[0].setSelectionRange ) ) {
+ pw_field[0].setSelectionRange( 0, 100 );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- pw_field.focus();
- pw_field[0].setSelectionRange(100, 100);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>