<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[33110] trunk: Transients: If `get_option( $transient_timeout )` returns false, don't bother trying to delete the transient in `get_transient()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/33110">33110</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/33110","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>ocean90</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-07-07 16:44:08 +0000 (Tue, 07 Jul 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Transients: If `get_option( $transient_timeout )` returns false, don't bother trying to delete the transient in `get_transient()`.
props jamesgol, ericmann.
fixes <a href="https://core.trac.wordpress.org/ticket/30380">#30380</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesoptionphp">trunk/src/wp-includes/option.php</a></li>
<li><a href="#trunktestsphpunittestsoptiontransientphp">trunk/tests/phpunit/tests/option/transient.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesoptionphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/option.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/option.php 2015-07-07 16:40:34 UTC (rev 33109)
+++ trunk/src/wp-includes/option.php 2015-07-07 16:44:08 UTC (rev 33110)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -622,7 +622,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $alloptions = wp_load_alloptions();
</span><span class="cx" style="display: block; padding: 0 10px"> if ( !isset( $alloptions[$transient_option] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $transient_timeout = '_transient_timeout_' . $transient;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( get_option( $transient_timeout ) < time() ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $timeout = get_option( $transient_timeout );
+ if ( false !== $timeout && $timeout < time() ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> delete_option( $transient_option );
</span><span class="cx" style="display: block; padding: 0 10px"> delete_option( $transient_timeout );
</span><span class="cx" style="display: block; padding: 0 10px"> $value = false;
</span></span></pre></div>
<a id="trunktestsphpunittestsoptiontransientphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/option/transient.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/option/transient.php 2015-07-07 16:40:34 UTC (rev 33109)
+++ trunk/tests/phpunit/tests/option/transient.php 2015-07-07 16:44:08 UTC (rev 33110)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -83,4 +83,75 @@
</span><span class="cx" style="display: block; padding: 0 10px"> update_option( '_transient_timeout_' . $key, $now - 1 );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( get_transient( $key ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * If get_option( $transient_timeout ) returns false, don't bother trying to delete the transient.
+ *
+ * @ticket 30380
+ */
+ function test_nonexistent_key_dont_delete_if_false() {
+ // Create a bogus a transient
+ $key = 'test_transient';
+ set_transient( $key, 'test', 60 * 10 );
+ $this->assertEquals( 'test', get_transient( $key ) );
+
+ // Useful variables for tracking
+ $transient_timeout = '_transient_timeout_' . $key;
+
+ // Mock an action for tracking action calls
+ $a = new MockAction();
+
+ // Make sure the timeout option returns false
+ add_filter( 'option_' . $transient_timeout, '__return_false' );
+
+ // Add some actions to make sure options are _not_ deleted
+ add_action( 'delete_option', array( $a, 'action' ) );
+
+ // Act
+ get_transient( $key );
+
+ // Make sure delete option was not called for both the transient and the timeout
+ $this->assertEquals( 0, $a->get_call_count() );
+ }
+
+ /**
+ * @ticket 30380
+ */
+ function test_nonexistent_key_old_timeout() {
+ // Create a transient
+ $key = 'test_transient';
+ set_transient( $key, 'test', 60 * 10 );
+ $this->assertEquals( 'test', get_transient( $key ) );
+
+ // Make sure the timeout option returns false
+ $timeout = '_transient_timeout_' . $key;
+ $transient_option = '_transient_' . $key;
+ add_filter( 'option_' . $timeout, '__return_zero' );
+
+ // Mock an action for tracking action calls
+ $a = new MockAction();
+
+ // Add some actions to make sure options are deleted
+ add_action( 'delete_option', array( $a, 'action' ) );
+
+ // Act
+ get_transient( $key );
+
+ // Make sure delete option was called for both the transient and the timeout
+ $this->assertEquals( 2, $a->get_call_count() );
+
+ $expected = array(
+ array(
+ 'action' => 'action',
+ 'tag' => 'delete_option',
+ 'args' => array( $transient_option ),
+ ),
+ array(
+ 'action' => 'action',
+ 'tag' => 'delete_option',
+ 'args' => array( $timeout ),
+ ),
+ );
+ $this->assertEquals( $expected, $a->get_events() );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>