<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[32724] trunk/src/wp-admin: List tables: Use a class instead of inline styles for hidden columns.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32724">32724</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32724","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>helen</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-06-10 19:46:39 +0000 (Wed, 10 Jun 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>List tables: Use a class instead of inline styles for hidden columns.
fixes <a href="https://core.trac.wordpress.org/ticket/32608">#32608</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswplinkslisttablephp">trunk/src/wp-admin/includes/class-wp-links-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswplisttablephp">trunk/src/wp-admin/includes/class-wp-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmedialisttablephp">trunk/src/wp-admin/includes/class-wp-media-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmssiteslisttablephp">trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmsthemeslisttablephp">trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmsuserslisttablephp">trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppluginslisttablephp">trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswppostslisttablephp">trunk/src/wp-admin/includes/class-wp-posts-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludesclasswpuserslisttablephp">trunk/src/wp-admin/includes/class-wp-users-list-table.php</a></li>
<li><a href="#trunksrcwpadminjscommonjs">trunk/src/wp-admin/js/common.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswplinkslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-links-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-links-list-table.php 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/includes/class-wp-links-list-table.php 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -181,12 +181,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $classes .= ' has-row-actions column-primary';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
</del><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $column_name, $hidden ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = ' style="display:none;"';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $classes .= ' hidden';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attributes = "class='$classes'$style";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attributes = "class='$classes'";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'cb' === $column_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-list-table.php 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/includes/class-wp-list-table.php 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -946,12 +946,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $columns as $column_key => $column_display_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $class = array( 'manage-column', "column-$column_key" );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
- if ( in_array( $column_key, $hidden ) )
- $style = 'display:none;';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( in_array( $column_key, $hidden ) ) {
+ $class[] = 'hidden';
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = ' style="' . $style . '"';
-
</del><span class="cx" style="display: block; padding: 0 10px"> if ( 'cb' == $column_key )
</span><span class="cx" style="display: block; padding: 0 10px"> $class[] = 'check-column';
</span><span class="cx" style="display: block; padding: 0 10px"> elseif ( in_array( $column_key, array( 'posts', 'comments', 'links' ) ) )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -978,7 +976,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( !empty( $class ) )
</span><span class="cx" style="display: block; padding: 0 10px"> $class = "class='" . join( ' ', $class ) . "'";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "<th scope='col' $id $class $style>$column_display_name</th>";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo "<th scope='col' $id $class>$column_display_name</th>";
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1137,12 +1135,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $classes .= ' has-row-actions column-primary';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
</del><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $column_name, $hidden ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = ' style="display:none;"';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $classes .= ' hidden';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attributes = "class='$classes'$style";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attributes = "class='$classes'";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'cb' == $column_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<th scope="row" class="check-column">';
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmedialisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-media-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-media-list-table.php 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/includes/class-wp-media-list-table.php 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -340,12 +340,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $classes .= ' has-row-actions column-primary';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
</del><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $column_name, $hidden ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = ' style="display:none;"';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $classes .= ' hidden';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attributes = "class='$classes'$style";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attributes = "class='$classes'";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'cb' === $column_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmssiteslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -272,12 +272,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $classes .= ' has-row-actions column-primary';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
</del><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $column_name, $hidden ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = ' style="display:none;"';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $classes .= ' hidden';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attributes = "class='$classes'$style";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attributes = "class='$classes'";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'cb' === $column_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmsthemeslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -434,21 +434,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> list( $columns, $hidden, $sortable, $primary ) = $this->get_column_info();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $columns as $column_name => $column_display_name ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
- if ( in_array( $column_name, $hidden ) )
- $style = ' style="display:none;"';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $extra_classes = '';
+ if ( in_array( $column_name, $hidden ) ) {
+ $extra_classes .= ' hidden';
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> switch ( $column_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> case 'cb':
</span><span class="cx" style="display: block; padding: 0 10px"> echo "<th scope='row' class='check-column'>$checkbox</th>";
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> case 'name':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "<td class='theme-title column-primary'$style><strong>" . $theme->display('Name') . "</strong>";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo "<td class='theme-title column-primary{$extra_classes}'><strong>" . $theme->display('Name') . "</strong>";
</ins><span class="cx" style="display: block; padding: 0 10px"> echo $this->row_actions($actions, true);
</span><span class="cx" style="display: block; padding: 0 10px"> echo "</td>";
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> case 'description':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "<td class='column-description desc'$style>";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo "<td class='column-description desc{$extra_classes}'>";
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $theme->errors() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $pre = $status == 'broken' ? __( 'Broken Theme:' ) . ' ' : '';
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<p><strong class="attention">' . $pre . $theme->errors()->get_error_message() . '</strong></p>';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -487,7 +488,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> default:
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "<td class='$column_name column-$column_name'$style>";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo "<td class='$column_name column-$column_name{$extra_classes}'>";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Fires inside each custom column of the Multisite themes list table.
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmsuserslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -208,12 +208,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $classes .= ' column-primary';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
</del><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $column_name, $hidden ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = ' style="display:none;"';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $classes .= ' hidden';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attributes = "class='$classes'$style";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attributes = "class='$classes'";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'cb' === $column_name ){
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppluginslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-plugins-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/includes/class-wp-plugins-list-table.php 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -582,9 +582,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> list( $columns, $hidden, $sortable, $primary ) = $this->get_column_info();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $columns as $column_name => $column_display_name ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $extra_classes = '';
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $column_name, $hidden ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = ' style="display:none;"';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $extra_classes = ' hidden';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> switch ( $column_name ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -592,14 +592,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> echo "<th scope='row' class='check-column'>$checkbox</th>";
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> case 'name':
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "<td class='plugin-title column-primary'$style><strong>$plugin_name</strong>";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo "<td class='plugin-title column-primary'><strong>$plugin_name</strong>";
</ins><span class="cx" style="display: block; padding: 0 10px"> echo $this->row_actions( $actions, true );
</span><span class="cx" style="display: block; padding: 0 10px"> echo "</td>";
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> case 'description':
</span><span class="cx" style="display: block; padding: 0 10px"> $classes = 'column-description desc';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "<td class='$classes'$style>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo "<td class='$classes{$extra_classes}'>
</ins><span class="cx" style="display: block; padding: 0 10px"> <div class='plugin-description'>$description</div>
</span><span class="cx" style="display: block; padding: 0 10px"> <div class='$class second plugin-version-author-uri'>";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -651,7 +651,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> default:
</span><span class="cx" style="display: block; padding: 0 10px"> $classes = "$column_name column-$column_name$class";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "<td class='$classes'$style>";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo "<td class='$classes{$extra_classes}'>";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Fires inside each custom column of the Plugins list table.
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppostslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-posts-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -722,12 +722,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $classes .= ' page-title'; // Special addition for title column
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
</del><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $column_name, $hidden ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = ' style="display:none;"';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $classes .= ' hidden';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attributes = "class='$classes'$style";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attributes = "class='$classes'";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'cb' === $column_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpuserslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-users-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-users-list-table.php 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/includes/class-wp-users-list-table.php 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -415,12 +415,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $classes .= ' num'; // Special case for that column
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = '';
</del><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $column_name, $hidden ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $style = ' style="display:none;"';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $classes .= ' hidden';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attributes = "class='$classes'$style";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attributes = "class='$classes'";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'cb' === $column_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $r .= "<th scope='row' class='check-column'>$checkbox</th>";
</span></span></pre></div>
<a id="trunksrcwpadminjscommonjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/common.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/common.js 2015-06-10 19:30:22 UTC (rev 32723)
+++ trunk/src/wp-admin/js/common.js 2015-06-10 19:46:39 UTC (rev 32724)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -37,12 +37,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> checked : function(column) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('.column-' + column).show();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('.column-' + column).removeClass( 'hidden' );
</ins><span class="cx" style="display: block; padding: 0 10px"> this.colSpanChange(+1);
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> unchecked : function(column) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('.column-' + column).hide();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('.column-' + column).addClass( 'hidden' );
</ins><span class="cx" style="display: block; padding: 0 10px"> this.colSpanChange(-1);
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>