<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[32693] trunk/src/wp-admin: Text improvements for screen readers in list table paginations.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32693">32693</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32693","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>obenland</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-06-05 05:00:23 +0000 (Fri, 05 Jun 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Text improvements for screen readers in list table paginations.
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.
Props afercia, rianrietveld.
Fixes <a href="https://core.trac.wordpress.org/ticket/32028">#32028</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsslisttablescss">trunk/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#trunksrcwpadminincludesclasswplisttablephp">trunk/src/wp-admin/includes/class-wp-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsslisttablescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/list-tables.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/list-tables.css 2015-06-04 17:28:07 UTC (rev 32692)
+++ trunk/src/wp-admin/css/list-tables.css 2015-06-05 05:00:23 UTC (rev 32693)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -544,7 +544,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> cursor: default;
</span><span class="cx" style="display: block; padding: 0 10px"> height: 30px;
</span><span class="cx" style="display: block; padding: 0 10px"> color: #555;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- line-height: 30px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ line-height: 2.5;
</ins><span class="cx" style="display: block; padding: 0 10px"> font-size: 12px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -563,8 +563,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0 10px 3px;
</span><span class="cx" style="display: block; padding: 0 10px"> background: #eee;
</span><span class="cx" style="display: block; padding: 0 10px"> background: rgba( 0, 0, 0, 0.05 );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ display: inline-block;
</ins><span class="cx" style="display: block; padding: 0 10px"> font-size: 16px;
</span><span class="cx" style="display: block; padding: 0 10px"> font-weight: normal;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ line-height: 1.3333;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .tablenav .tablenav-pages a:hover,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1614,6 +1616,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .tablenav-pages .pagination-links a {
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 8px 20px 11px;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ display: inline;
</ins><span class="cx" style="display: block; padding: 0 10px"> font-size: 18px;
</span><span class="cx" style="display: block; padding: 0 10px"> background: rgba(0, 0, 0, 0.05);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-list-table.php 2015-06-04 17:28:07 UTC (rev 32692)
+++ trunk/src/wp-admin/includes/class-wp-list-table.php 2015-06-05 05:00:23 UTC (rev 32693)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -701,6 +701,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $page_links = array();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $total_pages_before = '<span class="paging-input">';
+ $total_pages_after = '</span>';
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $disable_first = $disable_last = '';
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $current == 1 ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $disable_first = ' disabled';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -708,44 +711,44 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $current == $total_pages ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $disable_last = ' disabled';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $page_links[] = sprintf( "<a class='%s' title='%s' href='%s'>%s</a>",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $page_links[] = sprintf( "<a class='%s' href='%s'><span class='screen-reader-text'>%s</span><span aria-hidden='true'>%s</span></a>",
</ins><span class="cx" style="display: block; padding: 0 10px"> 'first-page' . $disable_first,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr__( 'Go to the first page' ),
</del><span class="cx" style="display: block; padding: 0 10px"> esc_url( remove_query_arg( 'paged', $current_url ) ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ __( 'First page' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> '«'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $page_links[] = sprintf( "<a class='%s' title='%s' href='%s'>%s</a>",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $page_links[] = sprintf( "<a class='%s' href='%s'><span class='screen-reader-text'>%s</span><span aria-hidden='true'>%s</span></a>",
</ins><span class="cx" style="display: block; padding: 0 10px"> 'prev-page' . $disable_first,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr__( 'Go to the previous page' ),
</del><span class="cx" style="display: block; padding: 0 10px"> esc_url( add_query_arg( 'paged', max( 1, $current-1 ), $current_url ) ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ __( 'Previous page' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> '‹'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'bottom' == $which ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $html_current_page = $current;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html_current_page = $current;
+ $total_pages_before = '<span id="table-paging" class="paging-input">';
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $html_current_page = sprintf( "%s<input class='current-page' id='current-page-selector' title='%s' type='text' name='paged' value='%s' size='%d' />",
- '<label for="current-page-selector" class="screen-reader-text">' . __( 'Select Page' ) . '</label>',
- esc_attr__( 'Current page' ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $html_current_page = sprintf( "%s<input class='current-page' id='current-page-selector' type='text' name='paged' value='%s' size='%d' aria-describedby='table-paging' />",
+ '<label for="current-page-selector" class="screen-reader-text">' . __( 'Current Page' ) . '</label>',
</ins><span class="cx" style="display: block; padding: 0 10px"> $current,
</span><span class="cx" style="display: block; padding: 0 10px"> strlen( $total_pages )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> $html_total_pages = sprintf( "<span class='total-pages'>%s</span>", number_format_i18n( $total_pages ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $page_links[] = '<span class="paging-input">' . sprintf( _x( '%1$s of %2$s', 'paging' ), $html_current_page, $html_total_pages ) . '</span>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $page_links[] = $total_pages_before . sprintf( _x( '%1$s of %2$s', 'paging' ), $html_current_page, $html_total_pages ) . $total_pages_after;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $page_links[] = sprintf( "<a class='%s' title='%s' href='%s'>%s</a>",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $page_links[] = sprintf( "<a class='%s' href='%s'><span class='screen-reader-text'>%s</span><span aria-hidden='true'>%s</span></a>",
</ins><span class="cx" style="display: block; padding: 0 10px"> 'next-page' . $disable_last,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr__( 'Go to the next page' ),
</del><span class="cx" style="display: block; padding: 0 10px"> esc_url( add_query_arg( 'paged', min( $total_pages, $current+1 ), $current_url ) ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ __( 'Next page' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> '›'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $page_links[] = sprintf( "<a class='%s' title='%s' href='%s'>%s</a>",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $page_links[] = sprintf( "<a class='%s' href='%s'><span class='screen-reader-text'>%s</span><span aria-hidden='true'>%s</span></a>",
</ins><span class="cx" style="display: block; padding: 0 10px"> 'last-page' . $disable_last,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- esc_attr__( 'Go to the last page' ),
</del><span class="cx" style="display: block; padding: 0 10px"> esc_url( add_query_arg( 'paged', $total_pages, $current_url ) ),
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ __( 'Last page' ),
</ins><span class="cx" style="display: block; padding: 0 10px"> '»'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>