<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[32687] trunk/src/wp-admin: Media: move the thumbnail into the title column in list view.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32687">32687</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32687","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>helen</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-06-03 15:12:19 +0000 (Wed, 03 Jun 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: move the thumbnail into the title column in list view.
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.
props bradt for the initial patch.
fixes <a href="https://core.trac.wordpress.org/ticket/29993">#29993</a> and <a href="https://core.trac.wordpress.org/ticket/32255">#32255</a>. see <a href="https://core.trac.wordpress.org/ticket/32509">#32509</a> and <a href="https://core.trac.wordpress.org/ticket/32395">#32395</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsslisttablescss">trunk/src/wp-admin/css/list-tables.css</a></li>
<li><a href="#trunksrcwpadminincludesclasswpmedialisttablephp">trunk/src/wp-admin/includes/class-wp-media-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsslisttablescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/list-tables.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/list-tables.css 2015-06-03 15:07:22 UTC (rev 32686)
+++ trunk/src/wp-admin/css/list-tables.css 2015-06-03 15:12:19 UTC (rev 32687)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -296,10 +296,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> float: left;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.fixed .column-icon {
- width: 80px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* Media file column */
+table.media .column-title {
+ position: relative;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+table.media .column-title .media-icon {
+ position: absolute;
+ top: 8px; /* match cell padding */
+ left: 10px; /* match cell padding */
+}
+
+table.media .column-title .media-info,
+table.media .column-title .row-actions {
+ margin-left: 70px; /* 60px image + margin */
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* @todo: pick a consistent list table selector */
</span><span class="cx" style="display: block; padding: 0 10px"> .wp-list-table a {
</span><span class="cx" style="display: block; padding: 0 10px"> -webkit-transition: none;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1622,6 +1634,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .column-tags,
</span><span class="cx" style="display: block; padding: 0 10px"> .tags .column-description,
</span><span class="cx" style="display: block; padding: 0 10px"> .media .column-parent,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .media .column-comments,
</ins><span class="cx" style="display: block; padding: 0 10px"> .users .column-email,
</span><span class="cx" style="display: block; padding: 0 10px"> .users .column-name,
</span><span class="cx" style="display: block; padding: 0 10px"> .sites .column-registered,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1650,6 +1663,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> word-wrap: normal;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /* Media */
+ .media .column-title {
+ width: auto;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* Quick Edit and Bulk Edit */
</span><span class="cx" style="display: block; padding: 0 10px"> #wpbody-content .quick-edit-row-post .inline-edit-col-left,
</span><span class="cx" style="display: block; padding: 0 10px"> #wpbody-content .quick-edit-row-post .inline-edit-col-right,
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswpmedialisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-media-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-media-list-table.php 2015-06-03 15:07:22 UTC (rev 32686)
+++ trunk/src/wp-admin/includes/class-wp-media-list-table.php 2015-06-03 15:12:19 UTC (rev 32687)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -247,7 +247,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public function get_columns() {
</span><span class="cx" style="display: block; padding: 0 10px"> $posts_columns = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $posts_columns['cb'] = '<input type="checkbox" />';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $posts_columns['icon'] = '';
</del><span class="cx" style="display: block; padding: 0 10px"> /* translators: column name */
</span><span class="cx" style="display: block; padding: 0 10px"> $posts_columns['title'] = _x( 'File', 'column name' );
</span><span class="cx" style="display: block; padding: 0 10px"> $posts_columns['author'] = __( 'Author' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -361,10 +360,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> echo "<td $attributes>";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> switch ( $column_name ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'icon':
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ case 'title':
</ins><span class="cx" style="display: block; padding: 0 10px"> list( $mime ) = explode( '/', $post->post_mime_type );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $attributes = 'class="column-icon media-icon ' . $mime . '-icon"' . $style;
</del><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo "<div class='media-icon {$mime}-icon'>";
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $thumb = wp_get_attachment_image( $post->ID, array( 80, 60 ), true ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $this->is_trash || ! $user_can_edit ) {
</span><span class="cx" style="display: block; padding: 0 10px"> echo $thumb;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -374,9 +374,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </a><?php
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- break;
</del><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'title':
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo '</div><div class="media-info">';
</ins><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <strong>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php if ( $this->is_trash || ! $user_can_edit ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -388,6 +387,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php }
</span><span class="cx" style="display: block; padding: 0 10px"> _media_states( $post ); ?></strong>
</span><span class="cx" style="display: block; padding: 0 10px"> <p class="filename"><?php echo wp_basename( $post->guid ); ?></p>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ </div>
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>