<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[32657] trunk/src/wp-includes: After [32656], add `@access` annotations to methods that have no doc block in `wp-includes/*`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32657">32657</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32657","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>wonderboymusic</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-05-29 21:36:38 +0000 (Fri, 29 May 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>After <a href="https://core.trac.wordpress.org/changeset/32656">[32656]</a>, add `@access` annotations to methods that have no doc block in `wp-includes/*`.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.
See <a href="https://core.trac.wordpress.org/ticket/32444">#32444</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesclassfeedphp">trunk/src/wp-includes/class-feed.php</a></li>
<li><a href="#trunksrcwpincludesclasswpadminbarphp">trunk/src/wp-includes/class-wp-admin-bar.php</a></li>
<li><a href="#trunksrcwpincludesclasswpcustomizecontrolphp">trunk/src/wp-includes/class-wp-customize-control.php</a></li>
<li><a href="#trunksrcwpincludesclasswpxmlrpcserverphp">trunk/src/wp-includes/class-wp-xmlrpc-server.php</a></li>
<li><a href="#trunksrcwpincludesclasswpscriptsphp">trunk/src/wp-includes/class.wp-scripts.php</a></li>
<li><a href="#trunksrcwpincludesclasswpstylesphp">trunk/src/wp-includes/class.wp-styles.php</a></li>
<li><a href="#trunksrcwpincludesdefaultwidgetsphp">trunk/src/wp-includes/default-widgets.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesclassfeedphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-feed.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-feed.php 2015-05-29 21:31:56 UTC (rev 32656)
+++ trunk/src/wp-includes/class-feed.php 2015-05-29 21:36:38 UTC (rev 32657)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -36,6 +36,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->lifetime = apply_filters( 'wp_feed_cache_transient_lifetime', $lifetime, $filename);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function save($data) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $data instanceof SimplePie ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $data = $data->data;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -46,18 +49,30 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function load() {
</span><span class="cx" style="display: block; padding: 0 10px"> return get_transient($this->name);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function mtime() {
</span><span class="cx" style="display: block; padding: 0 10px"> return get_transient($this->mod_name);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function touch() {
</span><span class="cx" style="display: block; padding: 0 10px"> return set_transient($this->mod_name, time(), $this->lifetime);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function unlink() {
</span><span class="cx" style="display: block; padding: 0 10px"> delete_transient($this->name);
</span><span class="cx" style="display: block; padding: 0 10px"> delete_transient($this->mod_name);
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpadminbarphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-admin-bar.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-admin-bar.php 2015-05-29 21:31:56 UTC (rev 32656)
+++ trunk/src/wp-includes/class-wp-admin-bar.php 2015-05-29 21:36:38 UTC (rev 32657)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -27,6 +27,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function initialize() {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->user = new stdClass;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -245,6 +248,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $this->nodes[ $id ] );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function render() {
</span><span class="cx" style="display: block; padding: 0 10px"> $root = $this->_bind();
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $root )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -536,6 +542,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->_render_item( $node );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function add_menus() {
</span><span class="cx" style="display: block; padding: 0 10px"> // User related, aligned right.
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'admin_bar_menu', 'wp_admin_bar_my_account_menu', 0 );
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpcustomizecontrolphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-customize-control.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-customize-control.php 2015-05-29 21:31:56 UTC (rev 32656)
+++ trunk/src/wp-includes/class-wp-customize-control.php 2015-05-29 21:36:38 UTC (rev 32657)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1025,6 +1025,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function enqueue() {
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_media();
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script( 'customize-views' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1066,6 +1069,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->uploaded_headers = $custom_image_header->get_uploaded_header_images();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function print_header_image_template() {
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <script type="text/template" id="tmpl-header-choice">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1142,6 +1148,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function render_content() {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->print_header_image_template();
</span><span class="cx" style="display: block; padding: 0 10px"> $visibility = $this->get_current_image_src() ? '' : ' style="display:none" ';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1316,6 +1325,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function render_content() {
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="button-secondary add-new-widget" tabindex="0">
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpxmlrpcserverphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-xmlrpc-server.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-xmlrpc-server.php 2015-05-29 21:31:56 UTC (rev 32656)
+++ trunk/src/wp-includes/class-wp-xmlrpc-server.php 2015-05-29 21:36:38 UTC (rev 32657)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -179,6 +179,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function serve_request() {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->IXR_Server($this->methods);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpscriptsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class.wp-scripts.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class.wp-scripts.php 2015-05-29 21:31:56 UTC (rev 32656)
+++ trunk/src/wp-includes/class.wp-scripts.php 2015-05-29 21:36:38 UTC (rev 32657)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -35,6 +35,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'init', array( $this, 'init' ), 0 );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function init() {
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Fires when the WP_Scripts instance is initialized.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -313,6 +316,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function reset() {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->do_concat = false;
</span><span class="cx" style="display: block; padding: 0 10px"> $this->print_code = '';
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpstylesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class.wp-styles.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class.wp-styles.php 2015-05-29 21:31:56 UTC (rev 32656)
+++ trunk/src/wp-includes/class.wp-styles.php 2015-05-29 21:36:38 UTC (rev 32657)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -242,6 +242,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return $this->done;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function reset() {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->do_concat = false;
</span><span class="cx" style="display: block; padding: 0 10px"> $this->concat = '';
</span></span></pre></div>
<a id="trunksrcwpincludesdefaultwidgetsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/default-widgets.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/default-widgets.php 2015-05-29 21:31:56 UTC (rev 32656)
+++ trunk/src/wp-includes/default-widgets.php 2015-05-29 21:36:38 UTC (rev 32657)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -888,6 +888,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return $instance;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function flush_widget_cache() {
</span><span class="cx" style="display: block; padding: 0 10px"> wp_cache_delete('widget_recent_posts', 'widget');
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -932,6 +935,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'transition_comment_status', array($this, 'flush_widget_cache') );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function recent_comments_style() {
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Filter the Recent Comments default widget styles.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -949,6 +955,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @access public
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function flush_widget_cache() {
</span><span class="cx" style="display: block; padding: 0 10px"> wp_cache_delete('widget_recent_comments', 'widget');
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1466,6 +1475,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </select></p><?php
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @param array $instance
+ * @return string
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function _get_current_taxonomy($instance) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( !empty($instance['taxonomy']) && taxonomy_exists($instance['taxonomy']) )
</span><span class="cx" style="display: block; padding: 0 10px"> return $instance['taxonomy'];
</span></span></pre>
</div>
</div>
</body>
</html>