<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[32604] trunk/tests/phpunit/tests: Improve unit tests for `wp_unique_post_slug()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32604">32604</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32604","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-05-26 18:07:17 +0000 (Tue, 26 May 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Improve unit tests for `wp_unique_post_slug()`.
See <a href="https://core.trac.wordpress.org/ticket/5305">#5305</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestspostphp">trunk/tests/phpunit/tests/post.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestspostwpUniquePostSlugphp">trunk/tests/phpunit/tests/post/wpUniquePostSlug.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestspostwpUniquePostSlugphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/post/wpUniquePostSlug.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/post/wpUniquePostSlug.php (rev 0)
+++ trunk/tests/phpunit/tests/post/wpUniquePostSlug.php 2015-05-26 18:07:17 UTC (rev 32604)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,167 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * @group post
+ */
+class Tests_Post_WpUniquePostSlug extends WP_UnitTestCase {
+ /**
+ * @ticket 21013
+ */
+ public function test_non_latin_slugs() {
+ $author_id = $this->factory->user->create( array( 'role' => 'editor' ) );
+
+ $inputs = array(
+ 'Αρνάκι άσπρο και παχύ της μάνας του καμάρι, και άλλα τραγούδια',
+ 'Предлагаем супер металлообрабатывающее оборудование',
+ );
+
+ $outputs = array(
+ 'αρνάκι-άσπρο-και-παχύ-της-μάνας-του-κα-2',
+ 'предлагаем-супер-металлообрабатыва-2',
+ );
+
+ foreach ( $inputs as $k => $post_title ) {
+ for ( $i = 0; $i < 2; $i++ ) {
+ $post = array(
+ 'post_author' => $author_id,
+ 'post_status' => 'publish',
+ 'post_content' => rand_str(),
+ 'post_title' => $post_title,
+ );
+
+ $id = $this->post_ids[] = wp_insert_post( $post );
+ }
+
+ $post = get_post( $id );
+ $this->assertEquals( $outputs[$k], urldecode( $post->post_name ) );
+ }
+ }
+
+ /**
+ * @ticket 18962
+ */
+ public function test_with_multiple_hierarchies() {
+ register_post_type( 'post-type-1', array( 'hierarchical' => true ) );
+ register_post_type( 'post-type-2', array( 'hierarchical' => true ) );
+
+ $args = array(
+ 'post_type' => 'post-type-1',
+ 'post_name' => 'some-slug',
+ 'post_status' => 'publish',
+ );
+ $one = $this->factory->post->create( $args );
+ $args['post_type'] = 'post-type-2';
+ $two = $this->factory->post->create( $args );
+
+ $this->assertEquals( 'some-slug', get_post( $one )->post_name );
+ $this->assertEquals( 'some-slug', get_post( $two )->post_name );
+
+ $this->assertEquals( 'some-other-slug', wp_unique_post_slug( 'some-other-slug', $one, 'publish', 'post-type-1', 0 ) );
+ $this->assertEquals( 'some-other-slug', wp_unique_post_slug( 'some-other-slug', $one, 'publish', 'post-type-2', 0 ) );
+
+ _unregister_post_type( 'post-type-1' );
+ _unregister_post_type( 'post-type-2' );
+ }
+
+ /**
+ * @ticket 30339
+ */
+ public function test_with_hierarchy() {
+ register_post_type( 'post-type-1', array( 'hierarchical' => true ) );
+
+ $args = array(
+ 'post_type' => 'post-type-1',
+ 'post_name' => 'some-slug',
+ 'post_status' => 'publish',
+ );
+ $one = $this->factory->post->create( $args );
+ $args['post_name'] = 'some-slug-2';
+ $two = $this->factory->post->create( $args );
+
+ $this->assertEquals( 'some-slug', get_post( $one )->post_name );
+ $this->assertEquals( 'some-slug-2', get_post( $two )->post_name );
+
+ $this->assertEquals( 'some-slug-3', wp_unique_post_slug( 'some-slug', 0, 'publish', 'post-type-1', 0 ) );
+
+ _unregister_post_type( 'post-type-1' );
+ }
+
+ /**
+ * @ticket 18962
+ */
+ function test_wp_unique_post_slug_with_hierarchy_and_attachments() {
+ register_post_type( 'post-type-1', array( 'hierarchical' => true ) );
+
+ $args = array(
+ 'post_type' => 'post-type-1',
+ 'post_name' => 'some-slug',
+ 'post_status' => 'publish',
+ );
+ $one = $this->factory->post->create( $args );
+
+ $args = array(
+ 'post_mime_type' => 'image/jpeg',
+ 'post_type' => 'attachment',
+ 'post_name' => 'image'
+ );
+ $attachment = $this->factory->attachment->create_object( 'image.jpg', $one, $args );
+
+ $args = array(
+ 'post_type' => 'post-type-1',
+ 'post_name' => 'image',
+ 'post_status' => 'publish',
+ 'post_parent' => $one
+ );
+ $two = $this->factory->post->create( $args );
+
+ $this->assertEquals( 'some-slug', get_post( $one )->post_name );
+ $this->assertEquals( 'image', get_post( $attachment )->post_name );
+ $this->assertEquals( 'image-2', get_post( $two )->post_name );
+
+ // 'image' can be a child of image-2
+ $this->assertEquals( 'image', wp_unique_post_slug( 'image', 0, 'publish', 'post-type-1', $two ) );
+
+ _unregister_post_type( 'post-type-1' );
+ }
+
+ /**
+ * @dataProvider whitelist_post_statuses
+ */
+ public function test_whitelisted_post_statuses_should_not_be_forced_to_be_unique( $status ) {
+ $p1 = $this->factory->post->create( array(
+ 'post_type' => 'post',
+ 'post_name' => 'foo',
+ ) );
+
+ $p2 = $this->factory->post->create( array(
+ 'post_type' => 'post',
+ ) );
+
+ $actual = wp_unique_post_slug( 'foo', $p2, $status, 'post', 0 );
+
+ $this->assertSame( 'foo', $actual );
+ }
+
+ public function whitelist_post_statuses() {
+ return array(
+ array( 'draft' ),
+ array( 'pending' ),
+ array( 'auto-draft' ),
+ );
+ }
+
+ public function test_revisions_should_not_be_forced_to_be_unique() {
+ $p1 = $this->factory->post->create( array(
+ 'post_type' => 'post',
+ 'post_name' => 'foo',
+ ) );
+
+ $p2 = $this->factory->post->create( array(
+ 'post_type' => 'post',
+ ) );
+
+ $actual = wp_unique_post_slug( 'foo', $p2, 'inherit', 'revision', 0 );
+
+ $this->assertSame( 'foo', $actual );
+ }
+}
</ins></span></pre></div>
<a id="trunktestsphpunittestspostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/post.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/post.php 2015-05-26 18:05:22 UTC (rev 32603)
+++ trunk/tests/phpunit/tests/post.php 2015-05-26 18:07:17 UTC (rev 32604)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -470,37 +470,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @ticket 21013
- */
- function test_wp_unique_post_slug_with_non_latin_slugs() {
- $inputs = array(
- 'Αρνάκι άσπρο και παχύ της μάνας του καμάρι, και άλλα τραγούδια',
- 'Предлагаем супер металлообрабатывающее оборудование',
- );
-
- $outputs = array(
- 'αρνάκι-άσπρο-και-παχύ-της-μάνας-του-κα-2',
- 'предлагаем-супер-металлообрабатыва-2',
- );
-
- foreach ( $inputs as $k => $post_title ) {
- for ( $i = 0; $i < 2; $i++ ) {
- $post = array(
- 'post_author' => $this->author_id,
- 'post_status' => 'publish',
- 'post_content' => rand_str(),
- 'post_title' => $post_title,
- );
-
- $id = $this->post_ids[] = wp_insert_post( $post );
- }
-
- $post = get_post( $id );
- $this->assertEquals( $outputs[$k], urldecode( $post->post_name ) );
- }
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * @ticket 15665
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function test_get_page_by_path_priority() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -946,93 +915,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @ticket 18962
- */
- function test_wp_unique_post_slug_with_multiple_hierarchies() {
- register_post_type( 'post-type-1', array( 'hierarchical' => true ) );
- register_post_type( 'post-type-2', array( 'hierarchical' => true ) );
-
- $args = array(
- 'post_type' => 'post-type-1',
- 'post_name' => 'some-slug',
- 'post_status' => 'publish',
- );
- $one = $this->factory->post->create( $args );
- $args['post_type'] = 'post-type-2';
- $two = $this->factory->post->create( $args );
-
- $this->assertEquals( 'some-slug', get_post( $one )->post_name );
- $this->assertEquals( 'some-slug', get_post( $two )->post_name );
-
- $this->assertEquals( 'some-other-slug', wp_unique_post_slug( 'some-other-slug', $one, 'publish', 'post-type-1', 0 ) );
- $this->assertEquals( 'some-other-slug', wp_unique_post_slug( 'some-other-slug', $one, 'publish', 'post-type-2', 0 ) );
-
- _unregister_post_type( 'post-type-1' );
- _unregister_post_type( 'post-type-2' );
- }
-
- /**
- * @ticket 30339
- */
- function test_wp_unique_post_slug_with_hierarchy() {
- register_post_type( 'post-type-1', array( 'hierarchical' => true ) );
-
- $args = array(
- 'post_type' => 'post-type-1',
- 'post_name' => 'some-slug',
- 'post_status' => 'publish',
- );
- $one = $this->factory->post->create( $args );
- $args['post_name'] = 'some-slug-2';
- $two = $this->factory->post->create( $args );
-
- $this->assertEquals( 'some-slug', get_post( $one )->post_name );
- $this->assertEquals( 'some-slug-2', get_post( $two )->post_name );
-
- $this->assertEquals( 'some-slug-3', wp_unique_post_slug( 'some-slug', 0, 'publish', 'post-type-1', 0 ) );
-
- _unregister_post_type( 'post-type-1' );
- }
-
- /**
- * @ticket 18962
- */
- function test_wp_unique_post_slug_with_hierarchy_and_attachments() {
- register_post_type( 'post-type-1', array( 'hierarchical' => true ) );
-
- $args = array(
- 'post_type' => 'post-type-1',
- 'post_name' => 'some-slug',
- 'post_status' => 'publish',
- );
- $one = $this->factory->post->create( $args );
-
- $args = array(
- 'post_mime_type' => 'image/jpeg',
- 'post_type' => 'attachment',
- 'post_name' => 'image'
- );
- $attachment = $this->factory->attachment->create_object( 'image.jpg', $one, $args );
-
- $args = array(
- 'post_type' => 'post-type-1',
- 'post_name' => 'image',
- 'post_status' => 'publish',
- 'post_parent' => $one
- );
- $two = $this->factory->post->create( $args );
-
- $this->assertEquals( 'some-slug', get_post( $one )->post_name );
- $this->assertEquals( 'image', get_post( $attachment )->post_name );
- $this->assertEquals( 'image-2', get_post( $two )->post_name );
-
- // 'image' can be a child of image-2
- $this->assertEquals( 'image', wp_unique_post_slug( 'image', 0, 'publish', 'post-type-1', $two ) );
-
- _unregister_post_type( 'post-type-1' );
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * @ticket 21212
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function test_utf8mb3_post_saves_with_emoji() {
</span></span></pre>
</div>
</div>
</body>
</html>