<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[32506] trunk/src: Media: Visually align upload errors with other admin notices.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32506">32506</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32506","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>helen</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-05-15 16:18:50 +0000 (Fri, 15 May 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: Visually align upload errors with other admin notices.
props sagarjadhav.
fixes <a href="https://core.trac.wordpress.org/ticket/31874">#31874</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincssmediacss">trunk/src/wp-admin/css/media.css</a></li>
<li><a href="#trunksrcwpincludescssmediaviewscss">trunk/src/wp-includes/css/media-views.css</a></li>
<li><a href="#trunksrcwpincludesmediatemplatephp">trunk/src/wp-includes/media-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincssmediacss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/media.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/media.css 2015-05-14 23:49:44 UTC (rev 32505)
+++ trunk/src/wp-admin/css/media.css 2015-05-15 16:18:50 UTC (rev 32506)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -459,8 +459,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> width: auto;
</span><span class="cx" style="display: block; padding: 0 10px"> margin-bottom: 16px;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0 16px;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- border: 1px solid #c00;
- background-color: #feebe8;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ border-left: 4px solid #dd3d36;
+ box-shadow: 0 1px 1px 0 rgba(0, 0, 0, 0.1);
+ background-color: #fff;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .upload-php .mode-grid .hide-sidebar .media-sidebar {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -474,27 +475,28 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .upload-php .mode-grid .media-sidebar .upload-error {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin: 20px 0;
- padding: 0;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ margin: 12px 0;
+ padding: 4px 0 0;
</ins><span class="cx" style="display: block; padding: 0 10px"> border: none;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ box-shadow: none;
</ins><span class="cx" style="display: block; padding: 0 10px"> background: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .upload-php .mode-grid .media-sidebar .media-uploader-status .upload-dismiss-errors {
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 0;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- top: -12px;
- right: -10px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ top: 0;
+ right: -6px;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .upload-php .mode-grid .media-sidebar .media-uploader-status .upload-dismiss-errors:before {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- content: "\f158";
- font: normal 20px/1 dashicons;
- color: #666;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ content: "\f153";
+ font: normal 16px/1 dashicons;
+ color: #bbb;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .upload-php .mode-grid .media-sidebar .media-uploader-status .upload-dismiss-errors:focus:before,
</span><span class="cx" style="display: block; padding: 0 10px"> .upload-php .mode-grid .media-sidebar .media-uploader-status .upload-dismiss-errors:hover:before {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- color: #00a0d2;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ color: #c00;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .upload-php .mode-grid .media-sidebar .media-uploader-status.errors h3 {
</span></span></pre></div>
<a id="trunksrcwpincludescssmediaviewscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/css/media-views.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/css/media-views.css 2015-05-14 23:49:44 UTC (rev 32505)
+++ trunk/src/wp-includes/css/media-views.css 2015-05-15 16:18:50 UTC (rev 32506)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1174,10 +1174,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> max-width: 400px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.media-sidebar .media-uploader-status {
- border-bottom: 1px solid #dfdfdf;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .uploader-inline .media-uploader-status h3 {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1221,31 +1217,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .upload-errors .upload-error {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin: 8px auto 0 auto;
- padding: 8px;
- border: 1px #c00 solid;
- background: #ffebe8;
- -webkit-border-radius: 3px;
- border-radius: 3px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ padding: 12px;
+ margin-bottom: 12px;
+ background: #fff;
+ border-left: 4px solid #dd3d36;
+ box-shadow: 0 1px 1px 0 rgba(0, 0, 0, 0.1);
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.upload-errors .upload-error-label {
- padding: 2px 4px;
- margin-right: 8px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.upload-errors .upload-error-filename {
</ins><span class="cx" style="display: block; padding: 0 10px"> font-weight: bold;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- color: #fff;
- background: #e00;
- background-image: -webkit-gradient(linear, left top, left bottom, from(#e00), to(#a00));
- background-image: -webkit-linear-gradient(top, #e00, #a00);
- background-image: linear-gradient(to bottom, #e00, #a00);
- -webkit-border-radius: 3px;
- border-radius: 3px;
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .upload-errors .upload-error-message {
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> padding-top: 8px;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- color: #b44;
</del><span class="cx" style="display: block; padding: 0 10px"> word-wrap: break-word;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesmediatemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/media-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/media-template.php 2015-05-14 23:49:44 UTC (rev 32505)
+++ trunk/src/wp-includes/media-template.php 2015-05-15 16:18:50 UTC (rev 32506)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -273,7 +273,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </script>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <script type="text/html" id="tmpl-uploader-status-error">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <span class="upload-error-label"><?php _e('Error'); ?></span>
</del><span class="cx" style="display: block; padding: 0 10px"> <span class="upload-error-filename">{{{ data.filename }}}</span>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="upload-error-message">{{ data.message }}</span>
</span><span class="cx" style="display: block; padding: 0 10px"> </script>
</span></span></pre>
</div>
</div>
</body>
</html>