<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[32480] trunk/src/wp-admin: Widgets:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32480">32480</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32480","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>azaozz</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-05-10 00:31:47 +0000 (Sun, 10 May 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Widgets:
- Fix dragging to the bottom of the screen.
- Fix hiding of the dragged widget when dragging over a closed sidebar.
- Fix the admin menu position and scrolling when all widget containers are folded.
Fixes <a href="https://core.trac.wordpress.org/ticket/32094">#32094</a> for trunk.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsswidgetscss">trunk/src/wp-admin/css/widgets.css</a></li>
<li><a href="#trunksrcwpadminjscommonjs">trunk/src/wp-admin/js/common.js</a></li>
<li><a href="#trunksrcwpadminjswidgetsjs">trunk/src/wp-admin/js/widgets.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsswidgetscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/widgets.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/widgets.css 2015-05-10 00:05:30 UTC (rev 32479)
+++ trunk/src/wp-admin/css/widgets.css 2015-05-10 00:31:47 UTC (rev 32480)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -350,6 +350,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.js .widgets-holder-wrap.closed .widget.ui-sortable-helper {
+ display: block;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* Hide Widget Settings by Default */
</span><span class="cx" style="display: block; padding: 0 10px"> .widget-inside,
</span><span class="cx" style="display: block; padding: 0 10px"> .widget-description {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -506,6 +510,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> cursor: pointer;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#available-widgets .widget.ui-draggable-dragging .widget-top {
+ cursor: move;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* =Media Queries
</span><span class="cx" style="display: block; padding: 0 10px"> -------------------------------------------------------------- */
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminjscommonjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/common.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/common.js 2015-05-10 00:05:30 UTC (rev 32479)
+++ trunk/src/wp-admin/js/common.js 2015-05-10 00:31:47 UTC (rev 32480)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -860,7 +860,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> window.wpResponsive.init();
</span><span class="cx" style="display: block; padding: 0 10px"> setPinMenu();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $document.on( 'wp-window-resized.pin-menu postboxes-columnchange.pin-menu postbox-toggled.pin-menu wp-collapse-menu.pin-menu wp-scroll-start.pin-menu', setPinMenu );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $document.on( 'wp-pin-menu wp-window-resized.pin-menu postboxes-columnchange.pin-menu postbox-toggled.pin-menu wp-collapse-menu.pin-menu wp-scroll-start.pin-menu', setPinMenu );
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Fire a custom jQuery event at the end of window resize
</span></span></pre></div>
<a id="trunksrcwpadminjswidgetsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/widgets.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/widgets.js 2015-05-10 00:05:30 UTC (rev 32479)
+++ trunk/src/wp-admin/js/widgets.js 2015-05-10 00:31:47 UTC (rev 32480)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,6 +1,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /*global ajaxurl, isRtl */
</span><span class="cx" style="display: block; padding: 0 10px"> var wpWidgets;
</span><span class="cx" style="display: block; padding: 0 10px"> (function($) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var $document = $( document );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wpWidgets = {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -22,10 +23,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $wrap.addClass('closed');
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $document.triggerHandler( 'wp-pin-menu' );
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $('#widgets-left .sidebar-name').click( function() {
</span><span class="cx" style="display: block; padding: 0 10px"> $(this).closest('.widgets-holder-wrap').toggleClass('closed');
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $document.triggerHandler( 'wp-pin-menu' );
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $(document.body).bind('click.widgets-toggle', function(e) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -89,7 +93,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> distance: 2,
</span><span class="cx" style="display: block; padding: 0 10px"> helper: 'clone',
</span><span class="cx" style="display: block; padding: 0 10px"> zIndex: 100,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- containment: 'document',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ containment: '#wpwrap',
</ins><span class="cx" style="display: block; padding: 0 10px"> start: function( event, ui ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var chooser = $(this).find('.widgets-chooser');
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -119,7 +123,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> handle: '> .widget-top > .widget-title',
</span><span class="cx" style="display: block; padding: 0 10px"> cursor: 'move',
</span><span class="cx" style="display: block; padding: 0 10px"> distance: 2,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- containment: 'document',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ containment: '#wpwrap',
</ins><span class="cx" style="display: block; padding: 0 10px"> start: function( event, ui ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var height, $this = $(this),
</span><span class="cx" style="display: block; padding: 0 10px"> $wrap = $this.parent(),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -174,7 +178,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wpWidgets.save( $widget, 0, 0, 1 );
</span><span class="cx" style="display: block; padding: 0 10px"> $widget.find('input.add_new').val('');
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( document ).trigger( 'widget-added', [ $widget ] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $document.trigger( 'widget-added', [ $widget ] );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $sidebar = $widget.parent();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -381,7 +385,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( r && r.length > 2 ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $( 'div.widget-content', widget ).html( r );
</span><span class="cx" style="display: block; padding: 0 10px"> wpWidgets.appendTitle( widget );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( document ).trigger( 'widget-updated', [ widget ] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $document.trigger( 'widget-updated', [ widget ] );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> if ( order ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -446,7 +450,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // No longer "new" widget
</span><span class="cx" style="display: block; padding: 0 10px"> widget.find( 'input.add_new' ).val('');
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( document ).trigger( 'widget-added', [ widget ] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $document.trigger( 'widget-added', [ widget ] );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*
</span><span class="cx" style="display: block; padding: 0 10px"> * Check if any part of the sidebar is visible in the viewport. If it is, don't scroll.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -489,6 +493,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-$(document).ready( function(){ wpWidgets.init(); } );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+$document.ready( function(){ wpWidgets.init(); } );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> })(jQuery);
</span></span></pre>
</div>
</div>
</body>
</html>