<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[32292] trunk: In `wp_list_categories()`, 'All' link should point to post type archive if taxonomy is not registered for 'post' or 'page'.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32292">32292</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32292","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-04-24 14:56:37 +0000 (Fri, 24 Apr 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>In `wp_list_categories()`, 'All' link should point to post type archive if taxonomy is not registered for 'post' or 'page'.
Instead, we point to the post type archive of the first registered
object_type that supports archives.
Props stevegrunwell, hrishiv90, boonebgorges.
Fixes <a href="https://core.trac.wordpress.org/ticket/21881">#21881</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescategorytemplatephp">trunk/src/wp-includes/category-template.php</a></li>
<li><a href="#trunktestsphpunittestscategorywpListCategoriesphp">trunk/tests/phpunit/tests/category/wpListCategories.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescategorytemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/category-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/category-template.php 2015-04-23 22:39:16 UTC (rev 32291)
+++ trunk/src/wp-includes/category-template.php 2015-04-24 14:56:37 UTC (rev 32292)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -532,7 +532,28 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $show_option_all ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $posts_page = ( 'page' == get_option( 'show_on_front' ) && get_option( 'page_for_posts' ) ) ? get_permalink( get_option( 'page_for_posts' ) ) : home_url( '/' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $posts_page = '';
+
+ // For taxonomies that belong only to custom post types, point to a valid archive.
+ $taxonomy_object = get_taxonomy( $r['taxonomy'] );
+ if ( ! in_array( 'post', $taxonomy_object->object_type ) && ! in_array( 'page', $taxonomy_object->object_type ) ) {
+ foreach ( $taxonomy_object->object_type as $object_type ) {
+ $_object_type = get_post_type_object( $object_type );
+
+ // Grab the first one.
+ if ( ! empty( $_object_type->has_archive ) ) {
+ $posts_page = get_post_type_archive_link( $object_type );
+ break;
+ }
+ }
+ }
+
+ // Fallback for the 'All' link is the front page.
+ if ( ! $posts_page ) {
+ $posts_page = 'page' == get_option( 'show_on_front' ) && get_option( 'page_for_posts' ) ? get_permalink( get_option( 'page_for_posts' ) ) : home_url( '/' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $posts_page = esc_url( $posts_page );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'list' == $r['style'] ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $output .= "<li class='cat-item-all'><a href='$posts_page'>$show_option_all</a></li>";
</span></span></pre></div>
<a id="trunktestsphpunittestscategorywpListCategoriesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/category/wpListCategories.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/category/wpListCategories.php 2015-04-23 22:39:16 UTC (rev 32291)
+++ trunk/tests/phpunit/tests/category/wpListCategories.php 2015-04-24 14:56:37 UTC (rev 32292)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -100,6 +100,96 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertContains( "<li class='cat-item-all'><a href='" . get_permalink( $p ) . "'>All</a></li>", $found );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 21881
+ */
+ public function test_show_option_all_link_should_link_to_post_type_archive_when_taxonomy_does_not_apply_to_posts() {
+ register_post_type( 'wptests_pt', array( 'has_archive' => true ) );
+ register_post_type( 'wptests_pt2', array( 'has_archive' => true ) );
+ register_taxonomy( 'wptests_tax', array( 'foo', 'wptests_pt', 'wptests_pt2' ) );
+
+ $terms = $this->factory->term->create_many( 2, array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_list_categories( array(
+ 'echo' => false,
+ 'show_option_all' => 'All',
+ 'hide_empty' => false,
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $pt_archive = get_post_type_archive_link( 'wptests_pt' );
+
+ $this->assertContains( "<li class='cat-item-all'><a href='" . $pt_archive . "'>All</a></li>", $found );
+ }
+
+ /**
+ * @ticket 21881
+ */
+ public function test_show_option_all_link_should_not_link_to_post_type_archive_if_has_archive_is_false() {
+ register_post_type( 'wptests_pt', array( 'has_archive' => false ) );
+ register_post_type( 'wptests_pt2', array( 'has_archive' => true ) );
+ register_taxonomy( 'wptests_tax', array( 'foo', 'wptests_pt', 'wptests_pt2' ) );
+
+ $terms = $this->factory->term->create_many( 2, array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_list_categories( array(
+ 'echo' => false,
+ 'show_option_all' => 'All',
+ 'hide_empty' => false,
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $pt_archive = get_post_type_archive_link( 'wptests_pt2' );
+
+ $this->assertContains( "<li class='cat-item-all'><a href='" . $pt_archive . "'>All</a></li>", $found );
+ }
+
+ public function test_show_option_all_link_should_link_to_post_archive_if_available() {
+ register_post_type( 'wptests_pt', array( 'has_archive' => true ) );
+ register_post_type( 'wptests_pt2', array( 'has_archive' => true ) );
+ register_taxonomy( 'wptests_tax', array( 'foo', 'wptests_pt', 'post', 'wptests_pt2' ) );
+
+ $terms = $this->factory->term->create_many( 2, array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_list_categories( array(
+ 'echo' => false,
+ 'show_option_all' => 'All',
+ 'hide_empty' => false,
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $url = home_url( '/' );
+
+ $this->assertContains( "<li class='cat-item-all'><a href='" . $url . "'>All</a></li>", $found );
+ }
+
+ public function test_show_option_all_link_should_link_to_post_archive_if_no_associated_post_types_have_archives() {
+ register_post_type( 'wptests_pt', array( 'has_archive' => false ) );
+ register_post_type( 'wptests_pt2', array( 'has_archive' => false ) );
+ register_taxonomy( 'wptests_tax', array( 'foo', 'wptests_pt', 'wptests_pt2' ) );
+
+ $terms = $this->factory->term->create_many( 2, array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_list_categories( array(
+ 'echo' => false,
+ 'show_option_all' => 'All',
+ 'hide_empty' => false,
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $url = home_url( '/' );
+
+ $this->assertContains( "<li class='cat-item-all'><a href='" . $url . "'>All</a></li>", $found );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> public function list_cats_callback( $cat ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'Test Cat 1' === $cat ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return '';
</span></span></pre>
</div>
</div>
</body>
</html>