<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />

<title>[32228] trunk/src/wp-includes/js: Media: Date filtering does not need to be on for all contexts.</title>

</head>

<body>

<style type="text/css"><!--

#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }

#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }

#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }

#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }

#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }

#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }

#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }

#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }

#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }

#logmsg pre { background: #eee; padding: 1em; }

#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}

#logmsg dl { margin: 0; }

#logmsg dt { font-weight: bold; }

#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }

#logmsg dd:before { content:'\00bb';}

#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }

#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }

#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }

#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }

#logmsg table th.Corner { text-align: left; }

#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<div id="msg">

<dl class="meta" style="font-size: 105%">

<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32228">32228</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32228","name":"Review Commit"}}</script></dd>

<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>helen</dd>

<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-04-20 19:48:08 +0000 (Mon, 20 Apr 2015)</dd>

</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Media: Date filtering does not need to be on for all contexts.

Affected areas include customizer upload controls and video playlist editing.

props ocean90.

fixes <a href="https://core.trac.wordpress.org/ticket/32004">#32004</a>.</pre>

<h3>Modified Paths</h3>

<ul>

<li><a href="#trunksrcwpincludesjsmediacontrollerscollectioneditjs">trunk/src/wp-includes/js/media/controllers/collection-edit.js</a></li>

<li><a href="#trunksrcwpincludesjsmediacontrollersgalleryeditjs">trunk/src/wp-includes/js/media/controllers/gallery-edit.js</a></li>

<li><a href="#trunksrcwpincludesjsmediaviewsattachmentsbrowserjs">trunk/src/wp-includes/js/media/views/attachments/browser.js</a></li>

<li><a href="#trunksrcwpincludesjsmediaviewsframeselectjs">trunk/src/wp-includes/js/media/views/frame/select.js</a></li>

<li><a href="#trunksrcwpincludesjsmediaviewsjs">trunk/src/wp-includes/js/media-views.js</a></li>

</ul>

</div>

<div id="patch">

<h3>Diff</h3>

<a id="trunksrcwpincludesjsmediacontrollerscollectioneditjs"></a>

<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/media/controllers/collection-edit.js</h4>

<pre class="diff"><span>

<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/media/controllers/collection-edit.js     2015-04-20 19:43:39 UTC (rev 32227)

+++ trunk/src/wp-includes/js/media/controllers/collection-edit.js       2015-04-20 19:48:08 UTC (rev 32228)

</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -20,6 +20,7 @@

<span class="cx" style="display: block; padding: 0 10px">  * @param {string}                     attributes.menu                   Initial mode for the menu region. @todo this needs a better explanation.

<span class="cx" style="display: block; padding: 0 10px">  * @param {boolean}                    [attributes.searchable=false]     Whether the library is searchable.

<span class="cx" style="display: block; padding: 0 10px">  * @param {boolean}                    [attributes.sortable=true]        Whether the Attachments should be sortable. Depends on the orderby property being set to menuOrder on the attachments collection.

<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param {boolean}                    [attributes.date=true]            Whether to show the date filter in the browser's toolbar.

</ins><span class="cx" style="display: block; padding: 0 10px">  * @param {boolean}                    [attributes.describe=true]        Whether to offer UI to describe the attachments - e.g. captioning images in a gallery.

<span class="cx" style="display: block; padding: 0 10px">  * @param {boolean}                    [attributes.dragInfo=true]        Whether to show instructional text about the attachments being sortable.

<span class="cx" style="display: block; padding: 0 10px">  * @param {boolean}                    [attributes.dragInfoText]         Instructional text about the attachments being sortable.

</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -43,6 +44,7 @@

</span><span class="cx" style="display: block; padding: 0 10px">        defaults: {

</span><span class="cx" style="display: block; padding: 0 10px">                multiple:         false,

</span><span class="cx" style="display: block; padding: 0 10px">                sortable:         true,

</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                date:             false,

</ins><span class="cx" style="display: block; padding: 0 10px">                 searchable:       false,

</span><span class="cx" style="display: block; padding: 0 10px">                content:          'browse',

</span><span class="cx" style="display: block; padding: 0 10px">                describe:         true,

</span></span></pre></div>

<a id="trunksrcwpincludesjsmediacontrollersgalleryeditjs"></a>

<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/media/controllers/gallery-edit.js</h4>

<pre class="diff"><span>

<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/media/controllers/gallery-edit.js        2015-04-20 19:43:39 UTC (rev 32227)

+++ trunk/src/wp-includes/js/media/controllers/gallery-edit.js  2015-04-20 19:48:08 UTC (rev 32228)

</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,6 +18,7 @@

<span class="cx" style="display: block; padding: 0 10px">  * @param {boolean}                    [attributes.multiple=false]        Whether multi-select is enabled.

<span class="cx" style="display: block; padding: 0 10px">  * @param {boolean}                    [attributes.searchable=false]      Whether the library is searchable.

<span class="cx" style="display: block; padding: 0 10px">  * @param {boolean}                    [attributes.sortable=true]         Whether the Attachments should be sortable. Depends on the orderby property being set to menuOrder on the attachments collection.

<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param {boolean}                    [attributes.date=true]             Whether to show the date filter in the browser's toolbar.

</ins><span class="cx" style="display: block; padding: 0 10px">  * @param {string|false}               [attributes.content=browse]        Initial mode for the content region.

<span class="cx" style="display: block; padding: 0 10px">  * @param {string|false}               [attributes.toolbar=image-details] Initial mode for the toolbar region.

<span class="cx" style="display: block; padding: 0 10px">  * @param {boolean}                    [attributes.describe=true]         Whether to offer UI to describe attachments - e.g. captioning images in a gallery.

</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -42,6 +43,7 @@

</span><span class="cx" style="display: block; padding: 0 10px">                multiple:         false,

</span><span class="cx" style="display: block; padding: 0 10px">                searchable:       false,

</span><span class="cx" style="display: block; padding: 0 10px">                sortable:         true,

</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                date:             false,

</ins><span class="cx" style="display: block; padding: 0 10px">                 display:          false,

</span><span class="cx" style="display: block; padding: 0 10px">                content:          'browse',

</span><span class="cx" style="display: block; padding: 0 10px">                toolbar:          'gallery-edit',

</span></span></pre></div>

<a id="trunksrcwpincludesjsmediaviewsattachmentsbrowserjs"></a>

<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/media/views/attachments/browser.js</h4>

<pre class="diff"><span>

<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/media/views/attachments/browser.js       2015-04-20 19:43:39 UTC (rev 32227)

+++ trunk/src/wp-includes/js/media/views/attachments/browser.js 2015-04-20 19:48:08 UTC (rev 32228)

</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -8,17 +8,17 @@

</span><span class="cx" style="display: block; padding: 0 10px">  * @augments wp.Backbone.View

</span><span class="cx" style="display: block; padding: 0 10px">  * @augments Backbone.View

</span><span class="cx" style="display: block; padding: 0 10px">  *

</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param {object}      options

- * @param {object}      [options.filters=false] Which filters to show in the browser's toolbar.

- *                                              Accepts 'uploaded' and 'all'.

- * @param {object}      [options.search=true]   Whether to show the search interface in the

- *                                              browser's toolbar.

- * @param {object}      [options.date=true]     Whether to show the date filter in the

- *                                              browser's toolbar.

- * @param {object}      [options.display=false] Whether to show the attachments display settings

- *                                              view in the sidebar.

- * @param {bool|string} [options.sidebar=true]  Whether to create a sidebar for the browser.

- *                                              Accepts true, false, and 'errors'.

</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param {object}         [options]               The options hash passed to the view.

+ * @param {boolean|string} [options.filters=false] Which filters to show in the browser's toolbar.

+ *                                                 Accepts 'uploaded' and 'all'.

+ * @param {boolean}        [options.search=true]   Whether to show the search interface in the

+ *                                                 browser's toolbar.

+ * @param {boolean}        [options.date=true]     Whether to show the date filter in the

+ *                                                 browser's toolbar.

+ * @param {boolean}        [options.display=false] Whether to show the attachments display settings

+ *                                                 view in the sidebar.

+ * @param {boolean|string} [options.sidebar=true]  Whether to create a sidebar for the browser.

+ *                                                 Accepts true, false, and 'errors'.

</ins><span class="cx" style="display: block; padding: 0 10px">  */

</span><span class="cx" style="display: block; padding: 0 10px"> var View = wp.media.View,

</span><span class="cx" style="display: block; padding: 0 10px">        mediaTrash = wp.media.view.settings.mediaTrash,

</span></span></pre></div>

<a id="trunksrcwpincludesjsmediaviewsframeselectjs"></a>

<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/media/views/frame/select.js</h4>

<pre class="diff"><span>

<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/media/views/frame/select.js      2015-04-20 19:43:39 UTC (rev 32227)

+++ trunk/src/wp-includes/js/media/views/frame/select.js        2015-04-20 19:48:08 UTC (rev 32228)

</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -131,6 +131,7 @@

</span><span class="cx" style="display: block; padding: 0 10px">                        sortable:   state.get('sortable'),

</span><span class="cx" style="display: block; padding: 0 10px">                        search:     state.get('searchable'),

</span><span class="cx" style="display: block; padding: 0 10px">                        filters:    state.get('filterable'),

</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                        date:       state.get('date'),

</ins><span class="cx" style="display: block; padding: 0 10px">                         display:    state.has('display') ? state.get('display') : state.get('displaySettings'),

</span><span class="cx" style="display: block; padding: 0 10px">                        dragInfo:   state.get('dragInfo'),

</span><span class="cx" style="display: block; padding: 0 10px"> 

</span></span></pre></div>

<a id="trunksrcwpincludesjsmediaviewsjs"></a>

<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/media-views.js</h4>

<pre class="diff"><span>

<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/media-views.js   2015-04-20 19:43:39 UTC (rev 32227)

+++ trunk/src/wp-includes/js/media-views.js     2015-04-20 19:48:08 UTC (rev 32228)

</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -124,6 +124,7 @@