<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[32176] branches/4.1/src/wp-admin: Ensure post titles are correctly escaped on the Dashboard.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/32176">32176</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/32176","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>pento</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-04-20 07:41:34 +0000 (Mon, 20 Apr 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Ensure post titles are correctly escaped on the Dashboard. Merge of <a href="https://core.trac.wordpress.org/changeset/32175">[32175]</a> to the 4.1 branch.
Props helen, ocean90, dd32, pento.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches41srcwpadminincludesclasswpcommentslisttablephp">branches/4.1/src/wp-admin/includes/class-wp-comments-list-table.php</a></li>
<li><a href="#branches41srcwpadminincludesdashboardphp">branches/4.1/src/wp-admin/includes/dashboard.php</a></li>
<li><a href="#branches41srcwpadminincludestemplatephp">branches/4.1/src/wp-admin/includes/template.php</a></li>
<li><a href="#branches41srcwpadminjsnavmenujs">branches/4.1/src/wp-admin/js/nav-menu.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches41srcwpadminincludesclasswpcommentslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.1/src/wp-admin/includes/class-wp-comments-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.1/src/wp-admin/includes/class-wp-comments-list-table.php 2015-04-20 07:38:29 UTC (rev 32175)
+++ branches/4.1/src/wp-admin/includes/class-wp-comments-list-table.php 2015-04-20 07:41:34 UTC (rev 32176)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -554,9 +554,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( current_user_can( 'edit_post', $post->ID ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $post_link = "<a href='" . get_edit_post_link( $post->ID ) . "'>";
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post_link .= get_the_title( $post->ID ) . '</a>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post_link .= esc_html( get_the_title( $post->ID ) ) . '</a>';
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post_link = get_the_title( $post->ID );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post_link = esc_html( get_the_title( $post->ID ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<div class="response-links"><span class="post-com-count-wrapper">';
</span></span></pre></div>
<a id="branches41srcwpadminincludesdashboardphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.1/src/wp-admin/includes/dashboard.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.1/src/wp-admin/includes/dashboard.php 2015-04-20 07:38:29 UTC (rev 32175)
+++ branches/4.1/src/wp-admin/includes/dashboard.php 2015-04-20 07:41:34 UTC (rev 32176)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -518,7 +518,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function _wp_dashboard_recent_comments_row( &$comment, $show_date = true ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $GLOBALS['comment'] =& $comment;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $comment_post_title = strip_tags(get_the_title( $comment->comment_post_ID ));
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $comment_post_title = _draft_or_post_title( $comment->comment_post_ID );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( current_user_can( 'edit_post', $comment->comment_post_ID ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $comment_post_url = get_edit_post_link( $comment->comment_post_ID );
</span></span></pre></div>
<a id="branches41srcwpadminincludestemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.1/src/wp-admin/includes/template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.1/src/wp-admin/includes/template.php 2015-04-20 07:38:29 UTC (rev 32175)
+++ branches/4.1/src/wp-admin/includes/template.php 2015-04-20 07:41:34 UTC (rev 32176)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1505,7 +1505,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $title = get_the_title( $post );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $title ) )
</span><span class="cx" style="display: block; padding: 0 10px"> $title = __( '(no title)' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return $title;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return esc_html( $title );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="branches41srcwpadminjsnavmenujs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.1/src/wp-admin/js/nav-menu.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.1/src/wp-admin/js/nav-menu.js 2015-04-20 07:38:29 UTC (rev 32175)
+++ branches/4.1/src/wp-admin/js/nav-menu.js 2015-04-20 07:41:34 UTC (rev 32176)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -453,14 +453,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! isPrimaryMenuItem ) {
</span><span class="cx" style="display: block; padding: 0 10px"> thisLink = menuItem.find( '.menus-move-left' ),
</span><span class="cx" style="display: block; padding: 0 10px"> thisLinkText = menus.outFrom.replace( '%s', prevItemNameLeft );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- thisLink.prop( 'title', menus.moveOutFrom.replace( '%s', prevItemNameLeft ) ).html( thisLinkText ).css( 'display', 'inline' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ thisLink.prop( 'title', menus.moveOutFrom.replace( '%s', prevItemNameLeft ) ).text( thisLinkText ).css( 'display', 'inline' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 0 !== position ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( menuItem.find( '.menu-item-data-parent-id' ).val() !== menuItem.prev().find( '.menu-item-data-db-id' ).val() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> thisLink = menuItem.find( '.menus-move-right' ),
</span><span class="cx" style="display: block; padding: 0 10px"> thisLinkText = menus.under.replace( '%s', prevItemNameRight );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- thisLink.prop( 'title', menus.moveUnder.replace( '%s', prevItemNameRight ) ).html( thisLinkText ).css( 'display', 'inline' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ thisLink.prop( 'title', menus.moveUnder.replace( '%s', prevItemNameRight ) ).text( thisLinkText ).css( 'display', 'inline' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -482,7 +482,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> title = menus.subMenuFocus.replace( '%1$s', itemName ).replace( '%2$d', itemPosition ).replace( '%3$s', parentItemName );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this.prop('title', title).html( title );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this.prop('title', title).text( title );
</ins><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>