<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[31925] trunk/src/wp-admin: Press This: fix accessibility for the post options "sidebar".</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/31925">31925</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/31925","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>azaozz</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-03-30 03:08:30 +0000 (Mon, 30 Mar 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
Part props afercis, joedolson. Fixes <a href="https://core.trac.wordpress.org/ticket/31575">#31575</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadmincsspressthiscss">trunk/src/wp-admin/css/press-this.css</a></li>
<li><a href="#trunksrcwpadminincludesclasswppressthisphp">trunk/src/wp-admin/includes/class-wp-press-this.php</a></li>
<li><a href="#trunksrcwpadminjspressthisjs">trunk/src/wp-admin/js/press-this.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadmincsspressthiscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/css/press-this.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/css/press-this.css 2015-03-30 03:08:28 UTC (rev 31924)
+++ trunk/src/wp-admin/css/press-this.css 2015-03-30 03:08:30 UTC (rev 31925)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -854,7 +854,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .add-cat-toggle {
</span><span class="cx" style="display: block; padding: 0 10px"> float: right;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin-top: -33px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ margin-top: -45px;
+ line-height: 20px;
+ padding: 12px 10px 8px;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .add-cat-toggle:focus {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -863,7 +865,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .add-cat-toggle.is-toggled {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- margin-top: -36px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ padding: 10px;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .add-cat-toggle.is-toggled .dashicons:before {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1185,34 +1187,32 @@
</span><span class="cx" style="display: block; padding: 0 10px"> vertical-align: middle;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.options-open,
-.options-close {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.options,
+.options.open .on-closed,
+.options.closed .on-open {
</ins><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> @media (max-width: 900px) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .options-open,
- .options-close {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .options {
</ins><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.options-open.is-hidden,
-.options-close.is-hidden,
</del><span class="cx" style="display: block; padding: 0 10px"> .options-panel-back.is-hidden {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.options-open:focus .dashicons {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.options:focus .dashicons {
</ins><span class="cx" style="display: block; padding: 0 10px"> color: #fff;
</span><span class="cx" style="display: block; padding: 0 10px"> text-decoration: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.options-open .dashicons {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.options .dashicons {
</ins><span class="cx" style="display: block; padding: 0 10px"> margin-top: 3px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.options-close {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.options {
</ins><span class="cx" style="display: block; padding: 0 10px"> color: #2ea2cc;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludesclasswppressthisphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-press-this.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-press-this.php 2015-03-30 03:08:28 UTC (rev 31924)
+++ trunk/src/wp-admin/includes/class-wp-press-this.php 2015-03-30 03:08:30 UTC (rev 31925)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1201,10 +1201,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="current-site-name"><?php bloginfo( 'name' ); ?></span>
</span><span class="cx" style="display: block; padding: 0 10px"> </a>
</span><span class="cx" style="display: block; padding: 0 10px"> </h1>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <button type="button" class="options-open button-subtle">
- <span class="dashicons dashicons-tag"></span><span class="screen-reader-text"><?php _e( 'Show post options' ); ?></span>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" class="options button-subtle closed">
+ <span class="dashicons dashicons-tag on-closed"></span>
+ <span class="screen-reader-text on-closed"><?php _e( 'Show post options' ); ?></span>
+ <span aria-hidden="true" class="on-open"><?php _e( 'Done' ); ?></span>
+ <span class="screen-reader-text on-open"><?php _e( 'Hide post options' ); ?></span>
</ins><span class="cx" style="display: block; padding: 0 10px"> </button>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <button type="button" class="options-close button-subtle is-hidden"><?php _e( 'Done' ); ?></button>
</del><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="scanbar" class="scan">
</span></span></pre></div>
<a id="trunksrcwpadminjspressthisjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/press-this.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/press-this.js 2015-03-30 03:08:28 UTC (rev 31924)
+++ trunk/src/wp-admin/js/press-this.js 2015-03-30 03:08:30 UTC (rev 31925)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -488,11 +488,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function openSidebar() {
</span><span class="cx" style="display: block; padding: 0 10px"> sidebarIsOpen = true;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( '.options-open, .press-this-actions, #scanbar' ).addClass( isHidden );
- $( '.options-close, .options-panel-back' ).removeClass( isHidden );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '.options' ).removeClass( 'closed' ).addClass( 'open' );
+ $( '.press-this-actions, #scanbar' ).addClass( isHidden );
+ $( '.options-panel-back' ).removeClass( isHidden );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $( '.options-panel' ).removeClass( offscreenHidden )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .one( 'transitionend', function() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .one( transitionEndEvent, function() {
</ins><span class="cx" style="display: block; padding: 0 10px"> $( '.post-option:first' ).focus();
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -500,11 +501,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function closeSidebar() {
</span><span class="cx" style="display: block; padding: 0 10px"> sidebarIsOpen = false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( '.options-close, .options-panel-back' ).addClass( isHidden );
- $( '.options-open, .press-this-actions, #scanbar' ).removeClass( isHidden );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '.options' ).removeClass( 'open' ).addClass( 'closed' );
+ $( '.options-panel-back' ).addClass( isHidden );
+ $( '.press-this-actions, #scanbar' ).removeClass( isHidden );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $( '.options-panel' ).addClass( isOffScreen )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .one( 'transitionend', function() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .one( transitionEndEvent, function() {
</ins><span class="cx" style="display: block; padding: 0 10px"> $( this ).addClass( isHidden );
</span><span class="cx" style="display: block; padding: 0 10px"> // Reset to options list
</span><span class="cx" style="display: block; padding: 0 10px"> $( '.post-options' ).removeClass( offscreenHidden );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -620,8 +622,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> monitorPlaceholder();
</span><span class="cx" style="display: block; padding: 0 10px"> monitorCatList();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( '.options-open' ).on( 'click.press-this', openSidebar );
- $( '.options-close' ).on( 'click.press-this', closeSidebar );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '.options' ).on( 'click.press-this', function() {
+ if ( $( this ).hasClass( 'open' ) ) {
+ closeSidebar();
+ } else {
+ openSidebar();
+ }
+ });
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Close the sidebar when focus moves outside of it.
</span><span class="cx" style="display: block; padding: 0 10px"> $( '.options-panel, .options-panel-back' ).on( 'focusout.press-this', function() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -632,7 +639,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( sidebarIsOpen && node && ! $node.hasClass( 'options-panel-back' ) &&
</span><span class="cx" style="display: block; padding: 0 10px"> ( node.nodeName === 'BODY' ||
</span><span class="cx" style="display: block; padding: 0 10px"> ( ! $node.closest( '.options-panel' ).length &&
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- ! $node.closest( '.options-open' ).length ) ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ ! $node.closest( '.options' ).length ) ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> closeSidebar();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>