<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[31795] trunk/src/wp-includes/comment.php: Move the default arguments hash notation for `WP_Comment_Query` to the new constructor, where the argument definitions were moved in [31793].</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/31795">31795</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/31795","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>DrewAPicture</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-03-16 20:17:35 +0000 (Mon, 16 Mar 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Move the default arguments hash notation for `WP_Comment_Query` to the new constructor, where the argument definitions were moved in <a href="https://core.trac.wordpress.org/changeset/31793">[31793]</a>.
Core style dictates that the default arguments should be documented in the same function or method where they are defined.
See <a href="https://core.trac.wordpress.org/changeset/31793">[31793]</a>.
Fixes <a href="https://core.trac.wordpress.org/ticket/24826">#24826</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludescommentphp">trunk/src/wp-includes/comment.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludescommentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/comment.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/comment.php 2015-03-16 18:50:50 UTC (rev 31794)
+++ trunk/src/wp-includes/comment.php 2015-03-16 20:17:35 UTC (rev 31795)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -232,7 +232,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * WordPress Comment Query class.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * See {@see WP_Comment_Query::query()} for accepted arguments.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * See WP_Comment_Query::__construct() for accepted arguments.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 3.1.0
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -316,62 +316,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 4.2.0
</span><span class="cx" style="display: block; padding: 0 10px"> * @access public
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $query URL query string.
- * @return WP_Comment_Query
- */
- public function __construct( $query = '' ) {
- $this->query_var_defaults = array(
- 'author_email' => '',
- 'author__in' => '',
- 'author__not_in' => '',
- 'include_unapproved' => '',
- 'fields' => '',
- 'ID' => '',
- 'comment__in' => '',
- 'comment__not_in' => '',
- 'karma' => '',
- 'number' => '',
- 'offset' => '',
- 'orderby' => '',
- 'order' => 'DESC',
- 'parent' => '',
- 'post_author__in' => '',
- 'post_author__not_in' => '',
- 'post_ID' => '',
- 'post_id' => 0,
- 'post__in' => '',
- 'post__not_in' => '',
- 'post_author' => '',
- 'post_name' => '',
- 'post_parent' => '',
- 'post_status' => '',
- 'post_type' => '',
- 'status' => 'all',
- 'type' => '',
- 'type__in' => '',
- 'type__not_in' => '',
- 'user_id' => '',
- 'search' => '',
- 'count' => false,
- 'meta_key' => '',
- 'meta_value' => '',
- 'meta_query' => '',
- 'date_query' => null, // See WP_Date_Query
- );
-
- if ( ! empty( $query ) ) {
- $this->query( $query );
- }
- }
-
- /**
- * Parse arguments passed to the comment query with default query parameters.
- *
- * @since 4.2.0 Extracted from {@link WP_Comment_Query::query()}.
- * @access public
- *
</del><span class="cx" style="display: block; padding: 0 10px"> * @param string|array $query {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Optional. Array or query string of comment query parameters.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Optional. Array or query string of comment query parameters. Default empty.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $author_email Comment author email address. Default empty.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type array $author__in Array of author IDs to include comments for. Default empty.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -380,7 +326,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @type array $comment__not_in Array of comment IDs to exclude. Default empty.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool $count Whether to return a comment count (true) or array of comment
</span><span class="cx" style="display: block; padding: 0 10px"> * objects (false). Default false.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @type array $date_query Date query clauses to limit comments by. See {@see WP_Date_Query}.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @type array $date_query Date query clauses to limit comments by. See WP_Date_Query.
</ins><span class="cx" style="display: block; padding: 0 10px"> * Default null.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $fields Comment fields to return. Accepts 'ids' for comment IDs only or
</span><span class="cx" style="display: block; padding: 0 10px"> * empty for all fields. Default empty.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -392,7 +338,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $meta_value Include comments with a matching comment meta value. Requires
</span><span class="cx" style="display: block; padding: 0 10px"> * `$meta_key` to be set. Default empty.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type array $meta_query Meta query clauses to limit retrieved comments by.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * See {@see WP_Meta_Query}. Default empty.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * See WP_Meta_Query. Default empty.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type int $number Maximum number of comments to retrieve. Default null (no limit).
</span><span class="cx" style="display: block; padding: 0 10px"> * @type int $offset Number of comments to offset the query. Used to build LIMIT clause.
</span><span class="cx" style="display: block; padding: 0 10px"> * Default 0.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -433,7 +379,62 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @type array $type__not_in Exclude comments from a given array of comment types. Default empty.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type int $user_id Include comments for a specific user ID. Default empty.
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @return WP_Comment_Query WP_Comment_Query instance.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function __construct( $query = '' ) {
+ $this->query_var_defaults = array(
+ 'author_email' => '',
+ 'author__in' => '',
+ 'author__not_in' => '',
+ 'include_unapproved' => '',
+ 'fields' => '',
+ 'ID' => '',
+ 'comment__in' => '',
+ 'comment__not_in' => '',
+ 'karma' => '',
+ 'number' => '',
+ 'offset' => '',
+ 'orderby' => '',
+ 'order' => 'DESC',
+ 'parent' => '',
+ 'post_author__in' => '',
+ 'post_author__not_in' => '',
+ 'post_ID' => '',
+ 'post_id' => 0,
+ 'post__in' => '',
+ 'post__not_in' => '',
+ 'post_author' => '',
+ 'post_name' => '',
+ 'post_parent' => '',
+ 'post_status' => '',
+ 'post_type' => '',
+ 'status' => 'all',
+ 'type' => '',
+ 'type__in' => '',
+ 'type__not_in' => '',
+ 'user_id' => '',
+ 'search' => '',
+ 'count' => false,
+ 'meta_key' => '',
+ 'meta_value' => '',
+ 'meta_query' => '',
+ 'date_query' => null, // See WP_Date_Query
+ );
+
+ if ( ! empty( $query ) ) {
+ $this->query( $query );
+ }
+ }
+
+ /**
+ * Parse arguments passed to the comment query with default query parameters.
+ *
+ * @since 4.2.0 Extracted from WP_Comment_Query::query().
+ *
+ * @access public
+ *
+ * @param string|array $query WP_Comment_Query arguments. See WP_Comment_Query::__construct()
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> public function parse_query( $query = '' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $query ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $query = $this->query_vars;
</span></span></pre>
</div>
</div>
</body>
</html>