<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[31730] trunk: Introduce a new algorithm for displaying a hierarchical list of post objects in the `WP_Posts_List_Table`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/31730">31730</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/31730","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>johnbillion</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-03-11 20:45:17 +0000 (Wed, 11 Mar 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Introduce a new algorithm for displaying a hierarchical list of post objects in the `WP_Posts_List_Table`. This reduces processing time, reduces database queries, and substantially reduces memory use on sites with a high number of Pages.
Props nofearinc, rodrigosprimo, nacin, johnbillion.
Fixes <a href="https://core.trac.wordpress.org/ticket/15459">#15459</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesclasswppostslisttablephp">trunk/src/wp-admin/includes/class-wp-posts-list-table.php</a></li>
<li><a href="#trunksrcwpadminincludespostphp">trunk/src/wp-admin/includes/post.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestsadminincludesListTablephp">trunk/tests/phpunit/tests/admin/includesListTable.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesclasswppostslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/class-wp-posts-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2015-03-11 20:43:25 UTC (rev 31729)
+++ trunk/src/wp-admin/includes/class-wp-posts-list-table.php 2015-03-11 20:45:17 UTC (rev 31730)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -86,6 +86,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * Sets whether the table layout should be hierarchical or not.
+ *
+ * @since 4.2.0
+ *
+ * @param bool $display Whether the table layout should be hierarchical.
+ */
+ public function set_hierarchical_display( $display ) {
+ $this->hierarchical_display = $display;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> public function ajax_user_can() {
</span><span class="cx" style="display: block; padding: 0 10px"> return current_user_can( get_post_type_object( $this->screen->post_type )->cap->edit_posts );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -95,7 +106,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $avail_post_stati = wp_edit_posts_query();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->hierarchical_display = ( is_post_type_hierarchical( $this->screen->post_type ) && 'menu_order title' == $wp_query->query['orderby'] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->set_hierarchical_display( is_post_type_hierarchical( $this->screen->post_type ) && 'menu_order title' == $wp_query->query['orderby'] );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $total_items = $this->hierarchical_display ? $wp_query->post_count : $wp_query->found_posts;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -478,20 +489,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $count = 0;
</span><span class="cx" style="display: block; padding: 0 10px"> $start = ( $pagenum - 1 ) * $per_page;
</span><span class="cx" style="display: block; padding: 0 10px"> $end = $start + $per_page;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $to_display = array();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $pages as $page ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $count >= $end )
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $count >= $start ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "\t";
- $this->single_row( $page, $level );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $to_display[$page->ID] = $level;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $count++;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $children_pages ) )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->_page_rows( $children_pages, $count, $page->ID, $level + 1, $pagenum, $per_page );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->_page_rows( $children_pages, $count, $page->ID, $level + 1, $pagenum, $per_page, $to_display );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // If it is the last pagenum and there are orphaned pages, display them with paging as well.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -502,14 +513,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $count >= $start ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "\t";
- $this->single_row( $op, 0 );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $to_display[$op->ID] = 0;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $count++;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $ids = array_keys( $to_display );
+ _prime_post_caches( $ids );
+
+ if ( ! isset( $GLOBALS['post'] ) ) {
+ $GLOBALS['post'] = array_shift( $ids );
+ }
+
+ foreach ( $to_display as $page_id => $level ) {
+ echo "\t";
+ $this->single_row( $page_id, $level );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -517,6 +539,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * together with paging support
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 3.1.0 (Standalone function exists since 2.6.0)
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 4.2.0 Added the `$to_display` parameter.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $children_pages
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $count
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -524,8 +547,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $level
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $pagenum
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $per_page
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param array $to_display list of pages to be displayed
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- private function _page_rows( &$children_pages, &$count, $parent, $level, $pagenum, $per_page ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ private function _page_rows( &$children_pages, &$count, $parent, $level, $pagenum, $per_page, &$to_display ) {
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! isset( $children_pages[$parent] ) )
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -543,7 +567,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $my_parents = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $my_parent = $page->post_parent;
</span><span class="cx" style="display: block; padding: 0 10px"> while ( $my_parent ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $my_parent = get_post( $my_parent );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Get the ID from the list or the attribute if my_parent is an object
+ $parent_id = $my_parent;
+ if ( is_object( $my_parent ) ) {
+ $parent_id = $my_parent->ID;
+ }
+
+ $my_parent = get_post( $parent_id );
</ins><span class="cx" style="display: block; padding: 0 10px"> $my_parents[] = $my_parent;
</span><span class="cx" style="display: block; padding: 0 10px"> if ( !$my_parent->post_parent )
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -551,20 +581,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> $num_parents = count( $my_parents );
</span><span class="cx" style="display: block; padding: 0 10px"> while ( $my_parent = array_pop( $my_parents ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "\t";
- $this->single_row( $my_parent, $level - $num_parents );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $to_display[$my_parent->ID] = $level - $num_parents;
</ins><span class="cx" style="display: block; padding: 0 10px"> $num_parents--;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $count >= $start ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo "\t";
- $this->single_row( $page, $level );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $to_display[$page->ID] = $level;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $count++;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->_page_rows( $children_pages, $count, $page->ID, $level + 1, $pagenum, $per_page );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->_page_rows( $children_pages, $count, $page->ID, $level + 1, $pagenum, $per_page, $to_display );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $children_pages[$parent] ); //required in order to keep track of orphans
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -579,6 +607,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> global $mode;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $global_post = get_post();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $post = get_post( $post );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $GLOBALS['post'] = $post;
</span><span class="cx" style="display: block; padding: 0 10px"> setup_postdata( $post );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpadminincludespostphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/post.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/post.php 2015-03-11 20:43:25 UTC (rev 31729)
+++ trunk/src/wp-admin/includes/post.php 2015-03-11 20:45:17 UTC (rev 31730)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1039,6 +1039,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $query['order'] = 'asc';
</span><span class="cx" style="display: block; padding: 0 10px"> $query['posts_per_page'] = -1;
</span><span class="cx" style="display: block; padding: 0 10px"> $query['posts_per_archive_page'] = -1;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $query['fields'] = 'id=>parent';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $q['show_sticky'] ) )
</span></span></pre></div>
<a id="trunktestsphpunittestsadminincludesListTablephp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/tests/admin/includesListTable.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/admin/includesListTable.php (rev 0)
+++ trunk/tests/phpunit/tests/admin/includesListTable.php 2015-03-11 20:45:17 UTC (rev 31730)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,179 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+/**
+ * @group admin
+ */
+class Tests_Admin_includesListTable extends WP_UnitTestCase {
+ function setUp() {
+ set_current_screen( 'edit-page' );
+ $GLOBALS['hook_suffix'] = '';
+ $this->table = _get_list_table( 'WP_Posts_List_Table' );
+
+ parent::setUp();
+
+ // note that our top/children/grandchildren arrays are 1-indexed
+
+ // create top level pages
+ $num_posts = 5;
+ foreach ( range( 1, $num_posts ) as $i ) {
+ $this->top[$i] = $this->factory->post->create_and_get( array(
+ 'post_type' => 'page',
+ 'post_title' => sprintf( 'Top Level Page %d', $i ),
+ ) );
+ }
+
+ // create child pages
+ $num_children = 3;
+ foreach ( $this->top as $top => $top_page ) {
+ foreach ( range( 1, $num_children ) as $i ) {
+ $this->children[$top][$i] = $this->factory->post->create_and_get( array(
+ 'post_type' => 'page',
+ 'post_parent' => $top_page->ID,
+ 'post_title' => sprintf( 'Child %d', $i ),
+ ) );
+ }
+ }
+
+ // create grand-child pages for the third and fourth top-level pages
+ $num_grandchildren = 3;
+ foreach ( range( 3, 4 ) as $top ) {
+ foreach ( $this->children[$top] as $child => $child_page ) {
+ foreach ( range( 1, $num_grandchildren ) as $i ) {
+ $this->grandchildren[$top][$child][$i] = $this->factory->post->create_and_get( array(
+ 'post_type' => 'page',
+ 'post_parent' => $child_page->ID,
+ 'post_title' => sprintf( 'Grandchild %d', $i ),
+ ) );
+ }
+ }
+ }
+ }
+
+ /**
+ * @ticket 15459
+ */
+ function test_list_hierarchical_pages_first_page() {
+ $this->_test_list_hierarchical_page( array(
+ 'paged' => 1,
+ 'posts_per_page' => 2,
+ ), array(
+ $this->top[1]->ID,
+ $this->children[1][1]->ID,
+ ) );
+ }
+
+ /**
+ * @ticket 15459
+ */
+ function test_list_hierarchical_pages_second_page() {
+ $this->_test_list_hierarchical_page( array(
+ 'paged' => 2,
+ 'posts_per_page' => 2,
+ ), array(
+ $this->top[1]->ID,
+ $this->children[1][2]->ID,
+ $this->children[1][3]->ID,
+ ) );
+ }
+
+ /**
+ * @ticket 15459
+ */
+ function test_search_hierarchical_pages_first_page() {
+ $this->_test_list_hierarchical_page( array(
+ 'paged' => 1,
+ 'posts_per_page' => 2,
+ 's' => 'Child',
+ ), array(
+ $this->children[1][1]->ID,
+ $this->children[1][2]->ID,
+ ) );
+ }
+
+ /**
+ * @ticket 15459
+ */
+ function test_search_hierarchical_pages_second_page() {
+ $this->_test_list_hierarchical_page( array(
+ 'paged' => 2,
+ 'posts_per_page' => 2,
+ 's' => 'Top',
+ ), array(
+ $this->top[3]->ID,
+ $this->top[4]->ID,
+ ) );
+ }
+
+ /**
+ * @ticket 15459
+ */
+ function test_grandchildren_hierarchical_pages_first_page() {
+ // page 6 is the first page with grandchildren
+ $this->_test_list_hierarchical_page( array(
+ 'paged' => 6,
+ 'posts_per_page' => 2,
+ ), array(
+ $this->top[3]->ID,
+ $this->children[3][1]->ID,
+ $this->grandchildren[3][1][1]->ID,
+ $this->grandchildren[3][1][2]->ID,
+ ) );
+ }
+
+ /**
+ * @ticket 15459
+ */
+ function test_grandchildren_hierarchical_pages_second_page() {
+ // page 7 is the second page with grandchildren
+ $this->_test_list_hierarchical_page( array(
+ 'paged' => 7,
+ 'posts_per_page' => 2,
+ ), array(
+ $this->top[3]->ID,
+ $this->children[3][1]->ID,
+ $this->grandchildren[3][1][3]->ID,
+ $this->children[3][2]->ID,
+ ) );
+ }
+
+ /**
+ * Helper function to test the output of a page which uses `WP_Posts_List_Table`.
+ *
+ * @param array $args Query args for the list of pages.
+ * @param array $expected_ids Expected IDs of pages returned.
+ */
+ protected function _test_list_hierarchical_page( array $args, array $expected_ids ) {
+ $matches = array();
+
+ $_REQUEST['paged'] = $args['paged'];
+ $GLOBALS['per_page'] = $args['posts_per_page'];
+
+ $args = array_merge( array(
+ 'post_type' => 'page',
+ ), $args );
+
+ // Mimic the behaviour of `wp_edit_posts_query()`:
+ if ( ! isset( $args['orderby'] ) ) {
+ $args['orderby'] = 'menu_order title';
+ $args['order'] = 'asc';
+ $args['posts_per_page'] = -1;
+ $args['posts_per_archive_page'] = -1;
+ }
+
+ $pages = new WP_Query( $args );
+
+ ob_start();
+ $this->table->set_hierarchical_display( true );
+ $this->table->display_rows( $pages->posts );
+ $output = ob_get_clean();
+
+ preg_match_all( '|<tr[^>]*>|', $output, $matches );
+
+ $this->assertCount( count( $expected_ids ), array_keys( $matches[0] ) );
+
+ foreach ( $expected_ids as $id ) {
+ $this->assertContains( sprintf( 'id="post-%d"', $id ), $output );
+ }
+ }
+
+}
</ins></span></pre>
</div>
</div>
</body>
</html>