<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[31689] trunk/src/wp-includes/js/mce-view.js: TinyMCE wpView: decode HTML entities before trying to match the wpView text string.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/31689">31689</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/31689","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>azaozz</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-03-09 19:08:05 +0000 (Mon, 09 Mar 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>TinyMCE wpView: decode HTML entities before trying to match the wpView text string. Props iseulde. See <a href="https://core.trac.wordpress.org/ticket/31412">#31412</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesjsmceviewjs">trunk/src/wp-includes/js/mce-view.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesjsmceviewjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/mce-view.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/mce-view.js 2015-03-09 07:03:12 UTC (rev 31688)
+++ trunk/src/wp-includes/js/mce-view.js 2015-03-09 19:08:05 UTC (rev 31689)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -91,6 +91,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> setMarkers: function( content ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var pieces = [ { content: content } ],
</span><span class="cx" style="display: block; padding: 0 10px"> self = this,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ instance,
</ins><span class="cx" style="display: block; padding: 0 10px"> current;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> _.each( views, function( view, type ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -115,11 +116,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> pieces.push( { content: remaining.substring( 0, result.index ) } );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- self.createInstance( type, result.content, result.options );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ instance = self.createInstance( type, result.content, result.options );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Add the processed piece for the match.
</span><span class="cx" style="display: block; padding: 0 10px"> pieces.push( {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- content: '<p data-wpview-marker="' + encodeURIComponent( result.content ) + '">' + result.content + '</p>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ content: '<p data-wpview-marker="' + instance.encodedText + '">' + instance.text + '</p>',
</ins><span class="cx" style="display: block; padding: 0 10px"> processed: true
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -149,9 +150,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> createInstance: function( type, text, options ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var View = this.get( type ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- encodedText = encodeURIComponent( text ),
- instance = this.getInstance( encodedText );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ encodedText,
+ instance;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ text = tinymce.DOM.decode( text ),
+ encodedText = encodeURIComponent( text ),
+ instance = this.getInstance( encodedText );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( instance ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return instance;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -754,7 +759,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( this.url ) {
</span><span class="cx" style="display: block; padding: 0 10px"> this.loader = false;
</span><span class="cx" style="display: block; padding: 0 10px"> this.shortcode = wp.media.embed.shortcode( {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- url: this.url
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ url: this.text
</ins><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -804,7 +809,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> edit: function( text, update ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var media = wp.media.embed,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- frame = media.edit( text, !! this.url ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ frame = media.edit( text, this.url ),
</ins><span class="cx" style="display: block; padding: 0 10px"> self = this,
</span><span class="cx" style="display: block; padding: 0 10px"> events = 'change:url change:width change:height';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -819,13 +824,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> frame.state( 'embed' ).on( 'select', function() {
</span><span class="cx" style="display: block; padding: 0 10px"> var data = frame.state( 'embed' ).metadata;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( data.width ) {
- delete self.url;
- } else {
- self.url = data.url;
- }
-
- if ( self.url ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( self.url && ! data.width ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> update( data.url );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> update( media.shortcode( data ).string() );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -866,7 +865,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> index: match.index + match[1].length,
</span><span class="cx" style="display: block; padding: 0 10px"> content: match[2],
</span><span class="cx" style="display: block; padding: 0 10px"> options: {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- url: match[2]
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ url: true
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>