<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[31690] trunk/src: Replace flagrant instances of `.html('')` with `.empty()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/31690">31690</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/31690","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>wonderboymusic</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-03-09 19:43:49 +0000 (Mon, 09 Mar 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Replace flagrant instances of `.html('')` with `.empty()`.
Props OriginalEXE, SergeyBiryukov.
Fixes <a href="https://core.trac.wordpress.org/ticket/27034">#27034</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminjseditcommentsjs">trunk/src/wp-admin/js/edit-comments.js</a></li>
<li><a href="#trunksrcwpadminjsinlineeditpostjs">trunk/src/wp-admin/js/inline-edit-post.js</a></li>
<li><a href="#trunksrcwpadminjsmediajs">trunk/src/wp-admin/js/media.js</a></li>
<li><a href="#trunksrcwpadminjsthemejs">trunk/src/wp-admin/js/theme.js</a></li>
<li><a href="#trunksrcwpadminjswidgetsjs">trunk/src/wp-admin/js/widgets.js</a></li>
<li><a href="#trunksrcwpincludesjsmediaviewsembedlinkjs">trunk/src/wp-includes/js/media/views/embed/link.js</a></li>
<li><a href="#trunksrcwpincludesjsmediaviewsjs">trunk/src/wp-includes/js/media/views.js</a></li>
<li><a href="#trunksrcwpincludesjspluploadhandlersjs">trunk/src/wp-includes/js/plupload/handlers.js</a></li>
<li><a href="#trunksrcwpincludesjswpajaxresponsejs">trunk/src/wp-includes/js/wp-ajax-response.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminjseditcommentsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/edit-comments.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/edit-comments.js 2015-03-09 19:08:05 UTC (rev 31689)
+++ trunk/src/wp-admin/js/edit-comments.js 2015-03-09 19:43:49 UTC (rev 31690)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -351,7 +351,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $('#com-reply').append( replyrow );
</span><span class="cx" style="display: block; padding: 0 10px"> $('#replycontent').css('height', '').val('');
</span><span class="cx" style="display: block; padding: 0 10px"> $('#edithead input').val('');
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('.error', replyrow).html('').hide();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('.error', replyrow).empty().hide();
</ins><span class="cx" style="display: block; padding: 0 10px"> $('.spinner', replyrow).hide();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> this.cid = '';
</span></span></pre></div>
<a id="trunksrcwpadminjsinlineeditpostjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/inline-edit-post.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/inline-edit-post.js 2015-03-09 19:08:05 UTC (rev 31689)
+++ trunk/src/wp-admin/js/inline-edit-post.js 2015-03-09 19:43:49 UTC (rev 31690)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -286,7 +286,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'bulk-edit' === id ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $('table.widefat #bulk-edit').removeClass('inline-editor').hide().siblings('tr.hidden').remove();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#bulk-titles').html('');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('#bulk-titles').empty();
</ins><span class="cx" style="display: block; padding: 0 10px"> $('#inlineedit').append( $('#bulk-edit') );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $('#'+id).siblings('tr.hidden').addBack().remove();
</span></span></pre></div>
<a id="trunksrcwpadminjsmediajs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/media.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/media.js 2015-03-09 19:08:05 UTC (rev 31689)
+++ trunk/src/wp-admin/js/media.js 2015-03-09 19:43:49 UTC (rev 31690)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -32,7 +32,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> close: function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#find-posts-response').html('');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('#find-posts-response').empty();
</ins><span class="cx" style="display: block; padding: 0 10px"> $('#find-posts').hide();
</span><span class="cx" style="display: block; padding: 0 10px"> $( '.ui-find-overlay' ).hide();
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span></span></pre></div>
<a id="trunksrcwpadminjsthemejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/theme.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/theme.js 2015-03-09 19:08:05 UTC (rev 31689)
+++ trunk/src/wp-admin/js/theme.js 2015-03-09 19:43:49 UTC (rev 31690)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -900,7 +900,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // and keeping theme count in sync
</span><span class="cx" style="display: block; padding: 0 10px"> render: function() {
</span><span class="cx" style="display: block; padding: 0 10px"> // Clear the DOM, please
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.$el.html( '' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.$el.empty();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // If the user doesn't have switch capabilities
</span><span class="cx" style="display: block; padding: 0 10px"> // or there is only one theme in the collection
</span></span></pre></div>
<a id="trunksrcwpadminjswidgetsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/js/widgets.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/js/widgets.js 2015-03-09 19:08:05 UTC (rev 31689)
+++ trunk/src/wp-admin/js/widgets.js 2015-03-09 19:43:49 UTC (rev 31690)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -233,7 +233,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> drop: function(e,ui) {
</span><span class="cx" style="display: block; padding: 0 10px"> ui.draggable.addClass('deleting');
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#removing-widget').hide().children('span').html('');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('#removing-widget').hide().children('span').empty();
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> over: function(e,ui) {
</span><span class="cx" style="display: block; padding: 0 10px"> ui.draggable.addClass('deleting');
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -247,7 +247,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> out: function(e,ui) {
</span><span class="cx" style="display: block; padding: 0 10px"> ui.draggable.removeClass('deleting');
</span><span class="cx" style="display: block; padding: 0 10px"> $('div.widget-placeholder').show();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#removing-widget').hide().children('span').html('');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('#removing-widget').hide().children('span').empty();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesjsmediaviewsembedlinkjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/media/views/embed/link.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/media/views/embed/link.js 2015-03-09 19:08:05 UTC (rev 31689)
+++ trunk/src/wp-includes/js/media/views/embed/link.js 2015-03-09 19:43:49 UTC (rev 31690)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -27,7 +27,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var url = this.model.get( 'url' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // clear out previous results
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.$('.embed-container').hide().find('.embed-preview').html('');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.$('.embed-container').hide().find('.embed-preview').empty();
</ins><span class="cx" style="display: block; padding: 0 10px"> this.$( '.setting' ).hide();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // only proceed with embed if the field contains more than 6 characters
</span></span></pre></div>
<a id="trunksrcwpincludesjsmediaviewsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/media/views.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/media/views.js 2015-03-09 19:08:05 UTC (rev 31689)
+++ trunk/src/wp-includes/js/media/views.js 2015-03-09 19:43:49 UTC (rev 31690)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4604,7 +4604,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var url = this.model.get( 'url' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // clear out previous results
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.$('.embed-container').hide().find('.embed-preview').html('');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.$('.embed-container').hide().find('.embed-preview').empty();
</ins><span class="cx" style="display: block; padding: 0 10px"> this.$( '.setting' ).hide();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // only proceed with embed if the field contains more than 6 characters
</span></span></pre></div>
<a id="trunksrcwpincludesjspluploadhandlersjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/plupload/handlers.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/plupload/handlers.js 2015-03-09 19:08:05 UTC (rev 31689)
+++ trunk/src/wp-includes/js/plupload/handlers.js 2015-03-09 19:43:49 UTC (rev 31690)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -448,7 +448,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> uploader.init();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> uploader.bind('FilesAdded', function( up, files ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $('#media-upload-error').html('');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $('#media-upload-error').empty();
</ins><span class="cx" style="display: block; padding: 0 10px"> uploadStart();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> plupload.each( files, function( file ) {
</span></span></pre></div>
<a id="trunksrcwpincludesjswpajaxresponsejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/wp-ajax-response.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/wp-ajax-response.js 2015-03-09 19:08:05 UTC (rev 31689)
+++ trunk/src/wp-includes/js/wp-ajax-response.js 2015-03-09 19:43:49 UTC (rev 31690)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -12,7 +12,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return r;
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> parseAjaxResponse: function( x, r, e ) { // 1 = good, 0 = strange (bad data?), -1 = you lack permission
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var parsed = {}, re = jQuery('#' + r).html(''), err = '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var parsed = {}, re = jQuery('#' + r).empty(), err = '';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( x && typeof x == 'object' && x.getElementsByTagName('wp_ajax') ) {
</span><span class="cx" style="display: block; padding: 0 10px"> parsed.responses = [];
</span></span></pre>
</div>
</div>
</body>
</html>