<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[31620] trunk/src: Allow inline editing of `width` and `height` parameters while previewing an embed in the media modal:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/31620">31620</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/31620","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>wonderboymusic</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-03-05 05:59:10 +0000 (Thu, 05 Mar 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Allow inline editing of `width` and `height` parameters while previewing an embed in the media modal:
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* Allow a URL to transition to a shortcode (and vice versa) when returning an embed to TinyMCE
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.
This is a first pass to allow broad testing with recent MCE view changes.
See <a href="https://core.trac.wordpress.org/ticket/31139">#31139</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminincludesajaxactionsphp">trunk/src/wp-admin/includes/ajax-actions.php</a></li>
<li><a href="#trunksrcwpincludesclasswpembedphp">trunk/src/wp-includes/class-wp-embed.php</a></li>
<li><a href="#trunksrcwpincludescssmediaviewscss">trunk/src/wp-includes/css/media-views.css</a></li>
<li><a href="#trunksrcwpincludesjsmceviewjs">trunk/src/wp-includes/js/mce-view.js</a></li>
<li><a href="#trunksrcwpincludesjsmediaviewsembedlinkjs">trunk/src/wp-includes/js/media/views/embed/link.js</a></li>
<li><a href="#trunksrcwpincludesjsmediaviewsjs">trunk/src/wp-includes/js/media/views.js</a></li>
<li><a href="#trunksrcwpincludesmediatemplatephp">trunk/src/wp-includes/media-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminincludesajaxactionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-admin/includes/ajax-actions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-admin/includes/ajax-actions.php 2015-03-05 05:34:40 UTC (rev 31619)
+++ trunk/src/wp-admin/includes/ajax-actions.php 2015-03-05 05:59:10 UTC (rev 31620)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2708,13 +2708,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $shortcode = wp_unslash( $_POST['shortcode'] );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $url = str_replace( '[embed]', '', str_replace( '[/embed]', '', $shortcode ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ preg_match( '/' . get_shortcode_regex() . '/s', $shortcode, $matches );
+ $atts = shortcode_parse_atts( $matches[3] );
+ if ( ! empty( $atts[5] ) ) {
+ $url = $atts[5];
+ } elseif ( ! empty( $atts['src'] ) ) {
+ $url = $atts['src'];
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $parsed = false;
</span><span class="cx" style="display: block; padding: 0 10px"> setup_postdata( $post );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $wp_embed->return_false_on_fail = true;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( is_ssl() && preg_match( '%^\\[embed[^\\]]*\\]http://%i', $shortcode ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( is_ssl() && 0 === strpos( $url, 'http://' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> // Admin is ssl and the user pasted non-ssl URL.
</span><span class="cx" style="display: block; padding: 0 10px"> // Check if the provider supports ssl embeds and use that for the preview.
</span><span class="cx" style="display: block; padding: 0 10px"> $ssl_shortcode = preg_replace( '%^(\\[embed[^\\]]*\\])http://%i', '$1https://', $shortcode );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2767,7 +2775,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp_send_json_success( array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'body' => $parsed
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'body' => $parsed,
+ 'attr' => $wp_embed->last_attr
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcwpincludesclasswpembedphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/class-wp-embed.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/class-wp-embed.php 2015-03-05 05:34:40 UTC (rev 31619)
+++ trunk/src/wp-includes/class-wp-embed.php 2015-03-05 05:59:10 UTC (rev 31620)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -11,6 +11,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public $post_ID;
</span><span class="cx" style="display: block; padding: 0 10px"> public $usecache = true;
</span><span class="cx" style="display: block; padding: 0 10px"> public $linkifunknown = true;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public $last_attr = array();
+ public $last_url = '';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * When an URL cannot be embedded, return false instead of returning a link
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -134,12 +136,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $url = $attr['src'];
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( empty( $url ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->last_url = $url;
+
+ if ( empty( $url ) ) {
+ $this->last_attr = $attr;
</ins><span class="cx" style="display: block; padding: 0 10px"> return '';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $rawattr = $attr;
</span><span class="cx" style="display: block; padding: 0 10px"> $attr = wp_parse_args( $attr, wp_embed_defaults( $url ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->last_attr = $attr;
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // kses converts & into & and we need to undo this
</span><span class="cx" style="display: block; padding: 0 10px"> // See https://core.trac.wordpress.org/ticket/11311
</span><span class="cx" style="display: block; padding: 0 10px"> $url = str_replace( '&', '&', $url );
</span></span></pre></div>
<a id="trunksrcwpincludescssmediaviewscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/css/media-views.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/css/media-views.css 2015-03-05 05:34:40 UTC (rev 31619)
+++ trunk/src/wp-includes/css/media-views.css 2015-03-05 05:59:10 UTC (rev 31620)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1944,6 +1944,29 @@
</span><span class="cx" style="display: block; padding: 0 10px"> clear: both;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.embed-link-settings .setting {
+ display: none;
+}
+
+.embed-link-dimensions:after {
+ content: '';
+ display: block;
+ clear: both;
+}
+
+.embed-link-dimensions .width,
+.embed-link-dimensions .height {
+ float: left;
+ width: 125px;
+ clear: none;
+ margin-right: 10px;
+}
+
+.embed-link-dimensions input {
+ width: auto;
+ max-width: 110px;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .image-details .embed-media-settings .setting {
</span><span class="cx" style="display: block; padding: 0 10px"> float: none;
</span><span class="cx" style="display: block; padding: 0 10px"> width: auto;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1990,6 +2013,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .media-embed .setting span {
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> width: 200px;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ max-width: 100%;
</ins><span class="cx" style="display: block; padding: 0 10px"> font-size: 13px;
</span><span class="cx" style="display: block; padding: 0 10px"> line-height: 24px;
</span><span class="cx" style="display: block; padding: 0 10px"> color: #666;
</span></span></pre></div>
<a id="trunksrcwpincludesjsmceviewjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/mce-view.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/mce-view.js 2015-03-05 05:34:40 UTC (rev 31619)
+++ trunk/src/wp-includes/js/mce-view.js 2015-03-05 05:59:10 UTC (rev 31620)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -819,22 +819,31 @@
</span><span class="cx" style="display: block; padding: 0 10px"> edit: function( text, update ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var media = wp.media.embed,
</span><span class="cx" style="display: block; padding: 0 10px"> frame = media.edit( text, !! this.url ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- self = this;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self = this,
+ events = 'change:url change:width change:height';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> this.pausePlayers();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- frame.state( 'embed' ).props.on( 'change:url', function( model, url ) {
- if ( url ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ frame.state( 'embed' ).props.on( events, function( model, url ) {
+ if ( url && model.get( 'url' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> frame.state( 'embed' ).metadata = model.toJSON();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> frame.state( 'embed' ).on( 'select', function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( self.url ) {
- update( frame.state( 'embed' ).metadata.url );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var data = frame.state( 'embed' ).metadata;
+
+ if ( data.width ) {
+ delete self.url;
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- update( media.shortcode( frame.state( 'embed' ).metadata ).string() );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self.url = data.url;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ if ( self.url ) {
+ update( data.url );
+ } else {
+ update( media.shortcode( data ).string() );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> frame.on( 'close', function() {
</span></span></pre></div>
<a id="trunksrcwpincludesjsmediaviewsembedlinkjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/media/views/embed/link.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/media/views/embed/link.js 2015-03-05 05:34:40 UTC (rev 31619)
+++ trunk/src/wp-includes/js/media/views/embed/link.js 2015-03-05 05:59:10 UTC (rev 31620)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -20,13 +20,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> initialize: function() {
</span><span class="cx" style="display: block; padding: 0 10px"> this.spinner = $('<span class="spinner" />');
</span><span class="cx" style="display: block; padding: 0 10px"> this.$el.append( this.spinner[0] );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.listenTo( this.model, 'change:url', this.updateoEmbed );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.listenTo( this.model, 'change:url change:width change:height', this.updateoEmbed );
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- updateoEmbed: function() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ updateoEmbed: _.debounce( function() {
</ins><span class="cx" style="display: block; padding: 0 10px"> var url = this.model.get( 'url' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.$('.setting.title').show();
</del><span class="cx" style="display: block; padding: 0 10px"> // clear out previous results
</span><span class="cx" style="display: block; padding: 0 10px"> this.$('.embed-container').hide().find('.embed-preview').html('');
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -37,29 +36,58 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> this.spinner.show();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- setTimeout( _.bind( this.fetch, this ), 500 );
- },
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.fetch();
+ }, 600 ),
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> fetch: function() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var embed;
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // check if they haven't typed in 500 ms
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $('#embed-url-field').val() !== this.model.get('url') ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ embed = new wp.shortcode({
+ tag: 'embed',
+ attrs: _.pick( this.model.attributes, [ 'width', 'height', 'src' ] ),
+ content: this.model.get('url')
+ });
+
</ins><span class="cx" style="display: block; padding: 0 10px"> wp.ajax.send( 'parse-embed', {
</span><span class="cx" style="display: block; padding: 0 10px"> data : {
</span><span class="cx" style="display: block; padding: 0 10px"> post_ID: wp.media.view.settings.post.id,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- shortcode: '[embed]' + this.model.get('url') + '[/embed]'
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ shortcode: embed.string()
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } ).done( _.bind( this.renderoEmbed, this ) );
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> renderoEmbed: function( response ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var html = ( response && response.body ) || '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var html = ( response && response.body ) || '',
+ attr = {},
+ opts = { silent: true };
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( response && response.attr ) {
+ attr = response.attr;
+
+ _.each( [ 'width', 'height' ], function ( key ) {
+ var $el = this.$( '.setting.' + key ),
+ value = attr[ key ];
+
+ if ( value ) {
+ this.model.set( key, value, opts );
+ $el.show().find( 'input' ).val( value );
+ } else {
+ this.model.unset( key, opts );
+ $el.hide().find( 'input' ).val( '' );
+ }
+ }, this );
+ } else {
+ this.model.unset( 'height', opts );
+ this.model.unset( 'width', opts );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> this.spinner.hide();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- this.$('.setting.title').hide();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> this.$('.embed-container').show().find('.embed-preview').html( html );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span></span></pre></div>
<a id="trunksrcwpincludesjsmediaviewsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/media/views.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/media/views.js 2015-03-05 05:34:40 UTC (rev 31619)
+++ trunk/src/wp-includes/js/media/views.js 2015-03-05 05:59:10 UTC (rev 31620)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4597,13 +4597,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> initialize: function() {
</span><span class="cx" style="display: block; padding: 0 10px"> this.spinner = $('<span class="spinner" />');
</span><span class="cx" style="display: block; padding: 0 10px"> this.$el.append( this.spinner[0] );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.listenTo( this.model, 'change:url', this.updateoEmbed );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.listenTo( this.model, 'change:url change:width change:height', this.updateoEmbed );
</ins><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- updateoEmbed: function() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ updateoEmbed: _.debounce( function() {
</ins><span class="cx" style="display: block; padding: 0 10px"> var url = this.model.get( 'url' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- this.$('.setting.title').show();
</del><span class="cx" style="display: block; padding: 0 10px"> // clear out previous results
</span><span class="cx" style="display: block; padding: 0 10px"> this.$('.embed-container').hide().find('.embed-preview').html('');
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4614,29 +4613,58 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> this.spinner.show();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- setTimeout( _.bind( this.fetch, this ), 500 );
- },
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.fetch();
+ }, 600 ),
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> fetch: function() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var embed;
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // check if they haven't typed in 500 ms
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $('#embed-url-field').val() !== this.model.get('url') ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ embed = new wp.shortcode({
+ tag: 'embed',
+ attrs: _.pick( this.model.attributes, [ 'width', 'height', 'src' ] ),
+ content: this.model.get('url')
+ });
+
</ins><span class="cx" style="display: block; padding: 0 10px"> wp.ajax.send( 'parse-embed', {
</span><span class="cx" style="display: block; padding: 0 10px"> data : {
</span><span class="cx" style="display: block; padding: 0 10px"> post_ID: wp.media.view.settings.post.id,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- shortcode: '[embed]' + this.model.get('url') + '[/embed]'
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ shortcode: embed.string()
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } ).done( _.bind( this.renderoEmbed, this ) );
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> renderoEmbed: function( response ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var html = ( response && response.body ) || '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var html = ( response && response.body ) || '',
+ attr = {},
+ opts = { silent: true };
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( response && response.attr ) {
+ attr = response.attr;
+
+ _.each( [ 'width', 'height' ], function ( key ) {
+ var $el = this.$( '.setting.' + key ),
+ value = attr[ key ];
+
+ if ( value ) {
+ this.model.set( key, value, opts );
+ $el.show().find( 'input' ).val( value );
+ } else {
+ this.model.unset( key, opts );
+ $el.hide().find( 'input' ).val( '' );
+ }
+ }, this );
+ } else {
+ this.model.unset( 'height', opts );
+ this.model.unset( 'width', opts );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> this.spinner.hide();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- this.$('.setting.title').hide();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> this.$('.embed-container').show().find('.embed-preview').html( html );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span></span></pre></div>
<a id="trunksrcwpincludesmediatemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/media-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/media-template.php 2015-03-05 05:34:40 UTC (rev 31619)
+++ trunk/src/wp-includes/media-template.php 2015-03-05 05:59:10 UTC (rev 31620)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -819,6 +819,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <span><?php _e( 'Title' ); ?></span>
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" class="alignment" data-setting="title" />
</span><span class="cx" style="display: block; padding: 0 10px"> </label>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <div class="embed-link-dimensions">
+ <label class="setting width">
+ <span><?php _e( 'Maximum Width' ); ?></span>
+ <input type="text" class="alignment" data-setting="width" />
+ </label>
+ <label class="setting height">
+ <span><?php _e( 'Maximum Height' ); ?></span>
+ <input type="text" class="alignment" data-setting="height" />
+ </label>
+ </div>
</ins><span class="cx" style="display: block; padding: 0 10px"> <div class="embed-container" style="display: none;">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="embed-preview"></div>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span></span></pre>
</div>
</div>
</body>
</html>