<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[31276] trunk: In `get_terms()`, check hierarchy for all `$taxonomies` before bailing early from 'parent' or 'child_of'.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/31276">31276</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/31276","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-01-25 02:45:11 +0000 (Sun, 25 Jan 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>In `get_terms()`, check hierarchy for all `$taxonomies` before bailing early from 'parent' or 'child_of'.
There is a pre-check in `get_terms()` that prevents an unnecessary database
query if the 'parent' or 'child_of' parameter is not found in the cached term
hierarchy (since a term without an index in the hierarchy cache has no
descendants). Previously, only the first item in the `$taxonomies` array was
being checked, with the result that an empty array was being erroneously
returned in cases where the 'parent' or 'child_of' term is in a subsequent
taxonomy.
See <a href="https://core.trac.wordpress.org/ticket/31118">#31118</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludestaxonomyphp">trunk/src/wp-includes/taxonomy.php</a></li>
<li><a href="#trunktestsphpunitteststermgetTermsphp">trunk/tests/phpunit/tests/term/getTerms.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludestaxonomyphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/taxonomy.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/taxonomy.php 2015-01-24 18:47:30 UTC (rev 31275)
+++ trunk/src/wp-includes/taxonomy.php 2015-01-25 02:45:11 UTC (rev 31276)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1657,18 +1657,29 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> $args = apply_filters( 'get_terms_args', $args, $taxonomies );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Avoid the query if the queried parent/child_of term has no descendants.
</ins><span class="cx" style="display: block; padding: 0 10px"> $child_of = $args['child_of'];
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $parent = $args['parent'];
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $child_of ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $hierarchy = _get_term_hierarchy( reset( $taxonomies ) );
- if ( ! isset( $hierarchy[ $child_of ] ) ) {
- return $empty_array;
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $_parent = $child_of;
+ } elseif ( $parent ) {
+ $_parent = $parent;
+ } else {
+ $_parent = false;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $parent = $args['parent'];
- if ( $parent ) {
- $hierarchy = _get_term_hierarchy( reset( $taxonomies ) );
- if ( ! isset( $hierarchy[ $parent ] ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $_parent ) {
+ $in_hierarchy = false;
+ foreach ( $taxonomies as $_tax ) {
+ $hierarchy = _get_term_hierarchy( $_tax );
+
+ if ( isset( $hierarchy[ $_parent ] ) ) {
+ $in_hierarchy = true;
+ }
+ }
+
+ if ( ! $in_hierarchy ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> return $empty_array;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1942,9 +1953,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $child_of ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $children = _get_term_hierarchy( reset( $taxonomies ) );
- if ( ! empty( $children ) ) {
- $terms = _get_term_children( $child_of, $terms, reset( $taxonomies ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( $taxonomies as $_tax ) {
+ $children = _get_term_hierarchy( $_tax );
+ if ( ! empty( $children ) ) {
+ $terms = _get_term_children( $child_of, $terms, $_tax );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunitteststermgetTermsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/term/getTerms.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/term/getTerms.php 2015-01-24 18:47:30 UTC (rev 31275)
+++ trunk/tests/phpunit/tests/term/getTerms.php 2015-01-25 02:45:11 UTC (rev 31276)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -377,6 +377,47 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @ticket 31118
+ */
+ public function test_child_of_should_skip_query_when_specified_parent_is_not_found_in_hierarchy_cache() {
+ global $wpdb;
+
+ register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true, ) );
+
+ $terms = $this->factory->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
+
+ $num_queries = $wpdb->num_queries;
+
+ $found = get_terms( 'wptests_tax', array(
+ 'hide_empty' => false,
+ 'child_of' => $terms[0],
+ ) );
+
+ $this->assertEmpty( $found );
+ $this->assertSame( $num_queries, $wpdb->num_queries );
+ }
+
+ /**
+ * @ticket 31118
+ */
+ public function test_child_of_should_respect_multiple_taxonomies() {
+ register_taxonomy( 'wptests_tax1', 'post', array( 'hierarchical' => true ) );
+ register_taxonomy( 'wptests_tax2', 'post', array( 'hierarchical' => true ) );
+
+ $t1 = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax1' ) );
+ $t2 = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax2' ) );
+ $t3 = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax2', 'parent' => $t2 ) );
+
+ $found = get_terms( array( 'wptests_tax1', 'wptests_tax2' ), array(
+ 'fields' => 'ids',
+ 'hide_empty' => false,
+ 'child_of' => $t2,
+ ) );
+
+ $this->assertEqualSets( array( $t3 ), $found );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * @ticket 27123
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function test_get_term_children_recursion() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1156,6 +1197,47 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEqualSets( $expected, $actual );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * @ticket 31118
+ */
+ public function test_parent_should_skip_query_when_specified_parent_is_not_found_in_hierarchy_cache() {
+ global $wpdb;
+
+ register_taxonomy( 'wptests_tax', 'post', array( 'hierarchical' => true, ) );
+
+ $terms = $this->factory->term->create_many( 3, array( 'taxonomy' => 'wptests_tax' ) );
+
+ $num_queries = $wpdb->num_queries;
+
+ $found = get_terms( 'wptests_tax', array(
+ 'hide_empty' => false,
+ 'parent' => $terms[0],
+ ) );
+
+ $this->assertEmpty( $found );
+ $this->assertSame( $num_queries, $wpdb->num_queries );
+ }
+
+ /**
+ * @ticket 31118
+ */
+ public function test_parent_should_respect_multiple_taxonomies() {
+ register_taxonomy( 'wptests_tax1', 'post', array( 'hierarchical' => true ) );
+ register_taxonomy( 'wptests_tax2', 'post', array( 'hierarchical' => true ) );
+
+ $t1 = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax1' ) );
+ $t2 = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax2' ) );
+ $t3 = $this->factory->term->create( array( 'taxonomy' => 'wptests_tax2', 'parent' => $t2 ) );
+
+ $found = get_terms( array( 'wptests_tax1', 'wptests_tax2' ), array(
+ 'fields' => 'ids',
+ 'hide_empty' => false,
+ 'parent' => $t2,
+ ) );
+
+ $this->assertEqualSets( array( $t3 ), $found );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_hierarchical_false_parent_should_override_child_of() {
</span><span class="cx" style="display: block; padding: 0 10px"> $initial_terms = $this->create_hierarchical_terms();
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>