<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[30940] branches/4.1/src: No need for wp_get_password_hint() to be prefixed as if it is private.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/30940">30940</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/30940","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-12-16 22:18:48 +0000 (Tue, 16 Dec 2014)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>No need for wp_get_password_hint() to be prefixed as if it is private.

Merges <a href="https://core.trac.wordpress.org/changeset/30855">[30855]</a> to the 4.1 branch.

props nacin.
see <a href="https://core.trac.wordpress.org/ticket/21243">#21243</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#branches41srcwpadmininstallphp">branches/4.1/src/wp-admin/install.php</a></li>
<li><a href="#branches41srcwpadminusereditphp">branches/4.1/src/wp-admin/user-edit.php</a></li>
<li><a href="#branches41srcwpadminusernewphp">branches/4.1/src/wp-admin/user-new.php</a></li>
<li><a href="#branches41srcwpincludesuserphp">branches/4.1/src/wp-includes/user.php</a></li>
<li><a href="#branches41srcwploginphp">branches/4.1/src/wp-login.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches41srcwpadmininstallphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.1/src/wp-admin/install.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.1/src/wp-admin/install.php     2014-12-16 22:08:10 UTC (rev 30939)
+++ branches/4.1/src/wp-admin/install.php       2014-12-16 22:18:48 UTC (rev 30940)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -133,7 +133,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                <input name="admin_password" type="password" id="pass1" size="25" value="" />
</span><span class="cx" style="display: block; padding: 0 10px">                                <p><input name="admin_password2" type="password" id="pass2" size="25" value="" /></p>
</span><span class="cx" style="display: block; padding: 0 10px">                                <div id="pass-strength-result"><?php _e('Strength indicator'); ?></div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                <p><?php echo _wp_get_password_hint(); ?></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         <p><?php echo wp_get_password_hint(); ?></p>
</ins><span class="cx" style="display: block; padding: 0 10px">                         </td>
</span><span class="cx" style="display: block; padding: 0 10px">                </tr>
</span><span class="cx" style="display: block; padding: 0 10px">                <?php endif; ?>
</span></span></pre></div>
<a id="branches41srcwpadminusereditphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.1/src/wp-admin/user-edit.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.1/src/wp-admin/user-edit.php   2014-12-16 22:08:10 UTC (rev 30939)
+++ branches/4.1/src/wp-admin/user-edit.php     2014-12-16 22:18:48 UTC (rev 30940)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -479,7 +479,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">        <p class="description"><?php _e( 'Type your new password again.' ); ?></p>
</span><span class="cx" style="display: block; padding: 0 10px">        <br />
</span><span class="cx" style="display: block; padding: 0 10px">        <div id="pass-strength-result"><?php _e( 'Strength indicator' ); ?></div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-        <p class="description indicator-hint"><?php echo _wp_get_password_hint(); ?></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p class="description indicator-hint"><?php echo wp_get_password_hint(); ?></p>
</ins><span class="cx" style="display: block; padding: 0 10px">         </td>
</span><span class="cx" style="display: block; padding: 0 10px"> </tr>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span></span></pre></div>
<a id="branches41srcwpadminusernewphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.1/src/wp-admin/user-new.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.1/src/wp-admin/user-new.php    2014-12-16 22:08:10 UTC (rev 30939)
+++ branches/4.1/src/wp-admin/user-new.php      2014-12-16 22:18:48 UTC (rev 30940)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -398,7 +398,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                <input name="pass2" type="password" id="pass2" autocomplete="off" />
</span><span class="cx" style="display: block; padding: 0 10px">                <br />
</span><span class="cx" style="display: block; padding: 0 10px">                <div id="pass-strength-result"><?php _e('Strength indicator'); ?></div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                <p class="description indicator-hint"><?php echo _wp_get_password_hint(); ?></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         <p class="description indicator-hint"><?php echo wp_get_password_hint(); ?></p>
</ins><span class="cx" style="display: block; padding: 0 10px">                 </td>
</span><span class="cx" style="display: block; padding: 0 10px">        </tr>
</span><span class="cx" style="display: block; padding: 0 10px">        <tr>
</span></span></pre></div>
<a id="branches41srcwpincludesuserphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.1/src/wp-includes/user.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.1/src/wp-includes/user.php     2014-12-16 22:08:10 UTC (rev 30939)
+++ branches/4.1/src/wp-includes/user.php       2014-12-16 22:18:48 UTC (rev 30940)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2093,11 +2093,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">  * Gets the text suggesting how to create strong passwords.
</span><span class="cx" style="display: block; padding: 0 10px">  *
</span><span class="cx" style="display: block; padding: 0 10px">  * @since 4.1.0
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @access private
</del><span class="cx" style="display: block; padding: 0 10px">  *
</span><span class="cx" style="display: block; padding: 0 10px">  * @return string The password hint text.
</span><span class="cx" style="display: block; padding: 0 10px">  */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function _wp_get_password_hint() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function wp_get_password_hint() {
</ins><span class="cx" style="display: block; padding: 0 10px">         $hint = __( 'Hint: The password should be at least seven characters long. To make it stronger, use upper and lower case letters, numbers, and symbols like ! " ? $ % ^ &amp; ).' );
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">        /**
</span></span></pre></div>
<a id="branches41srcwploginphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/4.1/src/wp-login.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/4.1/src/wp-login.php     2014-12-16 22:08:10 UTC (rev 30939)
+++ branches/4.1/src/wp-login.php       2014-12-16 22:18:48 UTC (rev 30940)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -635,7 +635,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">        </p>
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">        <div id="pass-strength-result" class="hide-if-no-js"><?php _e('Strength indicator'); ?></div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-        <p class="description indicator-hint"><?php echo _wp_get_password_hint(); ?></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p class="description indicator-hint"><?php echo wp_get_password_hint(); ?></p>
</ins><span class="cx" style="display: block; padding: 0 10px">         <br class="clear" />
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">        <?php
</span></span></pre>
</div>
</div>

</body>
</html>