<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[30468] branches/3.9: Prevent high resource usage when hashing large passwords.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/30468">30468</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/30468","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>nacin</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-11-20 16:05:10 +0000 (Thu, 20 Nov 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Prevent high resource usage when hashing large passwords. props mdawaffe, pento
Merges <a href="https://core.trac.wordpress.org/changeset/30466">[30466]</a> to the 3.9 branch.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches39srcwpincludesclassphpassphp">branches/3.9/src/wp-includes/class-phpass.php</a></li>
<li><a href="#branches39testsphpunittestsauthphp">branches/3.9/tests/phpunit/tests/auth.php</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#branches39">branches/3.9/</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx" style="display: block; padding: 0 10px">Index: branches/3.9
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- branches/3.9 2014-11-20 16:04:26 UTC (rev 30467)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ branches/3.9 2014-11-20 16:05:10 UTC (rev 30468)
</ins><a id="branches39"></a>
<div class="propset"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Property changes: branches/3.9</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: svn:mergeinfo</h4></div>
<span class="cx" style="display: block; padding: 0 10px"> /branches/3.1:18031
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/3.3:20543
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/3.4:21757
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/trunk:18512,28158,28161,28163,28165-28166,28168-28169,28171-28174,28176-28187,28189-28191,28193-28195,28203,28219,28223,28266,28269,28275-28276,28280,28284,29327,29377-29378,29381-29382,29397,29404,29631,30412,30417,30422,30425,30430,30435,30438,30443,30458
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/trunk:18512,28158,28161,28163,28165-28166,28168-28169,28171-28174,28176-28187,28189-28191,28193-28195,28203,28219,28223,28266,28269,28275-28276,28280,28284,29327,29377-29378,29381-29382,29397,29404,29631,30412,30417,30422,30425,30430,30435,30438,30443,30458,30466
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="branches39srcwpincludesclassphpassphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/3.9/src/wp-includes/class-phpass.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/3.9/src/wp-includes/class-phpass.php 2014-11-20 16:04:26 UTC (rev 30467)
+++ branches/3.9/src/wp-includes/class-phpass.php 2014-11-20 16:05:10 UTC (rev 30468)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -214,6 +214,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function HashPassword($password)
</span><span class="cx" style="display: block; padding: 0 10px"> {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( strlen( $password ) > 4096 ) {
+ return '*';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $random = '';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if (CRYPT_BLOWFISH == 1 && !$this->portable_hashes) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -249,6 +253,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function CheckPassword($password, $stored_hash)
</span><span class="cx" style="display: block; padding: 0 10px"> {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( strlen( $password ) > 4096 ) {
+ return false;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $hash = $this->crypt_private($password, $stored_hash);
</span><span class="cx" style="display: block; padding: 0 10px"> if ($hash[0] == '*')
</span><span class="cx" style="display: block; padding: 0 10px"> $hash = crypt($password, $stored_hash);
</span></span></pre></div>
<a id="branches39testsphpunittestsauthphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/3.9/tests/phpunit/tests/auth.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/3.9/tests/phpunit/tests/auth.php 2014-11-20 16:04:26 UTC (rev 30467)
+++ branches/3.9/tests/phpunit/tests/auth.php 2014-11-20 16:05:10 UTC (rev 30468)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2,6 +2,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @group pluggable
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @group auth
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class Tests_Auth extends WP_UnitTestCase {
</span><span class="cx" style="display: block; padding: 0 10px"> var $user_id;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -91,4 +92,49 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $password = "pass with vertial tab o_O\x0B";
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( wp_check_password( 'pass with vertial tab o_O', wp_hash_password( $password ) ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ function test_password_length_limit() {
+ $passwords = array(
+ str_repeat( 'a', 4095 ), // short
+ str_repeat( 'a', 4096 ), // limit
+ str_repeat( 'a', 4097 ), // long
+ );
+
+ $user_id = $this->factory->user->create( array( 'user_login' => 'password-length-test' ) );
+
+ wp_set_password( $passwords[1], $user_id );
+ $user = get_user_by( 'id', $user_id );
+ // phpass hashed password
+ $this->assertStringStartsWith( '$P$', $user->data->user_pass );
+
+ $user = wp_authenticate( 'password-length-test', $passwords[0] );
+ // Wrong Password
+ $this->assertInstanceOf( 'WP_Error', $user );
+
+ $user = wp_authenticate( 'password-length-test', $passwords[1] );
+ $this->assertInstanceOf( 'WP_User', $user );
+ $this->assertEquals( $user_id, $user->ID );
+
+ $user = wp_authenticate( 'password-length-test', $passwords[2] );
+ // Wrong Password
+ $this->assertInstanceOf( 'WP_Error', $user );
+
+
+ wp_set_password( $passwords[2], $user_id );
+ $user = get_user_by( 'id', $user_id );
+ // Password broken by setting it to be too long.
+ $this->assertEquals( '*', $user->data->user_pass );
+
+ $user = wp_authenticate( 'password-length-test', $passwords[0] );
+ // Wrong Password
+ $this->assertInstanceOf( 'WP_Error', $user );
+
+ $user = wp_authenticate( 'password-length-test', $passwords[1] );
+ // Wrong Password
+ $this->assertInstanceOf( 'WP_Error', $user );
+
+ $user = wp_authenticate( 'password-length-test', $passwords[2] );
+ // Password broken by setting it to be too long.
+ $this->assertInstanceOf( 'WP_Error', $user );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>